[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user andreszs commented on the issue: https://github.com/apache/cordova-lib/pull/492 @dpogue That worked perfectly, thank you!! +10 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/492 @andreszs Something like this should work: ```xml ``` --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user andreszs commented on the issue: https://github.com/apache/cordova-lib/pull/492 @ktop Please let me know if the plugin can be used to add the attribute `android:installLocation="auto"` into the `manifest` node itself. The docs only explain how to add **child nodes**, and I really tried many ways to add only this attribute only without success. Thank you. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 Thanks for sending this pr @ktop! I've merged it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 I'm going to merge this in for now so I can get the common release out. But it is definitely worth discussing some of these points. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 `remove` wouldn't be a revert right. Since you have no way to store what got overwritten/merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 do you have a usecase example when remove might be useful? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 @ktop so if I remove an `edit-config` tag from my `config.xml`, it won't actually remove it from `AndroidManifest.xml`. Guessing the solution for users in this case would be to rm and re-add the android platform. That seems fine to me. This is only for merging and overwriting. For adding new elements, we should use `config-file` still? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/492 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/492?src=pr) is 80.38% (diff: 100%) > Merging [#492](https://codecov.io/gh/apache/cordova-lib/pull/492?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage ```diff @@ master #492 diff @@ == Files67 67 Lines 5184 5184 Methods 835835 Messages 0 0 Branches 1005 1005 == Hits 4167 4167 Misses 1017 1017 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [63efd21...de8a367](https://codecov.io/gh/apache/cordova-lib/compare/63efd2174fe20b9c573b23a741257a6170dec3b6...de8a367fe4fe553ace4a72c0b5edb12135589270?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user ktop commented on the issue: https://github.com/apache/cordova-lib/pull/492 Thanks, I fixed the errors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 JSHint is failing for you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
