[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/568 Thanks for the feedback @stevengill, good point. I've just removed `npm run ci` and updated travis and appveyor to just run `npm test` - just like a developer would on their local machine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/568 looks good to me. Only thing I would add is updating travis and appveyor as well. They run the integration tests as a separate task currently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...
Github user imhotep commented on the issue: https://github.com/apache/cordova-lib/pull/568 I support this change. I believe it will make writing tests for new features easier if each source file has a matching spec file and all source/spec folders are mirrored. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/568 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=h1) Report > Merging [#568](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/1a28929564d32d8a85dca039ee8f34656c594dfd?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #568 +/- ## === Coverage 44.11% 44.11% === Files 78 78 Lines4348 4348 Branches 852 852 === Hits 1918 1918 Misses 2430 2430 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=footer). Last update [1a28929...bc4218e](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
