[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194196784 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194025822 Thanks @riknoll!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194025033 Added you both as owners. The tests use cordova-android version 3.1.0, which is checked into cordova-lib: ``` cordova-lib/cordova-lib/spec-cordova/fixtures/platforms/android ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194021132 LGTM. Question though, what version of android are the tests using? What version gets fetched (1.1.2 it looks like)? Maybe add vlad and me as owners to the module on npm. Always smart to have a few people who can publish if needed. `npm owner add stevegill cordova-lib-test-plugin` `npm owner add kotikov.vladimir cordova-lib-test-plugin` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-193942230 @stevengill @vladimir-kotikov please review when you have a moment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/406 CB-10679: Improving version choosing logic test coverage This adds a test plugin to improve our end to end tests related to the new plugin version choosing logic implementation. The plugin itself is empty and published to npm under my account: https://www.npmjs.com/package/cordova-lib-test-plugin . I also added a test case for git URLs, because we were missing one. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib test-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/406.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #406 commit 8eed08ef17d06cde56df1d2a42ec2f2f8124843e Author: riknoll Date: 2016-03-08T00:10:22Z CB-10679: Improving version choosing logic test coverage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
