[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-10-24 Thread grega
Github user grega commented on the pull request:

https://github.com/apache/cordova-lib/pull/40#issuecomment-60440885
  
See: 
https://github.com/MSOpenTech/cordova-lib/commit/6d7f87776b99299dd7fdb8371da9d5b05982e4fd


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-07-24 Thread grega
Github user grega commented on the pull request:

https://github.com/apache/cordova-lib/pull/40#issuecomment-50050846
  
I'm still seeing issues with this when using the é character in 
`config.xml`: `Attaché`

```
cordova platform add ios -d
Platform files for "ios" previously downloaded not from npm. Using that 
copy.
Creating ios project...
Running command: /Users/greg/.cordova/lib/ios/cordova/3.5.0/bin/create 
--arc --cli /Users/greg/Dropbox/Vagrant/attache/mobile/attache/platforms/ios 
com.ionicframework.attache Attaché
Command finished with error code 0: 
/Users/greg/.cordova/lib/ios/cordova/3.5.0/bin/create 
--arc,--cli,/Users/greg/Dropbox/Vagrant/attache/mobile/attache/platforms/ios,com.ionicframework.attache,Attaché
Generating config.xml from defaults for platform "ios"
Calling plugman.prepare for platform "ios"
Preparing ios project
Processing configuration changes for plugins.
Iterating over installed plugins: []
Writing out cordova_plugins.js...
Wrote out iOS Bundle Identifier to "com.ionicframework.attache"
Wrote out iOS Bundle Version to "0.0.2"
mv: dest file already exists: 
/Users/greg/Dropbox/Vagrant/attache/mobile/attache/platforms/ios/Attaché/Attaché-Info.plist

mv: dest file already exists: 
/Users/greg/Dropbox/Vagrant/attache/mobile/attache/platforms/ios/Attaché/Attaché-Prefix.pch

shell.js: internal error
Error: EINVAL, invalid argument 
'/Users/greg/Dropbox/Vagrant/attache/mobile/attache/platforms/ios/Attaché.xcodeproj'
at Object.fs.renameSync (fs.js:543:18)
at 
/Users/greg/node_modules/cordova-lib/cordova-lib/node_modules/shelljs/shell.js:495:8
at Array.forEach (native)
at Object._mv 
(/Users/greg/node_modules/cordova-lib/cordova-lib/node_modules/shelljs/shell.js:471:11)
at Object.mv 
(/Users/greg/node_modules/cordova-lib/cordova-lib/node_modules/shelljs/shell.js:1491:23)
at pbxProject. 
(/Users/greg/node_modules/cordova-lib/cordova-lib/src/cordova/metadata/ios_parser.js:152:27)
at pbxProject.EventEmitter.emit (events.js:98:17)
at pbxProject. 
(/Users/greg/node_modules/cordova-lib/cordova-lib/node_modules/xcode/lib/pbxProject.js:30:18)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at handleMessage (child_process.js:322:10)
```

The changes in 
https://github.com/apache/cordova-lib/commit/9bb739e1cca095613ac656fc562cabe1c6f2af11
 appear to output as expected:

line 45: `unorm.nfd(this.originalName)` = `Attaché`
line 50 `unorm.nfd(project)` = 
`/Users/greg/Dropbox/Vagrant/attache/mobile/attache/platforms/ios`

Any ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-07-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-06-23 Thread vladimir-kotikov
GitHub user vladimir-kotikov reopened a pull request:

https://github.com/apache/cordova-lib/pull/40

CB-6992 Fixes ios platform add/prepare step failure when app name contains 
unicode characters

See [CB-6992](https://issues.apache.org/jira/browse/CB-6992) for details.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-6992

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 5c0be7ff9ff5c59cc9479b36b83f9df695c5ca59
Author: Vladimir Kotikov 
Date:   2014-06-23T13:36:54Z

CB-6992 Fixes ios platform add/prepare step failure when app name contains 
unicode characters




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-06-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/40#issuecomment-46853998
  
Retested. Works fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-06-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/40#issuecomment-46851053
  
Found that this breaks add/prepare step on one of my machines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-06-23 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at:

https://github.com/apache/cordova-lib/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6992 Fixes ios platform add/prepare s...

2014-06-23 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/40

CB-6992 Fixes ios platform add/prepare step failure when app name contains 
unicode characters



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-6992

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 6603a6f897c0cea93c97c9cb361c45f938b2d678
Author: Vladimir Kotikov 
Date:   2014-06-23T13:36:54Z

CB-6992 Fixes ios platform add/prepare step failure when app name contains 
unicode characters




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---