[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-79026418 This is merged in https://github.com/apache/cordova-lib/commit/b03b4d7ddec982b00e6f009468ffa8db59c56e1c. @omefire could you please close this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/184#discussion_r26392721
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -185,8 +185,9 @@ module.exports = function plugin(command, targets,
opts) {
});
if (missingVariables.length) {
shell.rm('-rf', dir);
-events.emit('results', 'Variable(s) missing
(use: --variable ' + missingVariables.join('=value --variable ') + '=value).');
-return;
+var msg = 'Variable(s) missing (use:
--variable ' + missingVariables.join('=value --variable ') + '=value).';
+events.emit('results', msg);
--- End diff --
There is no need to emit the results event to log error message to console.
There is a an error handler in cordova-cli which does this already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-78815446 @vladimir-kotikov Can you please help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...
Github user glasser commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-78213647 Awesome, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/184 CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified. CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-7698 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit a5098b7758d6ad11e7fa7f2b0b22090088103314 Author: Omar Mefire Date: 2015-03-11T06:46:07Z CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
