[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user faenschi commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-138480152 Should this work with cordova 4.3.1? Nothing happens if I add android-activityName="MyName" to config.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user fredgalvao commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-13548 Shouldn't this be documented somewhere? It does not appear when I run `cordova help create` as a valid option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-76387512 @agrieve I've addressed your comments, could you take another look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187454
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
+ args.push(activityName);
--- End diff --
Thanks for the review. I'll add this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187402
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
--- End diff --
Yup, typo there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25186284
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
+ args.push(activityName);
--- End diff --
We need this to continue to work for older versions of cordova-android. You
should add this arg only if:
semver.gte(platDetails.version, '4.0.0-dev')
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25185875
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
--- End diff --
why not allow any Ws? did you mean `\W`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-lib/pull/171 CB-7827: Allow user to specify android activity name This change adds an attribute to config.xml android-activityName that can be used to specify a custom activity name. If none is specified it will still default to MainActivity. See http://markmail.org/message/pj5ig4b54nk4l7dr for a discussion of this issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-lib cb7827 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #171 commit 72b98af250e4d5b69715b1c0eda7f03fd380756a Author: Connor Pearson Date: 2015-02-22T20:46:23Z CB-7827: Allow user to specify android activity name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
