[GitHub] cordova-lib pull request: CB-8965 Prevent cli from copying cordova...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/252 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8965 Prevent cli from copying cordova...
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/252#discussion_r33314883
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -161,8 +161,17 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
}
return superspawn.spawn(bin, args, copts);
}).then(function() {
-copy_cordova_js(projectRoot, platform);
-copy_cordovajs_src(projectRoot, platform,
platDetails.libDir);
+var platform_www = path.join(projectRoot, 'platforms',
platform, 'platform_www');
+
+// only want to copy cordova_js once, when the
platform is added
+if (!fs.existsSync(path.join(platform_www,
'cordova.js'))) {
+copy_cordova_js(projectRoot, platform);
+}
+
+// only want to copy cordova-js-src once, when the
platform is added
+if (!fs.existsSync(path.join(platform_www,
'cordova-js-src'))) {
--- End diff --
Keep this check as we are moving this functionality to platform create
scripts and don't want to run this command again if it already exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8965 Prevent cli from copying cordova...
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/252#discussion_r33314837
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -161,8 +161,17 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
}
return superspawn.spawn(bin, args, copts);
}).then(function() {
-copy_cordova_js(projectRoot, platform);
-copy_cordovajs_src(projectRoot, platform,
platDetails.libDir);
+var platform_www = path.join(projectRoot, 'platforms',
platform, 'platform_www');
+
+// only want to copy cordova_js once, when the
platform is added
+if (!fs.existsSync(path.join(platform_www,
'cordova.js'))) {
--- End diff --
You don't need this check. These functions only get run once when the
platform gets added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8965 Prevent cli from copying cordova...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/252#issuecomment-115421292 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8965 Prevent cli from copying cordova...
GitHub user surajpindoria opened a pull request: https://github.com/apache/cordova-lib/pull/252 CB-8965 Prevent cli from copying cordova.js and cordova-js-src/ multiple times You can merge this pull request into a Git repository by running: $ git pull https://github.com/surajpindoria/cordova-lib CB-8965 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/252.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #252 commit e0f08abe3852a8cb24fc752567d7ae60c3438004 Author: Suraj Pindoria Date: 2015-06-25T20:58:05Z CB-8965 Prevent cli from copying cordova.js and cordova-js-src/ multiple times --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
