[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/265#issuecomment-122580399 I wasn't a fan of the `cryptic` optimizations we were doing to begin with, as it rendered the code more cryptic than it needed to be. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/265#issuecomment-122602056 Awesome ! Thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/265#issuecomment-122580433 @purplecabbage LGTM ! But could you also add a comment to specify all the forms that 'git_ref' could assume ? (branch, commit SHA, etc...). That might prevent attempts at optimizations that will break this scenario again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/265#issuecomment-122583017 Yeah. I'll add it to the docs too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/265 CB-9384 Plugman should be able to checkout a commit SHA actually checkout git_ref because it may be a branch OR a commit SHA This functionality was lost when CB-8908 was implemented. The fix will still clone with depth=1 IF a branch or a commit sha was not specified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-lib AllowGitCommitSHA Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/265.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #265 commit 9af173a65281e9ea87fc6da3ee0b9f10bb8fec1c Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-17T23:27:18Z actually checkout git_ref because it may be a branch OR a commit SHA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
