[GitHub] cordova-lib pull request: Fix create argument prerequisite check

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/337#issuecomment-152500036
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Fix create argument prerequisite check

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/337


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Fix create argument prerequisite check

[ZombieProtectionAgency]

GitHub user ZombieProtectionAgency opened a pull request:

https://github.com/apache/cordova-lib/pull/337

Fix create argument prerequisite check

Store argument.length from create before return call
Update returns prerequisite checks to use the previously stored arg length

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ZombieProtectionAgency/cordova-lib 
create_fix_dynamic_arg_check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #337


commit adde1be3b7b60be54cf8e43fde363319e57d722a
Author: Toni 
Date:   2015-10-29T22:05:04Z

Fix create argument prerequisite check

Store argument.length from create before return call
Update returns prerequisite checks to use the previously stored arg length




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org