[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-123516003 This change has already been applied here: dff78b0779444d06e259140694e07d5e8c5f5308 Please close this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101574980 This should probably also use __.uniq Instead of the double loop, or __.union --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101572757 +1 'concat does not alter this or any of the arrays ... ' https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/concat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101544132 Can you briefly describe what bug this bug fix solves? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: The concat() method returns a new array.
GitHub user 007slm opened a pull request: https://github.com/apache/cordova-lib/pull/216 The concat() method returns a new array. the ios plist file can not add more than one dict CFBundleURLTypes arrays when use cordova plugman add plugin in ios platform. You can merge this pull request into a Git repository by running: $ git pull https://github.com/007slm/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #216 commit da243dfaaecb7a83858ea8563ea7f9c9f3fc3563 Author: 007slm <007...@163.com> Date: 2015-05-13T07:07:54Z The concat() method returns a new array. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
