[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/23#discussion_r23759837
--- Diff: cordova.conf ---
@@ -110,6 +108,13 @@ from buildbot.config import BuilderConfig
from buildbot.process.factory import BuildFactory
from buildbot.steps.transfer import FileDownload
+def RMCommand(path, **kwargs):
+js_script = var s = require('shelljs'); console.log('removing
{path}'); s.rm('-rf', '{path}');.format(path=path)
+return ShellCommand(command=['node', '-e', js_script], **kwargs)
+
+def InstallShellJS():
--- End diff --
Why is it a global requirement? We run `npm install` in the medic directory
when we use it, and `grunt-cli` is inside `package.json`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/23#discussion_r23556323
--- Diff: cordova.conf ---
@@ -110,6 +108,13 @@ from buildbot.config import BuilderConfig
from buildbot.process.factory import BuildFactory
from buildbot.steps.transfer import FileDownload
+def RMCommand(path, **kwargs):
+js_script = var s = require('shelljs'); console.log('removing
{path}'); s.rm('-rf', '{path}');.format(path=path)
+return ShellCommand(command=['node', '-e', js_script], **kwargs)
+
+def InstallShellJS():
--- End diff --
Another way is to note shelljs as a prerequisite for build slave (like the
grunt-cli (https://github.com/apache/cordova-medic#install-prerequisites))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/23 [INFRA-8588] Fixed a bug for ASF Buildbot, and a bug for Windows. Fixed a bug causing errors in Apache Buildbot. Improved cleanup method to work on Windows. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic INFRA-8588 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 7764f0ac6ddc5398cb1e06761d28b903ee9dddb7 Author: Dmitry Blotsky dblot...@microsoft.com Date: 2015-01-23T22:42:55Z [INFRA-8588] Fixed bug for ASF Buildbot. Made build cleanup step work on Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
