[GitHub] cordova-osx issue #43: CB-13424: "cordova plugin add/remove" writes changes ...
Github user JoseExposito commented on the issue: https://github.com/apache/cordova-osx/pull/43 Thanks for reviewing @giuseppelt, changed --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-osx issue #43: CB-13424: "cordova plugin add/remove" writes changes ...
Github user JoseExposito commented on the issue: https://github.com/apache/cordova-osx/pull/43 Indeed, the logic comes from iOS/Android. Basically, I updated the cordova-common library to match the iOS version and used it in the plugin add/remove hooks like other platforms are doing. In my opinion the macOS platform will need more updates to match the structure other platforms are using... But for the moment this fixes the issue. Once I see if the team is open to community PRs you can expect more changes :) --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-osx issue #43: CB-13424: "cordova plugin add/remove" writes changes ...
Github user janpio commented on the issue: https://github.com/apache/cordova-osx/pull/43 Yay, that was quick. Can you talk me (and everybody reading) through the changes? Where does the logic come from? ios? --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
