[GitHub] cordova-plugin-camera pull request: Add pull request template

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218547172
  
Thanks for the feedback! I made some updates based on feedback. 

As far as running tests - we're automating that process using Jenkins, 
Travis CI as appropriate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218282825
  
great points @tony-- ! +1 to all of 'em


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[tony--]

Github user tony-- commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218277348
  
There are a couple places that contributor workflow is documented:
The wiki has a [contributor workflow 
page](https://wiki.apache.org/cordova/ContributorWorkflow) which also points to 
the [issue workflow page](https://wiki.apache.org/cordova/IssueWorkflow).
The docs have a [Contributor Guidelines 
page](http://cordova.apache.org/contribute/contribute_guidelines.html).

I guess the wiki pages are pretty much obsolete and the docs workflow is 
more current.

It seems like it would make sense to at least point to the docs page from 
the template, something like:
"This checklist is intended as a quick reference, for complete details 
please see our [Contributor 
Guidelines](http://cordova.apache.org/contribute/contribute_guidelines.html)".  
It would make sense to have the template checklist reflect the outline 
structure of the docs page workflow.  I guess this would mean add steps for 
getting code reviewed, running tests and commit message guideline.

If any requirements are added (e.g., PR title guideline) or changed as part 
of this, the docs should be updated to match the template checklist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218265034
  
+1 to the PR title suggestion
The icla is NOT actually required for smaller changes, and we should only 
be enforcing this for large/deep changes.  (large,small,deep are all judgement 
calls I know)
The simple act of sending a pr does technically indicate that they are 
'giving' the code to us, so we only need to protect ourselves for the larger 
changes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218253991
  
Do we need to provide a link for CCLA info just in case? Can we also 
suggest a format for PR titles? Something like:
```
[CB-12345]: Short description
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[nikhilkh]

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/213

Add pull request template



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera pr-template

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #213


commit 25ddde2c6ca8f7fe1a9687acaed4019bb5b3dbdd
Author: Nikhil Khandelwal 
Date:   2016-05-10T18:35:48Z

Add pull request template




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org