[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user luofan189 commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158174054 I have added options to that JIRA issue, @riknoll --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158134364 @luofan189 I would also appreciate it if you could post the camera options you are passing to the plugin and the versions of iOS and the plugin you're using. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158133797 @luofan189 I'll try and reproduce this. If you don't mind, let's move this conversation to the JIRA issue: https://issues.apache.org/jira/browse/CB-5479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user luofan189 commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158132005 @riknoll only the low resolution image is saved on iOS device as well. I set the targetWidth and targetHeight to 1024x768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158127870 @luofan189 What issue are you seeing? I can take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user luofan189 commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158082173 Is this issue only fixed on Android side? I am seeing the same issue on iOS with the latest release as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-157475233 Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-157471037 @infil00p, if you have no objections, I'm going to merge this in. I don't think it'll break too many people and it fixes several quirks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user StopSine commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-157457257 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-156579930 I think this should also fix CB-6640 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-155970708 The commit I just pushed handles cropped images. I believe it also fixes an undocumented bug where requesting uncompressed/unedited images caused the app to ignore the crop Activity's output. That is, the user would get to crop the image and then the plugin would ignore that and just return the uncropped file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-155942860 Oh, [according to this](http://callback.markmail.org/search/?q=+saveToPhotoAlbum+list%3Aorg.apache.incubator.callback-dev#query:saveToPhotoAlbum%20list%3Aorg.apache.incubator.callback-dev%20date%3A201312%20+page:1+mid:v6gqvpfabvtja6lu+state:results) we should save the cropped image if `allowEdit` is on. I'll update the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-155940388 @infil00p This might be breaking (sorta). What is the protocol we usually follow for merging breaking changes in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/137 CB-5479 android: changed saveToPhotoAlbum to save uncompressed images It was apparently decided a while back (CB-5749) that we should be saving the uncompressed image with `saveToPhotoAlbum` rather than the modified image when the camera options `quality`, `targetHeight`, `targetWidth`, etc. are given. iOS supports this behavior, but Android does not. This pull request changes the Android code so that when `saveToPhotoAlbum` is specified, the uncompressed image is saved to the album and the modified image is saved to the application's cache (and that URI is what is returned to the application). This also makes it so that DATA_URL actually saves images to the gallery when the flag is enabled (this was previously not the case). This might be a breaking change for some applications that relied on the old behavior. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-5479 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit 19072169f880fcb1806b3d91c3987b7d43c8dd52 Author: riknoll Date: 2015-11-11T21:40:33Z CB-5479 android: changed saveToPhotoAlbum to save uncompressed images --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
