[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...
Github user maverickmishra closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/57 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r139333464 --- Diff: README.md --- @@ -27,6 +27,18 @@ description: Access accelerometer data. # cordova-plugin-device-motion +# Deprecation Notice + +With the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now +being supported on iOS, Android and Windows devices, this plugin is not needed any more. Migrating from this +plugin to the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) +is explained in this [PhoneGap blog post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed). --- End diff -- The plugins release blog post will talk about the deprecation. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r132629591 --- Diff: README.md --- @@ -27,6 +27,18 @@ description: Access accelerometer data. # cordova-plugin-device-motion +# Deprecation Notice + +With the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now +being supported on iOS, Android and Windows devices, this plugin is not needed any more. Migrating from this +plugin to the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) +is explained in this [PhoneGap blog post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed). --- End diff -- Why a Phonegap blogpost on a Cordova plugin deprecation? Shouldn't there at least be a Cordova "we deprecate those plugins" blog post linked here and then maybe additionally a Phonegap blogpost with "this is how you do it now" (although I would of course prefer those at Cordova as well, much less confusing for users re Cordova/Phonegap). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...
GitHub user maverickmishra opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/57 CB-13068: Updated README to point to transition blog post and show cu⦠### Platforms affected iOS, Android and Windows ### What does this PR do? This PR adds a deprecation notice and points to a transition blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/maverickmishra/cordova-plugin-device-motion master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit 69898c4f5d7094dcd5661f6b4f61610e1441d701 Author: maverickmishra Date: 2017-08-10T00:50:50Z CB-13068: Updated README to point to transition blog post and show current status --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
