[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/47#issuecomment-178261450 lgtm! If only we could get rid of all the @'s ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-plugin-device/pull/47 Refactored deviceInfo on iOS for better readability Hi, just a quick cleanup of dictionary creation on iOS. No functional changes, but I like to write those dictionaries like this these days. For readability mostly. Cheers, Eddy You can merge this pull request into a Git repository by running: $ git pull https://github.com/EddyVerbruggen/cordova-plugin-device iOS-deviceInfo-shorthand Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device/pull/47.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #47 commit 774a937f0f7338224aa385cce3db2404fc7daee0 Author: EddyVerbruggen Date: 2016-01-27T23:03:41Z Refactored deviceInfo on iOS for better readability. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
