[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-25 Thread sgrebnov
Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-96286278
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread gmbad
Github user gmbad commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94999385
  
Well, while the correction is not published, i did an upload via base64 
scheme for windows phone . If anyone is interested, contact me ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread stevengill
Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94991229
  
This didn't get reviewed for 1.0.0 release but will review it so it makes 
the next one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread gmbad
Github user gmbad commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94990412
  
dpolivy, 

maybe in new version 1.0.0 (Apr 15, 2015), its ok. No?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread dpolivy
Github user dpolivy commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94885204
  
@stevengill Is there someone who can review and merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-03-28 Thread gmbad
Github user gmbad commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-87226758
  
Hi dpolivy!

Tks for this bug fix.

I have this problem in my app on WP8.
Im using phonegap build.

Do you know when this bug fix will be available in phonegap plugins ?

Thank you,

Gabriel



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-03-26 Thread dpolivy
GitHub user dpolivy opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/73

CB-6313 [wp8]: Extra boundary in upload

When performing an upload on Windows Phone, an extra boundary is
included after any parameters, and before the file contents. This causes
some servers (such as express/multiparty on node.js) to fail to handle
the request properly.

This commit removes the extraneous boundary.

Fixes https://issues.apache.org/jira/browse/CB-6313

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpolivy/cordova-plugin-file-transfer CB6313

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit 237dd43b4d28c1a0e074bafedd404e6a7566cc7e
Author: Dan Polivy 
Date:   2015-03-27T06:13:12Z

CB-6313 [wp8]: Extra boundary in upload

When performing an upload on Windows Phone, an extra boundary is
included after any parameters, and before the file contents. This causes
some servers (such as express/multiparty on node.js) to fail to handle
the request properly.

This commit removes the extraneous boundary.

Fixes https://issues.apache.org/jira/browse/CB-6313




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org