[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-180444839 @Fuchur84, please file an issue on [our issue tracker](https://issues.apache.org/jira/browse/CB) so it could be seen by other devs, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...
Github user Fuchur84 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-180414183 There seems to be a problem with this on Windows 10 / Windows 10 Mobile... I get an error on line 502, column 33 in "(path)/transfer/src/windows/FileTransferProxy.js": "0x80070057 - JavaScript runtime error: Wrong parameter. count" The value given there is download.progress.bytesReceived (which seems to be 0 when it is called), but I am not sure what it does expect there and why 0 is not a valid value for the first iteration. Any idea what is happening there? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-73199798 Reviewed and tested - LGTM :ship: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63 CB-8407 Fix downloading of ms-appdata:/// urls on Windows JIRA issue [CB-8407](https://issues.apache.org/jira/browse/CB-8407) download() in file-transfer plugin expects path instead of internal URL on windows This bug seems to be introduced with these changes to cordova-plugin-file: https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f All tests for download method of file-transfer plugin now fail on windows with following message: ``` Exception calling native with command :: FileTransfer :: download ::exception=WinRTError: The parameter is incorrect. ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer CB-8407 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit 0394c0ce1eaf60f93ef1d529bc2fe1634d5d33da Author: Vladimir Kotikov Date: 2015-02-03T12:50:31Z CB-8407 Removes excess path to native path conversion in download method This fixes file transfer download tests failures, when target file is specified by ms-appdata:/// uri on Windows. commit 7a93626812522e473248c7629238da81d03fb805 Author: Vladimir Kotikov Date: 2015-02-03T14:06:14Z CB-8407 Use File proxy to construct valid FileEntry for download success callback Due to changes in file plugin (https://github.com/apache/cordova-plugin-file/commit/bcbeae24cd24583b790da95e0e076492eb16cd4f) result of download method should now have filesystemName specified for proper work. This updates download method to construct FileEntry properly, using File plugin proxy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
