[GitHub] cordova-plugin-file pull request: CB-7027 GetMetada fails on Windo...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7027 GetMetada fails on Windo...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/56#issuecomment-48501295 Hi purblecabbage, 1. @fberton is a member of the Touchify's, his name is Florian BERTON. He didn't send you the CLA, he will do it soon but he is registered to cordova developpement mailing list, he should introduce himself on it. 2. Indeed, the IDE has formatted the file including whitespaces, but you can see changes in the second commit. 3. Be careful, by mistake, Florian committed both CB-6994 (first commit, #54) and CB-7027 (second commit) in this branch. Do you want us to reformat the whole file in order to keep the spaces from the original ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7027 GetMetada fails on Windo...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/56#issuecomment-48518234 Thanks Maxime I just need to be able to resolve pull requests to a specific person / icla, so once that is received I can look at it more. I am however doing some major work in the windows8 file plugin currently, so there are already merge issues with this pull-req. I will revisit this after completing my work on CB-6969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7027 GetMetada fails on Windo...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/56#issuecomment-48406164 I would love to pull this in, but there are a couple issues. 1. Who is @fberton ? I have no way of linking you to a signed CLA because you have provided no information about yourself in your github profile. 2. There are numerous whitespace changes that make it really difficult to see what was actually changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7027 GetMetada fails on Windo...
GitHub user fberton opened a pull request: https://github.com/apache/cordova-plugin-file/pull/56 CB-7027 GetMetada fails on Windows8 GetMetadata in FileProxy.js returns the object basicProperties.dateModified in the case of a file and a folder. This function needs to return the primitive value of dateModified by using the function valueOf. Furthermore, it is interesting for a file in some cases to return also the primitive of basicProperties.size. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Touchit/cordova-plugin-file CB-7027 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit 823d2ff100757b21411e990633d084482bbca52e Author: Florian BERTON flor...@touchify.co Date: 2014-06-20T17:22:16Z Fix function write for big files on windows 8 commit b489022d423da0733396f876866f968b5e8ff44c Author: Florian BERTON flor...@touchify.co Date: 2014-06-25T16:20:59Z Fix issues in FileProxy.js CB-7027 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
