[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/88#issuecomment-63028689 Thank you very much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/88#issuecomment-62903413 Could someone please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/88#issuecomment-62903426 Could someone please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/88#discussion_r20315283 --- Diff: tests/tests.js --- @@ -1,4 +1,4 @@ -/* +/* --- End diff -- This line has a non-visible BOM (U+FEFF) -- can you strip that out (probably by saving as plain text, rather than UTF-8 with BOM) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...
Merged, and de-BOM'd @purplecabbage risingj.com On Thu, Nov 13, 2014 at 3:48 PM, asfgit g...@git.apache.org wrote: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...
GitHub user MariaBukharina opened a pull request: https://github.com/apache/cordova-plugin-file/pull/88 CB-7917 Fixed tests file.spec.114 - 116 pass for windows platform https://issues.apache.org/jira/browse/CB-7917 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-7917 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit 94029fb7a2409d28d399c65ad50afe0c97aba30a Author: maria.bukharina maria.bukhar...@akvelon.com Date: 2014-10-31T12:54:56Z CB-7917 Made tests file.spec.114 - 116 pass for windows platform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
