GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/21
Mark tests for unimplemented features as pending
For the getNumberPattern specs, the 'pattern' property isn't supported on
wp8, causing the relevant specs to fail and potentially obfuscate problems with
those properties which ARE implemented. I moved checks for this property into
separate specs, marked 'pending' for wp8 to indicate failure due to lack of
implementation.
getCurrencyPattern is not implemented at all, so marked the entire spec
pending for wp.
CB-6855, -6856, -6857, -6858
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-plugin-globalization fixtests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-globalization/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
commit 20e53666c68e96cdd10b8c87592af65c671c00e7
Author: Staci Cooper smcoo...@us.ibm.com
Date: 2014-07-29T19:33:02Z
CB-6855 Marked failing test as pending on wp8
pattern property not supported on WP8, so I removed the relevant checks
into a separate test which is marked pending for WP.
commit 0ed0cd7e27cafc818ad358a12599da36226e4b91
Author: Staci Cooper smcoo...@us.ibm.com
Date: 2014-07-29T19:38:56Z
CB-6856 Marked failing test as pending on wp8
Made a test which fails on wp mark as pending instead, as test fails due
to lack of implementation.
commit 616bfc4589fac125e270335832724a81c2df4be8
Author: Staci Cooper smcoo...@us.ibm.com
Date: 2014-07-29T19:51:43Z
CB-6857 Marked failing test as pending on wp8
spec.39 fails due to lack of implementation of one property. Moved
property into own test and mark pending for wp8
commit e8dd4c7e955e4297c7bd9cb366074a9fd83b9d7c
Author: Staci Cooper smcoo...@us.ibm.com
Date: 2014-07-29T19:54:15Z
CB-6858 getCurrencyPattern test pending for wp
getCurrencyPattern is unimplemented in wp, so marked test pending rather
than failing.
commit 18befa42b843a30868424acd2daded286528ebd1
Author: Staci Cooper smcoo...@us.ibm.com
Date: 2014-08-28T17:56:23Z
Merge branch 'master' of
https://git-wip-us.apache.org/repos/asf/cordova-plugin-globalization into
fixtests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
