[GitHub] cordova-plugin-inappbrowser issue #195: Cb 6229 - (Android) Hide Location bu...

2017-09-14 Thread sourcebits-jayaprakash
Github user sourcebits-jayaprakash commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/195
  
Would it possible for cordova Inappbrowser team to do code changes so that 
Done button on android devices in the next build? 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #195: Cb 6229 - (Android) Hide Location bu...

2017-04-06 Thread barryvdh
Github user barryvdh commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/195
  
Woud this make the default behavior the same as iOS, to show the close 
button with just 'location=no'?

(default ='location=yes') -> show location + close button
'location=no' -> show close button
'location=no&toolbar='no' => show nothing (current behavior with 
'location=no')
'location=yes&toolbar=no' => show only the address ? (Not sure if this one 
is useful)

Or would that be considered breaking and would need explicit 'toolbar=no'?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #195: Cb 6229 - (Android) Hide Location bu...

2017-02-02 Thread shankari
Github user shankari commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/195
  
is there an ETA on when this will be merged? There have been several 
requests for it (e.g. in 

http://stackoverflow.com/questions/15348871/how-can-i-get-the-cordova-inappbrowser-to-provide-a-way-for-the-user-to-close-th)
and it looks like it has passed all the checks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org