[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[cjpearson]

GitHub user cjpearson reopened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/94

CB-3360: Set custom inappbrowser user agent for ios

This uses the same OverrideUserAgent and AppendUserAgent properties as the 
pull requests for cordova-ios and cordova-android.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser 
ios-user-agent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #94


commit df2e82fb92be83e18dda5c9dd0a5604c58ff58d3
Author: Connor Pearson 
Date:   2015-03-13T17:52:30Z

CB-3360: Set custom inappbrowser user agent for ios




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[androdel]

Github user androdel commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-215651859
  
But where is the fix for iOS?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[cjpearson]

Github user cjpearson closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/94


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[Quelu]

Github user Quelu commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-211519224
  
My bad ! Thank you for the information !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[shazron]

Github user shazron commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-211515374
  
This has been merged already. A plugin release is pending: 
https://github.com/apache/cordova-plugin-inappbrowser/commit/98b63cc37e49466acc9b6b7f027c073fa5313e97

@cjpearson you can close this PR now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[Quelu]

Github user Quelu commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-211265699
  
Any chances to get this merged ? :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[Justin-Credible]

Github user Justin-Credible commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/95#issuecomment-159703588
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[Justin-Credible]

Github user Justin-Credible commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-159703609
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[jussihuotari]

Github user jussihuotari commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/95#issuecomment-145974033
  
:+1: 

In case someone else wonders: Cordova webview already handles user agent 
preferences but that doesn't apply when using InAppBrowser. 
https://github.com/apache/cordova-android/pull/162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[willmero]

Github user willmero commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-139222324
  
This is basically the last thing I need before I am able to push my iOS app 
version. I would love to see the status of what's happening here 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-113429801
  
Yeah, on iOS the user agent change applies to all the webviews, maybe it 
should be restored after closing the inappbrowser


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[samkelleher]

Github user samkelleher commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-66441
  
One side effect of this is that the main cordova webview will also have its 
userAgent changed (navigator.appVersion) once at least one instance of 
InAppBrowser has been created. It seems the userAgent setting will apply to all 
webviews.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[do-web]

Github user do-web commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/95#issuecomment-107042941
  
Readme update is missing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[rgo]

Github user rgo commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/95#issuecomment-104220589
  
:+1:  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[sinofool]

Github user sinofool commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-99256131
  
There is a minor difference with pull request in cordova-ios.
The original OverrideUserAgent will also ignore AppendUserAgent 
configuration.
If both configs provided, the behaviour will be different.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[LennardWesterveld]

Github user LennardWesterveld commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-98700835
  
:+1: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[LennardWesterveld]

Github user LennardWesterveld commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/95#issuecomment-98700863
  
:+1: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[staugaard]

Github user staugaard commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-97876288
  
Yeah I also need this. :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[staugaard]

Github user staugaard commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/95#issuecomment-97876456
  
Yeah I also need this. :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[cjpearson]

GitHub user cjpearson opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/95

CB-3360: Set custom inappbrowser user agent for android

This uses the same OverrideUserAgent and AppendUserAgent properties as the 
pull requests for cordova-ios and cordova-android.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser 
android-user-agent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #95


commit ebac47b5619163559faf1ce4eb61ebf75485ef6c
Author: Connor Pearson cjp...@gmail.com
Date:   2015-03-13T18:12:40Z

CB-3360: Set custom inappbrowser user agent for android




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

[cjpearson]

GitHub user cjpearson opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/94

CB-3360: Set custom inappbrowser user agent for ios

This uses the same OverrideUserAgent and AppendUserAgent properties as the 
pull requests for cordova-ios and cordova-android.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser 
ios-user-agent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #94


commit df2e82fb92be83e18dda5c9dd0a5604c58ff58d3
Author: Connor Pearson cjp...@gmail.com
Date:   2015-03-13T17:52:30Z

CB-3360: Set custom inappbrowser user agent for ios




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org