[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...
Github user jcesarmobile closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...
GitHub user jcesarmobile reopened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 CB-12586 (iOS) fix method hide doesn't work ### Platforms affected iOS ### What does this PR do? Fix hide method self.viewController wasn't presenting the inAppBrowser view controller anymore, so we can't use it to hide it, so changed to ask it's presentingViewController to dismiss it. ### What testing has been done on this change? Tested on real device ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-12586 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 88d128f258cf9c548eb47b122a05b2a391832293 Author: Julio César Date: 2017-07-23T16:03:06Z CB-12586 (iOS) fix method hide doesn't work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 CB-12586 (iOS) fix method hide doesn't work ### Platforms affected iOS ### What does this PR do? Fix hide method self.viewController wasn't presenting the inAppBrowser view controller anymore, so we can't use it to hide it, so changed to ask it's presentingViewController to dismiss it. ### What testing has been done on this change? Tested on real device ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-12586 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 88d128f258cf9c548eb47b122a05b2a391832293 Author: Julio César Date: 2017-07-23T16:03:06Z CB-12586 (iOS) fix method hide doesn't work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
