[GitHub] cordova-plugin-network-information pull request: Allowing to exten...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Allowing to exten...
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/26#issuecomment-85620698 I'd prefer not to open up the internals of the plugin, as that would increase the maintenance burden by broadening its API. It's not very big, so how about just copy / pasting it into your own plugin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Allowing to exten...
GitHub user ghonix opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/26 Allowing to extend NetworkManager and override the receiver and connecti... ...vity manager I have a special need that requires the plugin to be long lived across activities. By tying the receiver to one activity, it cause a intent filter leak. I would like to be able to extend the plugin and register the receiver on Initialize however I want. By having the fields private, this make it hard to achieve. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghonix/cordova-plugin-network-information master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit fd6aca74b6825c1c1b047ccc0885a9ec76212db5 Author: Amr Ghoneim Date: 2015-03-23T23:44:23Z Allowing to extend NetworkManager and override the receiver and connectivity manager --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org