[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-20 Thread jonathandelgado
Github user jonathandelgado commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46679052
  
+1 for bump


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-20 Thread clelland
Github user clelland commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46683835
  
If you want to use this right now, you can install from github directly:

cordova plugin add 
https://github.com/apache/cordova-plugin-network-information.git

You don't technically need to wait for an official release if you just want 
this bug fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-20 Thread jonathandelgado
Github user jonathandelgado commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46686865
  
@clelland Thanks for that! Forgot about that functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-18 Thread SantechDev
Github user SantechDev commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46432858
  
sorry to ask but as that modif been pushed to cordova plugin repo? I just 
did a 
```
cordova plugin add org.apache.cordova.network-information
```
and I can't see the change in ```src/android/NetworkManager.java```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-18 Thread clelland
Github user clelland commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46433863
  
No, it hasn't been pushed to the plugin repository. That will go out with 
the next plugin release. (Hopefully next week or the following, but I haven't 
heard of any plans to start that yet.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-18 Thread SantechDev
Github user SantechDev commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46433981
  
OK thanks, I'll keep an eye out


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-17 Thread ceetah
Github user ceetah commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46358048
  
newbie here. I stumbled upon this error too. and happily found your fix. 
but I do not know how I can add this fix to my application's plugin. how to 
update the plugin with this fix ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-17 Thread dozer47528
Github user dozer47528 commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46393109
  
@ceetah  ,@clelland has commited it 8 days ago. You can pull the the new 
code from `master`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-11 Thread clelland
Github user clelland commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-45822792
  
Hi Dozer,

I just found this as well -- I filed 
[CB-6907](https://issues.apache.org/jira/browse/CB-6907) and fixed it yesterday 
([diff](https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;a=blobdiff;f=src/android/NetworkManager.java;h=aa4e16120d48e834cf97f9b8422c5d2df8b35c49;hp=4c54b81c4f8413b88d0a884ddea044f2d65fae05;hb=a5e9631;hpb=f4ffab9c71c767d31c2e1157303ba98a40446a16))
 (with almost exactly your fix :) )

Feel free to close this PR (And thanks for letting us know!)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-11 Thread dozer47528
Github user dozer47528 commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-45824768
  
ok~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-11 Thread dozer47528
Github user dozer47528 closed the pull request at:

https://github.com/apache/cordova-plugin-network-information/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-09 Thread dozer47528
GitHub user dozer47528 opened a pull request:

https://github.com/apache/cordova-plugin-network-information/pull/10

fix NullPointerException

crash when the info is null!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dozer47528/cordova-plugin-network-information 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-network-information/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit 99b7676845530845c733eb79c728a86e05fc37bc
Author: Dozer m...@dozer.cc
Date:   2014-06-10T03:15:33Z

fix NullPointerException

crash when the info is null!




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---