[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-173872452 Tested and merged, thanks, @dpolivy! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-172130564 @daserge That PR looks reasonable to me. I might be able to work around this bug by setting `AutoHideSplashScreen` to `false` when it is supported on all of my platforms. However, the bug that I reported with this PR still exists -- if `AutoHideSplashScreen` is `true` and someone calls `show()` while it is visible, the behavior is unexpected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171906631 @dpolivy, yes you are right. Could you take a look at this implemented in #74 (based on #66)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171883205 @dpolivy, can we just use `` and `navigator.splashscreen.hide();` whenever the app is ready for achieving the same result? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171885860 @daserge Unfortunately I don't believe AutoHideSplashScreen is implemented for Android. However, even if it were, I'm not sure it would address this bug (it's been a while since I last worked on this, so I'll have to revisit the code to confirm). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171818850 @infil00p @stevengill Any possibility of getting a review on this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-119727865 @stevengill @infil00p Any possibility of reviewing this before the next release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49 CB-9094: Smarter autohide logic on Android When the plugin is initialized, the splash screen is shown with an auto-hide delay. If a subsequent call to show() comes in while the splashscreen is visible, it will still be automatically hidden, even though the user expectation is that it wouldn't be. This fix tracks the hideAfterDelay setting of the most recent call to show() -- and when the auto hide timer goes off, if the most recent call to show() did not set hideAfterDelay, then the splashscreen will not be automatically hidden. This provides a more consistent -- and expected -- behavior based on user action. Fixes https://issues.apache.org/jira/browse/CB-9094 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB9094 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit c9165dbea3939388e12f96f03ca47b5a7724140d Author: Dan Polivy d...@cellartracker.com Date: 2015-05-28T23:20:21Z CB-9094: Smarter autohide logic on Android When the plugin is initialized, the splash screen is shown with an auto-hide delay. If a subsequent call to show() comes in while the splashscreen is visible, it will still be automatically hidden, even though the user expectation is that it wouldn't be. This fix tracks the hideAfterDelay setting of the most recent call to show() -- and when the auto hide timer goes off, if the most recent call to show() did not set hideAfterDelay, then the splashscreen will not be automatically hidden. This provides a more consistent -- and expected -- behavior based on user action. https://issues.apache.org/jira/browse/CB-9094 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-106625709 @infil00p Would you be able to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
