[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugman/pull/83#issuecomment-99005935 You're right. I have opened a [new PR](https://github.com/apache/cordova-lib/pull/212) which should be better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-plugman/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-plugman/pull/83 CB-8757 - Resolve any symlinks in order to avoid relative path issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugman bektchiev/resolve-symlinks-in-paths Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugman/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit 46b968ddf4bc7feea869529c4c800b31631a5dac Author: Martin Bektchiev martin.bektch...@telerik.com Date: 2015-05-04T09:34:43Z CB-8757 - Resolve any symlinks in order to avoid relative path issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugman pull request: CB-8757 - Resolve any symlinks in or...
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/83#discussion_r29583217 --- Diff: main.js --- @@ -60,6 +61,9 @@ var cli_opts = nopt(known_opts, shortHands); var cmd = cli_opts.argv.remain.shift(); +cli_opts.project = convertToRealPathSafe(cli_opts.project); --- End diff -- Making them absolute here won't help when using cordova-lib via `cordova` or via `cordova-lib` directly. Could you look and see if you can resolve them outside of main.js? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
