[GitHub] cordova-windows pull request: Add support for back button on win10
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154657949 Agree and thx! - I made it this way to be consistent w/ other place where we do similar thing https://github.com/apache/cordova-windows/blob/master/cordova-js-src/platform.js#L74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154648176 I wouldn't personally make it look for the "MSAppHost/3.0" string, maybe doing a regex match on that to see if it's version 3.0 or higher might be better? ``` parseInt(navigator.appVersion.match(/MSAppHost\/([0-9]+)/)[1]) >= 3 ``` or something, just to futureproof it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154417511 PS. changing `appViewBackButtonVisibility ` on Mobile 10 does not take any effect, standard phone back button works as expected (correctly handled using `backrequested` event) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/120#issuecomment-154416603
@EionRobb could you please verify the following change:
```
parseInt(window.clientInformation.userAgent.match(/Windows NT
([0-9.]+)/)[1]) >= 10
->
navigator.appVersion.indexOf('MSAppHost/3.0') !== -1
```
to support Mobile 10 as well
https://github.com/apache/cordova-windows/commit/02a1ded1edb70d38f9259f8ab4543887514a19f8#diff-39f17a8caa1889e86840a9f4c1dd99b2R127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154017263 To clarify, the method defines itself as existing, but any attempts to use it will crash the container. There isn't a Jira issue for it, that would be unnecessary duplication. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154016649 Feature detection is broken. It causes the ieframe.dll to crash outside of js and is uncatchable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154014598 I plan to test and merge it. @EionRobb is there associated Jira issue available? Also, is there a special reason we use user agent instead of feature detection (`Windows.UI.Core.SystemNavigationManager.getForCurrentView`)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
GitHub user EionRobb opened a pull request: https://github.com/apache/cordova-windows/pull/120 Add support for back button on win10 Win10 has support for backbutton through the SystemNavigationManager API https://msdn.microsoft.com/en-us/library/windows/apps/windows.ui.core.systemnavigationmanager.aspx Unfortunately there's some OS-level crashes that happen when running the app if it has been compiled with VS2012/2013, but they get detected with the userAgent check that the OS fakes when it runs the app container, so this code only works when compiling on VS2015 (or newer, I guess) You can merge this pull request into a Git repository by running: $ git pull https://github.com/EionRobb/cordova-windows patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #120 commit ceef4460148e53df476110becdfdb5d83fd9bea5 Author: Eion Robb Date: 2015-09-07T05:01:53Z Add support for back button on win10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
