[GitHub] cordova-windows pull request: CB-8400 enable jshint for windows pl...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8400 enable jshint for windows pl...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/57#issuecomment-73478942 @muratsu Merged in 8e7ad53191ebf34c7faec9ed1a3e4c0634372e2d and 232968c062cf73ae7482f13cc3b6584d72933498 . Could you please close this PR manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8400 enable jshint for windows pl...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/57#issuecomment-72660381 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8400 enable jshint for windows pl...
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-windows/pull/57 CB-8400 enable jshint for windows platform - Created a `npm run jshint` command & integrate into `npm run test` - Created jshint rules files for spec and rest of the repo - Added node_module jshint to repo - Fixed all jshint issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-8400 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit 2aeb819235e0eac606335c8c7b0b0ffd5df39c0d Author: Murat Sutunc Date: 2015-02-02T19:57:03Z CB-8400 Enable jshint for Windows platform commit da48fd9651a2a04e4a7aee0d774fbf780aa302b9 Author: Murat Sutunc Date: 2015-02-02T22:55:58Z CB-8400 fix all jshint issues for Windows platform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org