[GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/219#discussion_r93464493
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -304,6 +309,47 @@ describe('windows project handler', function () {
xpath = 'Reference[@Include="dummy6"]/HintPath';
validateInstalledProjects('framework', frameworks[5],
xpath, ['windows', 'windows10', 'phone']);
});
+
+it('with .winmd and .dll files', function() {
--- End diff --
Does this spec check that dll files have been actually copied? ([according
to
this](https://github.com/apache/cordova-windows/pull/219/files#diff-7bcd02ec7f03ffbb25512bd1f4a0d388R99))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/219#discussion_r93460566
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -115,6 +115,33 @@ function PluginInfo(dirname) {
var configFiles = parentGetConfigFiles(platform);
return processChanges(configFiles);
};
+
+this.getFrameworks = function(platform) {
--- End diff --
nit: [outdated
comment](https://github.com/apache/cordova-windows/pull/219/files#diff-93a26ea6e269125a5b151c4176a3b42bL100)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
