Re: [VOTE] Cordova-Android 10.0.0 Release

2021-07-19 Thread Niklas Merz
Thanks Bryan for your hard work on this release and getting it out
before the deadline. 

On July 20, 2021, Erisu  wrote:
> The vote has now closed. The results are:
>
> Positive Binding Votes: 4
>
> * Bryan Ellis
> * Niklas Merz
> * Pieter van Poyer
> * Ken Naito
>
> Negative Binding Votes: 0
>
> The vote has passed.
>
> Thanks everyone!
>
>
> > On Jul 19, 2021, at 9:09 PM, pieter van poyer
>  wrote:
> > 
> > I vote +1
> > 
> > Changes look good.
> > I am unable to do any further testing right now.
> > 
> > Kind regards
> > Pieter
> > 
> > Op za 17 jul. 2021 10:42 schreef Niklas Merz :
> > 
> >> I vote +1
> >> 
> >> I did:
> >> 
> >> * checked signature
> >> * checked hash
> >> * checked license
> >> * checked git tag
> >> * tests pass locally
> >> * ci green
> >> * no lint issues
> >> * short test with new and existing app
> >> 
> >> On July 17, 2021, Erisu  wrote:
> >>> Please review and vote on this Android Release v10.0.0
> >>> by replying to this email (and keep discussion on the DISCUSS
> thread)
> >>> 
> >>> The archive has been published to dist/dev:
> >>> https://dist.apache.org/repos/dist/dev/cordova/android-v10.0.0/
> >>> 
> >>> The package was published from its corresponding git tag:
> >>> cordova-android: 10.0.0 (7572fc4912)
> >>> 
> >>> Note that you can test it out via:
> >>> 
> >>> cordova platform add https://github.com/apache/cordova-
> android#10.0.0
> >>> 
> >>> Upon a successful vote I will upload the archive to dist/, publish
> it
> >>> to npm, and post the blog post.
> >>> 
> >>> Voting guidelines: https://github.com/apache/cordova-
> >>> coho/blob/master/docs/release-voting.md
> >>> 
> >>> Voting will go on for a minimum of 48 hours.
> >>> 
> >>> I vote +1:
> >>> * Ran coho audit-license-headers over the relevant repos
> >>> * Ran coho check-license to ensure all dependencies and
> >>> subdependencies have Apache-compatible licenses
> >>> * Ensured continuous build was green when repo was tagged
> >>> * NPM Audit
> >>> * NPM Test (Executed Individual Steps in Order)
> >>> * npm run lint
> >>> * npm run unit-test
> >>> * npm run e2e-tests
> >>> * npm run java-unit-tests
> >>> * Ran `cordova build` test
> >>> * Ran `cordova run` emulator test
> >>> * Ran `cordova plugin add` test
> >>>
> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >>> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>


Re: [VOTE] Cordova-Android 10.0.0 Release

2021-07-19 Thread Bryan Ellis
The vote has now closed. The results are:

Positive Binding Votes: 4

* Bryan Ellis
* Niklas Merz
* Pieter van Poyer
* Ken Naito

Negative Binding Votes: 0

The vote has passed.

Thanks everyone!


> On Jul 19, 2021, at 9:09 PM, pieter van poyer  
> wrote:
> 
> I vote +1
> 
> Changes look good.
> I am unable to do any further testing right now.
> 
> Kind regards
> Pieter
> 
> Op za 17 jul. 2021 10:42 schreef Niklas Merz :
> 
>> I vote +1
>> 
>> I did:
>> 
>> * checked signature
>> * checked hash
>> * checked license
>> * checked git tag
>> * tests pass locally
>> * ci green
>> * no lint issues
>> * short test with new and existing app
>> 
>> On July 17, 2021, Erisu  wrote:
>>> Please review and vote on this Android Release v10.0.0
>>> by replying to this email (and keep discussion on the DISCUSS thread)
>>> 
>>> The archive has been published to dist/dev:
>>> https://dist.apache.org/repos/dist/dev/cordova/android-v10.0.0/
>>> 
>>> The package was published from its corresponding git tag:
>>> cordova-android: 10.0.0 (7572fc4912)
>>> 
>>> Note that you can test it out via:
>>> 
>>> cordova platform add https://github.com/apache/cordova-android#10.0.0
>>> 
>>> Upon a successful vote I will upload the archive to dist/, publish it
>>> to npm, and post the blog post.
>>> 
>>> Voting guidelines: https://github.com/apache/cordova-
>>> coho/blob/master/docs/release-voting.md
>>> 
>>> Voting will go on for a minimum of 48 hours.
>>> 
>>> I vote +1:
>>> * Ran coho audit-license-headers over the relevant repos
>>> * Ran coho check-license to ensure all dependencies and
>>> subdependencies have Apache-compatible licenses
>>> * Ensured continuous build was green when repo was tagged
>>> * NPM Audit
>>> * NPM Test (Executed Individual Steps in Order)
>>> * npm run lint
>>> * npm run unit-test
>>> * npm run e2e-tests
>>> * npm run java-unit-tests
>>> * Ran `cordova build` test
>>> * Ran `cordova run` emulator test
>>> * Ran `cordova plugin add` test
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 



Re: [VOTE] Cordova-Android 10.0.0 Release

2021-07-19 Thread Ken Naito

+1

I did:
* coho verify-archive OK
* coho verify-tags OK
* The last commit 
https://github.com/apache/cordova-android/tree/7572fc4912c908adb9b0498959c0eadecbbc9f95 
is green


Thanks!



On 2021/07/17 16:41, Bryan Ellis wrote:

Please review and vote on this Android Release v10.0.0
by replying to this email (and keep discussion on the DISCUSS thread)

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/android-v10.0.0/

The package was published from its corresponding git tag:
 cordova-android: 10.0.0 (7572fc4912)

Note that you can test it out via:

 cordova platform add https://github.com/apache/cordova-android#10.0.0

Upon a successful vote I will upload the archive to dist/, publish it to npm, 
and post the blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Test (Executed Individual Steps in Order)
   * npm run lint
   * npm run unit-test
   * npm run e2e-tests
   * npm run java-unit-tests
* Ran `cordova build` test
* Ran `cordova run` emulator test
* Ran `cordova plugin add` test
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] Cordova-Android 10.0.0 Release

2021-07-19 Thread pieter van poyer
I vote +1

Changes look good.
I am unable to do any further testing right now.

Kind regards
Pieter

Op za 17 jul. 2021 10:42 schreef Niklas Merz :

> I vote +1
>
> I did:
>
> * checked signature
> * checked hash
> * checked license
> * checked git tag
> * tests pass locally
> * ci green
> * no lint issues
> * short test with new and existing app
>
> On July 17, 2021, Erisu  wrote:
> > Please review and vote on this Android Release v10.0.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/android-v10.0.0/
> >
> > The package was published from its corresponding git tag:
> >  cordova-android: 10.0.0 (7572fc4912)
> >
> > Note that you can test it out via:
> >
> >  cordova platform add https://github.com/apache/cordova-android#10.0.0
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines: https://github.com/apache/cordova-
> > coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Test (Executed Individual Steps in Order)
> >  * npm run lint
> >  * npm run unit-test
> >  * npm run e2e-tests
> >  * npm run java-unit-tests
> > * Ran `cordova build` test
> > * Ran `cordova run` emulator test
> > * Ran `cordova plugin add` test
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
>


Re: [VOTE] Cordova-Android 10.0.0 Release

2021-07-17 Thread Niklas Merz
I vote +1

I did:

* checked signature
* checked hash
* checked license
* checked git tag
* tests pass locally
* ci green
* no lint issues
* short test with new and existing app

On July 17, 2021, Erisu  wrote:
> Please review and vote on this Android Release v10.0.0
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/android-v10.0.0/
>
> The package was published from its corresponding git tag:
>  cordova-android: 10.0.0 (7572fc4912)
>
> Note that you can test it out via:
>
>  cordova platform add https://github.com/apache/cordova-android#10.0.0
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post.
>
> Voting guidelines: https://github.com/apache/cordova-
> coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Test (Executed Individual Steps in Order)
>  * npm run lint
>  * npm run unit-test
>  * npm run e2e-tests
>  * npm run java-unit-tests
> * Ran `cordova build` test
> * Ran `cordova run` emulator test
> * Ran `cordova plugin add` test
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org


[VOTE] Cordova-Android 10.0.0 Release

2021-07-17 Thread Bryan Ellis
Please review and vote on this Android Release v10.0.0
by replying to this email (and keep discussion on the DISCUSS thread)

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/android-v10.0.0/

The package was published from its corresponding git tag:
cordova-android: 10.0.0 (7572fc4912)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-android#10.0.0

Upon a successful vote I will upload the archive to dist/, publish it to npm, 
and post the blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Test (Executed Individual Steps in Order)
  * npm run lint
  * npm run unit-test
  * npm run e2e-tests
  * npm run java-unit-tests
* Ran `cordova build` test
* Ran `cordova run` emulator test
* Ran `cordova plugin add` test
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org