Re: [cordova-android] Commit related to CB-8317 brings issue reported in CB-7371
The initial problem was the whitelist letting pass something like 'about:blank' to be loaded into the view, when all network access was allowed(access=*), currently that problems is not present. Although, the the recreation triggers always a destruction, and during that event, loadUrlNow method triggers the load to the super class, if passes the conditions(AndroidWebView.java 375 line - cordova-android master). With commit ccceaeaca, that condition passes, loads the about:blank in the view and the app exits. Stack trace about the process can be found in the issue itself: https://issues.apache.org/jira/browse/CB-7371 2015-02-04 19:08 GMT-06:00 Andrew Grieve agri...@chromium.org: Hmm, just had a look at the bug and it's not obvious to me what the problem is? Is there a stack trace for the crash? Is there a known fix for it that doesn't involve not sending the exit event? On Fri, Jan 23, 2015 at 7:24 PM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Right, an automation test would avoid future breaks, it can be done by recreating those steps or verifying that an url such as about:blank doesn't get loaded or go through the conditions in line 457 of cordovawebview class. I can get some test for it, sure thing. On 23 Jan 2015 6:08 PM, Joe Bowser bows...@gmail.com wrote: OK, now how do you automate that? I don't think anyone is going to remember to do this to test for regressions. On Fri Jan 23 2015 at 4:06:07 PM Martin Gonzalez martin.c.glez.g...@gmail.com wrote: It's pretty easy, create a project, add platform android taken from master branch, run it, then once the app is launched, minimize it, go to settings, select another language, and then resume the app, by using the home button. You'll see the crash at that point. On 23 Jan 2015 5:42 PM, Joe Bowser bows...@gmail.com wrote: I re-opened the initial issue. Is it possible to test this? On Fri Jan 23 2015 at 3:24:54 PM Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Hello team, Recently tested cordova-android, master branch, and I found out that this commit: ccceaeaca Link: https://git-wip-us.apache.org/repos/asf?p=cordova-android.gi t;a=commit;h= ccceaeaca2d72fb9708100ab2f70adb903a27d66 brings back the issue about app crash after language is changed, by allowing to load an url with 'about:blank' value, triggered by the app recreation on during onResume/OnDestroy events. See https://issues.apache.org/jira/browse/CB-7371 for more details about that crash. Tested on LG G2, Android 4.4.2 -- Regards, Martin Gonzalez -- Regards, Martin Gonzalez
Re: [cordova-android] Commit related to CB-8317 brings issue reported in CB-7371
Hmm, just had a look at the bug and it's not obvious to me what the problem is? Is there a stack trace for the crash? Is there a known fix for it that doesn't involve not sending the exit event? On Fri, Jan 23, 2015 at 7:24 PM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Right, an automation test would avoid future breaks, it can be done by recreating those steps or verifying that an url such as about:blank doesn't get loaded or go through the conditions in line 457 of cordovawebview class. I can get some test for it, sure thing. On 23 Jan 2015 6:08 PM, Joe Bowser bows...@gmail.com wrote: OK, now how do you automate that? I don't think anyone is going to remember to do this to test for regressions. On Fri Jan 23 2015 at 4:06:07 PM Martin Gonzalez martin.c.glez.g...@gmail.com wrote: It's pretty easy, create a project, add platform android taken from master branch, run it, then once the app is launched, minimize it, go to settings, select another language, and then resume the app, by using the home button. You'll see the crash at that point. On 23 Jan 2015 5:42 PM, Joe Bowser bows...@gmail.com wrote: I re-opened the initial issue. Is it possible to test this? On Fri Jan 23 2015 at 3:24:54 PM Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Hello team, Recently tested cordova-android, master branch, and I found out that this commit: ccceaeaca Link: https://git-wip-us.apache.org/repos/asf?p=cordova-android.gi t;a=commit;h= ccceaeaca2d72fb9708100ab2f70adb903a27d66 brings back the issue about app crash after language is changed, by allowing to load an url with 'about:blank' value, triggered by the app recreation on during onResume/OnDestroy events. See https://issues.apache.org/jira/browse/CB-7371 for more details about that crash. Tested on LG G2, Android 4.4.2 -- Regards, Martin Gonzalez
[cordova-android] Commit related to CB-8317 brings issue reported in CB-7371
Hello team, Recently tested cordova-android, master branch, and I found out that this commit: ccceaeaca Link: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=ccceaeaca2d72fb9708100ab2f70adb903a27d66 brings back the issue about app crash after language is changed, by allowing to load an url with 'about:blank' value, triggered by the app recreation on during onResume/OnDestroy events. See https://issues.apache.org/jira/browse/CB-7371 for more details about that crash. Tested on LG G2, Android 4.4.2 -- Regards, Martin Gonzalez
