[jira] [Commented] (CB-604) doesn't work in strict mode
[ https://issues.apache.org/jira/browse/CB-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551895#comment-13551895 ] Mihai Paun commented on CB-604: --- @Colin, to answer your question from the weinre Google Group thread which I only received a couple of hours ago (and it shows up as deleted there), I got it working in a twbootstrap + requirejs environment but I honestly don't remember how I did it right now and sadly the source code is on the intranet at my company so I will have access to it only on Monday. Will post here if I remember and sorry that I cannot be of much help right now. > doesn't work in strict mode > --- > > Key: CB-604 > URL: https://issues.apache.org/jira/browse/CB-604 > Project: Apache Cordova > Issue Type: Bug > Components: weinre > Environment: ubuntu/windows >Reporter: hongbo lu >Assignee: Patrick Mueller > > weinre doesn't work in strict mode ,because it trys to access "func.caller" > which isn't allowed in strict mode -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-604) doesn't work in strict mode
[ https://issues.apache.org/jira/browse/CB-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549080#comment-13549080 ] Patrick Mueller commented on CB-604: Looks like, previously, bootstrap was built with "use strict" stripped out - https://github.com/twitter/bootstrap/issues/1655 - so you might want to open a new bug. Other than that, see previous comments regarding the work that I think needs to be done, or places to start looking anyway. Pull requests welcomed. > doesn't work in strict mode > --- > > Key: CB-604 > URL: https://issues.apache.org/jira/browse/CB-604 > Project: Apache Cordova > Issue Type: Bug > Components: weinre > Environment: ubuntu/windows >Reporter: hongbo lu >Assignee: Patrick Mueller > > weinre doesn't work in strict mode ,because it trys to access "func.caller" > which isn't allowed in strict mode -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-604) doesn't work in strict mode
[ https://issues.apache.org/jira/browse/CB-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549045#comment-13549045 ] colin mcdonald commented on CB-604: --- This is affecting my use of weinre because I'm using twitter bootstrap which uses strict mode. Any workarounds or anyway I can try to help? All links to weinre are 404 I'm assuming because of it's transition to ASF. Thanks, Colin > doesn't work in strict mode > --- > > Key: CB-604 > URL: https://issues.apache.org/jira/browse/CB-604 > Project: Apache Cordova > Issue Type: Bug > Components: weinre > Environment: ubuntu/windows >Reporter: hongbo lu >Assignee: Patrick Mueller > > weinre doesn't work in strict mode ,because it trys to access "func.caller" > which isn't allowed in strict mode -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-604) doesn't work in strict mode
[ https://issues.apache.org/jira/browse/CB-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487938#comment-13487938 ] Patrick Mueller commented on CB-604: Due to the potentially large # of changes to make, I've not made any changes at present. However, I have added a test case, so someone can start playing with this a bit more, if they want. See the commit: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-weinre.git;a=commit;h=588b2e90ca1e3c56599f587a1f71911f99877dfc Note, this commit has been main-lined into master, but I'm not doing a new build since there's no new function. To make use of this commit, you'll need to be set up to do weinre development. > doesn't work in strict mode > --- > > Key: CB-604 > URL: https://issues.apache.org/jira/browse/CB-604 > Project: Apache Cordova > Issue Type: Bug > Components: weinre > Environment: ubuntu/windows >Reporter: hongbo lu >Assignee: Patrick Mueller > > weinre doesn't work in strict mode ,because it trys to access "func.caller" > which isn't allowed in strict mode -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-604) doesn't work in strict mode
[
https://issues.apache.org/jira/browse/CB-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487928#comment-13487928
]
Patrick Mueller commented on CB-604:
Did a quick check to see where in weinre we're using arguments, .callee and
.caller.
Do a
{noformat}
cd [path-to-weinre-source]/weinre.web
{noformat}
Then run
{noformat}
grep -r "\(arguments\)\|\(\.callee\)\|\(\.caller\)" . | grep \.coffee
{noformat}
Here is a list of the affected files:
* modules/weinre/client/Client.coffee
* modules/weinre/client/DOMTemplates.coffee
* modules/weinre/client/InspectorBackendImpl.coffee
* modules/weinre/client/InspectorFrontendHostImpl.coffee
* modules/weinre/common/Binding.coffee
* modules/weinre/common/Callback.coffee
* modules/weinre/common/EventListeners.coffee
* modules/weinre/common/Ex.coffee
* modules/weinre/common/HookLib.coffee
* modules/weinre/common/IDLTools.coffee
* modules/weinre/common/MessageDispatcher.coffee
* modules/weinre/common/StackTrace.coffee
* modules/weinre/common/WebSocketXhr.coffee
* modules/weinre/common/Weinre.coffee
* modules/weinre/target/Console.coffee
* modules/weinre/target/SqlStepper.coffee
* modules/weinre/target/Target.coffee
* modules/weinre/target/Timeline.coffee
* modules/weinre/target/WiCSSImpl.coffee
* modules/weinre/target/WiDOMImpl.coffee
* modules/weinre/target/WiDOMStorageImpl.coffee
* modules/weinre/target/WiInspectorImpl.coffee
Note, this is just the weinre source, and likely only the common and target
files are implicated. But there is also some injected code from Web Inspector
itself, and it showed up in a different scan I did.
Bummer.
> doesn't work in strict mode
> ---
>
> Key: CB-604
> URL: https://issues.apache.org/jira/browse/CB-604
> Project: Apache Cordova
> Issue Type: Bug
> Components: weinre
> Environment: ubuntu/windows
>Reporter: hongbo lu
>Assignee: Patrick Mueller
>
> weinre doesn't work in strict mode ,because it trys to access "func.caller"
> which isn't allowed in strict mode
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-604) doesn't work in strict mode
[ https://issues.apache.org/jira/browse/CB-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486031#comment-13486031 ] Peter Paul Elfferich commented on CB-604: - Thanks Walter and Jay! Patched my target-script-min.js with the try-catch workaround and have been able to use Weinre again ever since (though I'm sure some things will not be fully functional anymore). > doesn't work in strict mode > --- > > Key: CB-604 > URL: https://issues.apache.org/jira/browse/CB-604 > Project: Apache Cordova > Issue Type: Bug > Components: weinre > Environment: ubuntu/windows >Reporter: hongbo lu >Assignee: Patrick Mueller > > weinre doesn't work in strict mode ,because it trys to access "func.caller" > which isn't allowed in strict mode -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
