Re: Introduction and Possible Contribution
Thanks, Andrew. They looked distinct to me so I went ahead and sent the pull request. The comment should read something like "Allows for one set of iPad launch images for iOS 7+ and another for pre-iOS 7." -Terence On 3/17/2014 10:53 PM, Andrew Grieve wrote: Hi Terence! Sounds like a smart improvement. Would definitely welcome a patch for this. :) Found there's a similar sounding pull request here: https://github.com/apache/cordova-plugin-splashscreen/pull/13. Not sure how much they overlap. Andrew On Fri, Mar 14, 2014 at 5:29 PM, Terence M. Bandoian wrote: First, thanks for all the great work. I'm fairly new to Cordova but have quite a bit of experience otherwise and have so far found it to be an excellent framework for mobile app development. In a recent iPad project, I added a section of code to the updateImage method of the splash screen plugin that uses the UILaunchImages array in the main bundle to support different sized launch images for iOS 7. UILaunchImages is automatically generated by Xcode according to the images selected in the Launch Images section of the General settings. If it would be useful, I would be happy to submit a pull request and contribute the modification to the project. My ICLA is on file with ASF. Thanks again. -Terence Bandoian
Re: Introduction and Possible Contribution
Hi Terence! Sounds like a smart improvement. Would definitely welcome a patch for this. :) Found there's a similar sounding pull request here: https://github.com/apache/cordova-plugin-splashscreen/pull/13. Not sure how much they overlap. Andrew On Fri, Mar 14, 2014 at 5:29 PM, Terence M. Bandoian wrote: > First, thanks for all the great work. I'm fairly new to Cordova but have > quite a bit of experience otherwise and have so far found it to be an > excellent framework for mobile app development. > > In a recent iPad project, I added a section of code to the updateImage > method of the splash screen plugin that uses the UILaunchImages array in > the main bundle to support different sized launch images for iOS 7. > UILaunchImages is automatically generated by Xcode according to the images > selected in the Launch Images section of the General settings. If it would > be useful, I would be happy to submit a pull request and contribute the > modification to the project. My ICLA is on file with ASF. > > Thanks again. > > -Terence Bandoian > >
Introduction and Possible Contribution
First, thanks for all the great work. I'm fairly new to Cordova but have quite a bit of experience otherwise and have so far found it to be an excellent framework for mobile app development. In a recent iPad project, I added a section of code to the updateImage method of the splash screen plugin that uses the UILaunchImages array in the main bundle to support different sized launch images for iOS 7. UILaunchImages is automatically generated by Xcode according to the images selected in the Launch Images section of the General settings. If it would be useful, I would be happy to submit a pull request and contribute the modification to the project. My ICLA is on file with ASF. Thanks again. -Terence Bandoian
