Re: Following our Review-Then-Commit process

[Joan Touzet]

 
> On 04/03/2017 05:17 PM, Joan Touzet wrote:
> > All,
> >
> > I wanted to express a concern with my CouchDB PMC hat on.
> >
> > There is some great work being merged by Cloudant here. But I'm not
> > seeing the Review-Then-Commit pattern being followed in a
> > significant
> > number of these PRs coming through to any of our repos.
> >
> > Take as an example this one, which is one of 4 related PRs to merge
> > replicator scheduling work. None of these 4 PRs shows an
> > independent +1
> > posted to the comment thread, or even a token +1 by a fellow
> > Cloudant
> > committer.
> 
> A branch was deleted because because monorepo work made it invalid.
> 
> Nothing was merged. I think it might be confusing seeing the PR
> auto-close after branch delete and assuming it was because of a
> merge...?
> 
> This is still WIP. There will be new PR and a mailing list
> announcement
> soon.

Thanks Nick, I appreciate it, though there have been other merged
branches in the last couple of months that didn't have visible +1s
on them.

My comments on documentation and testing still stand.

-Joan

Re: Following our Review-Then-Commit process

[Nick Vatamaniuc]

On 04/03/2017 05:17 PM, Joan Touzet wrote:

All,

I wanted to express a concern with my CouchDB PMC hat on.

There is some great work being merged by Cloudant here. But I'm not
seeing the Review-Then-Commit pattern being followed in a significant
number of these PRs coming through to any of our repos.

Take as an example this one, which is one of 4 related PRs to merge
replicator scheduling work. None of these 4 PRs shows an independent +1
posted to the comment thread, or even a token +1 by a fellow Cloudant
committer.


A branch was deleted because because monorepo work made it invalid.

Nothing was merged. I think it might be confusing seeing the PR 
auto-close after branch delete and assuming it was because of a merge...?


This is still WIP. There will be new PR and a mailing list announcement 
soon.


-Nick

Re: Commits to the wrong list?

[Joan Touzet]

Hooray! This has been fixed thanks to ASF Infra.

Sorry for all the mailing list noise, everyone.

If you want those notifications, please subscribe to

  notificati...@couchdb.apache.org

A link to sign you up is right on our home page at

  https://couchdb.apache.org/

-Joan

- Original Message -
> From: "Joan Touzet" 
> To: dev@couchdb.apache.org
> Sent: Monday, April 3, 2017 6:21:04 PM
> Subject: Re: Commits to the wrong list?
> 
> Whoops, wrong link:
> 
> https://issues.apache.org/jira/browse/INFRA-13809
> 
> -Joan
> 
> - Original Message -
> > From: "Joan Touzet" 
> > To: dev@couchdb.apache.org
> > Sent: Monday, April 3, 2017 6:20:19 PM
> > Subject: Re: Commits to the wrong list?
> > 
> > Hi Jan, I didn't see an INFRA ticket on this so I've filed a new
> > one:
> > 
> > https://issues.apache.org/jira/browse/INFRA-13754
> > 
> > -Joan
> > 
> > - Original Message -
> > > From: "Jan Lehnardt" 
> > > To: dev@couchdb.apache.org
> > > Sent: Friday, March 17, 2017 9:53:37 AM
> > > Subject: Re: Commits to the wrong list?
> > > 
> > > Oh, I was told this was fixed already.
> > > 
> > > I’m on it.
> > > 
> > > Best
> > > Jan
> > > --
> > > > On 17 Mar 2017, at 14:45, Filippo Fadda
> > > >  wrote:
> > > > 
> > > > Hi Jan,
> > > > 
> > > > it has been a week now, isn’t possible to change the e-mail on
> > > > GitHub from dev@couchdb.apache.org
> > > > 
> > > > to comm...@couchdb.apache.org
> > > > ?
> > > > Otherwise I guess I will be forced to abandon the list.
> > > > 
> > > > Cordially
> > > > 
> > > > -Filippo
> > > > 
> > > >> On 9 Mar 2017, at 15:08, Jan Lehnardt  wrote:
> > > >> 
> > > >> Hi Filippo,
> > > >> 
> > > >> we’ve changed our git integration yesterday and it looks like
> > > >> the
> > > >> email settings got reset. I’m following up with ASF infra to
> > > >> sort
> > > >> this out. Sorry for the inconvenience.
> > > >> 
> > > >> Best
> > > >> Jan
> > > >> --
> > > >> PS: We’re not all guys here.
> > > >>> On 9 Mar 2017, at 15:41, Filippo Fadda
> > > >>>  wrote:
> > > >>> 
> > > >>> Hi guys,
> > > >>> 
> > > >>> since yesterday I’m receiving a ton of e-mails from GitHub.
> > > >>> Perhaps I should receive these e-emails because I have
> > > >>> subscribed to comm...@couchdb.apache.org
> > > >>> , but I have not.
> > > >>> 
> > > >>> Cheers
> > > >>> 
> > > >>> -Filippo
> > > >> 
> > > >> --
> > > >> Professional Support for Apache CouchDB:
> > > >> https://neighbourhood.ie/couchdb-support/
> > > >> 
> > > > 
> > > 
> > > --
> > > Professional Support for Apache CouchDB:
> > > https://neighbourhood.ie/couchdb-support/
> > > 
> > >
> >
> 

[GitHub] couchdb issue #467: Test issue

[Humbedooh]

Github user Humbedooh commented on the issue:

https://github.com/apache/couchdb/issues/467
  
and this should bork to infra also :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb issue #463: Add Travis and Jenkins build status images to README

[wohali]

Github user wohali commented on the issue:

https://github.com/apache/couchdb/pull/463
  
Bump. Can anyone take a look at this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb issue #467: Test issue

[wohali]

GitHub user wohali opened an issue:

https://github.com/apache/couchdb/issues/467

Test issue

This is a test issue to validate the mailing list is set up correctly.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Commits to the wrong list?

[Joan Touzet]

Whoops, wrong link:

https://issues.apache.org/jira/browse/INFRA-13809

-Joan

- Original Message -
> From: "Joan Touzet" 
> To: dev@couchdb.apache.org
> Sent: Monday, April 3, 2017 6:20:19 PM
> Subject: Re: Commits to the wrong list?
> 
> Hi Jan, I didn't see an INFRA ticket on this so I've filed a new one:
> 
> https://issues.apache.org/jira/browse/INFRA-13754
> 
> -Joan
> 
> - Original Message -
> > From: "Jan Lehnardt" 
> > To: dev@couchdb.apache.org
> > Sent: Friday, March 17, 2017 9:53:37 AM
> > Subject: Re: Commits to the wrong list?
> > 
> > Oh, I was told this was fixed already.
> > 
> > I’m on it.
> > 
> > Best
> > Jan
> > --
> > > On 17 Mar 2017, at 14:45, Filippo Fadda
> > >  wrote:
> > > 
> > > Hi Jan,
> > > 
> > > it has been a week now, isn’t possible to change the e-mail on
> > > GitHub from dev@couchdb.apache.org
> > > 
> > > to comm...@couchdb.apache.org
> > > ?
> > > Otherwise I guess I will be forced to abandon the list.
> > > 
> > > Cordially
> > > 
> > > -Filippo
> > > 
> > >> On 9 Mar 2017, at 15:08, Jan Lehnardt  wrote:
> > >> 
> > >> Hi Filippo,
> > >> 
> > >> we’ve changed our git integration yesterday and it looks like
> > >> the
> > >> email settings got reset. I’m following up with ASF infra to
> > >> sort
> > >> this out. Sorry for the inconvenience.
> > >> 
> > >> Best
> > >> Jan
> > >> --
> > >> PS: We’re not all guys here.
> > >>> On 9 Mar 2017, at 15:41, Filippo Fadda
> > >>>  wrote:
> > >>> 
> > >>> Hi guys,
> > >>> 
> > >>> since yesterday I’m receiving a ton of e-mails from GitHub.
> > >>> Perhaps I should receive these e-emails because I have
> > >>> subscribed to comm...@couchdb.apache.org
> > >>> , but I have not.
> > >>> 
> > >>> Cheers
> > >>> 
> > >>> -Filippo
> > >> 
> > >> --
> > >> Professional Support for Apache CouchDB:
> > >> https://neighbourhood.ie/couchdb-support/
> > >> 
> > > 
> > 
> > --
> > Professional Support for Apache CouchDB:
> > https://neighbourhood.ie/couchdb-support/
> > 
> >
>

Re: Commits to the wrong list?

[Joan Touzet]

Hi Jan, I didn't see an INFRA ticket on this so I've filed a new one:

https://issues.apache.org/jira/browse/INFRA-13754

-Joan

- Original Message -
> From: "Jan Lehnardt" 
> To: dev@couchdb.apache.org
> Sent: Friday, March 17, 2017 9:53:37 AM
> Subject: Re: Commits to the wrong list?
> 
> Oh, I was told this was fixed already.
> 
> I’m on it.
> 
> Best
> Jan
> --
> > On 17 Mar 2017, at 14:45, Filippo Fadda
> >  wrote:
> > 
> > Hi Jan,
> > 
> > it has been a week now, isn’t possible to change the e-mail on
> > GitHub from dev@couchdb.apache.org 
> > to comm...@couchdb.apache.org ?
> > Otherwise I guess I will be forced to abandon the list.
> > 
> > Cordially
> > 
> > -Filippo
> > 
> >> On 9 Mar 2017, at 15:08, Jan Lehnardt  wrote:
> >> 
> >> Hi Filippo,
> >> 
> >> we’ve changed our git integration yesterday and it looks like the
> >> email settings got reset. I’m following up with ASF infra to sort
> >> this out. Sorry for the inconvenience.
> >> 
> >> Best
> >> Jan
> >> --
> >> PS: We’re not all guys here.
> >>> On 9 Mar 2017, at 15:41, Filippo Fadda
> >>>  wrote:
> >>> 
> >>> Hi guys,
> >>> 
> >>> since yesterday I’m receiving a ton of e-mails from GitHub.
> >>> Perhaps I should receive these e-emails because I have
> >>> subscribed to comm...@couchdb.apache.org
> >>> , but I have not.
> >>> 
> >>> Cheers
> >>> 
> >>> -Filippo
> >> 
> >> --
> >> Professional Support for Apache CouchDB:
> >> https://neighbourhood.ie/couchdb-support/
> >> 
> > 
> 
> --
> Professional Support for Apache CouchDB:
> https://neighbourhood.ie/couchdb-support/
> 
>

Following our Review-Then-Commit process (was: couchdb pull request #454)

[Joan Touzet]

All,

I wanted to express a concern with my CouchDB PMC hat on.

There is some great work being merged by Cloudant here. But I'm not
seeing the Review-Then-Commit pattern being followed in a significant
number of these PRs coming through to any of our repos.

Take as an example this one, which is one of 4 related PRs to merge
replicator scheduling work. None of these 4 PRs shows an independent +1
posted to the comment thread, or even a token +1 by a fellow Cloudant
committer. Nor does the JIRA ticket, COUCHDB-3324, show anything other
than the text "Merge scheduling replicator" and links to the related 4
PRs in its description.

As a developer I have no clue what this actually does. There is some
additional detail in some of the PR commits but at least one of them has
so many commits, I can't suss out the overall meaning of the change.

As an occasional documentation author I don't know how I'd begin to
explain the change, and there is sadly not an associated PR in the
couchdb-documentation repository. Our documentation is already behind
from 2.0, and while some of our committers out there are making PRs to
get these things merged in, I'd like not to fall further behind in this
area.

Finally, there is no test case being committed for this work. As a
relatively large change to the code base, in an area where we have
traditionally had subtle issues, I find this very disappointing.

Can someone from Cloudant help improve the process here going forward?

Thanks,
Joan

- Original Message -
> From: "nickva" 
> To: dev@couchdb.apache.org
> Sent: Monday, April 3, 2017 5:01:55 PM
> Subject: [GitHub] couchdb pull request #454: Point to scheduling replicator 
> dependencies.
> 
> Github user nickva closed the pull request at:
> 
> https://github.com/apache/couchdb/pull/454
> 
> 
> ---
> If your project is set up for it, you can reply to this email and
> have your
> reply appear on GitHub as well. If your project does not have this
> feature
> enabled and wishes so, or if the feature is enabled but not working,
> please
> contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> with INFRA.
> ---
> 

[GitHub] couchdb pull request #454: Point to scheduling replicator dependencies.

[nickva]

Github user nickva closed the pull request at:

https://github.com/apache/couchdb/pull/454


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-documentation pull request #119: Remove references to all_or_nothing...

[nickva]

Github user nickva closed the pull request at:

https://github.com/apache/couchdb-documentation/pull/119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-documentation issue #119: Remove references to all_or_nothing for _b...

[nickva]

Github user nickva commented on the issue:

https://github.com/apache/couchdb-documentation/pull/119
  
+1

Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton issue #883: Navbar refactor

[garrensmith]

Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/883
  
This is coming along nicely. I'm seeing two issues. 


![https://www.dropbox.com/s/428id1nw7yw2svw/Screenshot%202017-04-03%2013.00.08.png?dl=1](https://www.dropbox.com/s/428id1nw7yw2svw/Screenshot%202017-04-03%2013.00.08.png?dl=1)
 My accounts/reset password block is hidden.

Then if I make my screen narrow. The navbar struggles a bit:

![https://www.dropbox.com/s/apoj4o790xfuy3o/Screenshot%202017-04-03%2013.01.59.png?dl=1](https://www.dropbox.com/s/apoj4o790xfuy3o/Screenshot%202017-04-03%2013.01.59.png?dl=1)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

[garrensmith]

Github user garrensmith commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/883#discussion_r109368776
  
--- Diff: settings.json.default.json ---
@@ -47,7 +51,9 @@
 "dest": "dist/debug/index.html",
 "variables": {
   "title": "Project Fauxton",
-  "generationLabel": "Fauxton Couchapp"
+  "generationLabel": "Fauxton Couchapp",
--- End diff --

This is so awesome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton issue #890: Warning notification for missing document in dat...

[garrensmith]

Github user garrensmith closed the issue at:

https://github.com/apache/couchdb-fauxton/issues/890


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request #893: consistent error message for views and do...

[garrensmith]

Github user garrensmith closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/893


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---