[jira] [Commented] (COUCHDB-2590) Drop all etap
[ https://issues.apache.org/jira/browse/COUCHDB-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521419#comment-14521419 ] ASF GitHub Bot commented on COUCHDB-2590: - GitHub user eiri opened a pull request: https://github.com/apache/couchdb-ets-lru/pull/1 Migrate the tests from etap to eunit All the etap tests converted to eunit. The tests for the validating of the correct handeling of the bad options for LRU are re-enabled. This work is a part of COUCHDB-2590. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eiri/couchdb-ets-lru migrate-tests-to-eunit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-ets-lru/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit fb44bea467f13497d1af8b869f62203ba58a9dcb Author: Eric Avdey Date: 2015-04-30T12:16:19Z Migrate the tests from etap to eunit All the etap tests converted to eunit. The tests for the validating of the correct handeling of the bad options for LRU are re-enabled. This work is a part of COUCHDB-2590. > Drop all etap > - > > Key: COUCHDB-2590 > URL: https://issues.apache.org/jira/browse/COUCHDB-2590 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Test Suite >Affects Versions: 2.0.0 >Reporter: Alexander Shorin >Assignee: Alexander Shorin >Priority: Blocker > Fix For: 2.0.0 > > > We still have it in our dependencies and those are excluded from common > testing process. Show no mercy! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2656) Update couch_mrview to use chttpd provided functions
[ https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520026#comment-14520026 ] ASF GitHub Bot commented on COUCHDB-2656: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/48 Fix broken test suite for COUCHDB-2656 COUCHDB-2656 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch 2656-use-chttpd-functions-fixup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit f7b9dae2db409299102131c449f1d331a7bd915a Author: ILYA Khlopotov Date: 2015-04-29T19:29:03Z Fix broken test suite for COUCHDB-2656 COUCHDB-2656 > Update couch_mrview to use chttpd provided functions > > > Key: COUCHDB-2656 > URL: https://issues.apache.org/jira/browse/COUCHDB-2656 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > couch_mrview uses functions from couch_http. For example > send_external_response is used by couch_mrview_show. This brakes CORS > support. Since couch_httpd's version of send_external_response doesn't have > support for CORS compared to chttpd's version > https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2650) Etag is 'undefined' when _all_docs
[
https://issues.apache.org/jira/browse/COUCHDB-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520009#comment-14520009
]
ASF GitHub Bot commented on COUCHDB-2650:
-
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/34
Handle Etag generation in one place
COUCHDB-2650
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-chttpd 2650-etag-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
commit 98a372680c1251fce47c5af8da931be409d9756a
Author: ILYA Khlopotov
Date: 2015-04-29T18:39:55Z
Handle Etag generation in one place
COUCHDB-2650
> Etag is 'undefined' when _all_docs
> --
>
> Key: COUCHDB-2650
> URL: https://issues.apache.org/jira/browse/COUCHDB-2650
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
>Reporter: ILYA
>Assignee: ILYA
>Priority: Minor
>
> Steps to reproduce
> http --json --auth='adm:pass' PUT 'http://localhost:15984/test_db'
> http -v --json --auth='adm:pass' GET
> 'http://localhost:15984/test_db/_all_docs'
> HTTP/1.1 200 OK
> Cache-Control: must-revalidate
> Content-Type: application/json
> Date: Thu, 26 Mar 2015 15:21:56 GMT
> ETag: undefined
> Server: CouchDB/b6d8665 (Erlang OTP/17)
> Transfer-Encoding: chunked
> X-Couch-Request-ID: 2f7f8320
> X-CouchDB-Body-Time: 0
> {
> "offset": 0,
> "rows": [],
> "total_rows": 0
> }
> The cause of this is in the following line
> https://github.com/apache/couchdb-couch-mrview/blob/master/src/couch_mrview_http.erl#L331
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2667) Regression: /_db_updates response format changed
[
https://issues.apache.org/jira/browse/COUCHDB-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519413#comment-14519413
]
ASF GitHub Bot commented on COUCHDB-2667:
-
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/47
Add test suite for global_changes
COUCHDB-2667
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-couch 2667-chages-format-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
commit 79378da71b6561fa1ba1bfa2b9cf0787eb495a6d
Author: ILYA Khlopotov
Date: 2015-04-29T14:20:47Z
Add test suite for global_changes
COUCHDB-2667
> Regression: /_db_updates response format changed
>
>
> Key: COUCHDB-2667
> URL: https://issues.apache.org/jira/browse/COUCHDB-2667
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Reporter: Alexander Shorin
>Assignee: ILYA
>Priority: Blocker
> Labels: regression
> Fix For: 2.0.0
>
>
> In CouchDB 2.0:
> {code}
> {
> "dbname": "aiocouchdb/1837f0420b9443f79b039b0aec01c7b2",
> "type": "deleted",
> "account": "test",
> "seq": [
> 1,
>
> "g1FxeJzLYWBg4MhgTmHgz8tPSTV2MDQy1zMAQsMcoARTIkOS_P___7MymBMZc4EC7MnGqeaWpoaYynEakaQAJJPsQaYkMsBVGaKrcgCpigfbBbQVbJdlmlGSkWkqbpMTQHrq0UxGV5XHAiQZGoAUUOF8wioXQFTuR1ZphFXlAYjK-4RVPoCoBLkzCwD71WBR"
> ]
> }
> {code}
> In CouchDB 1.6.1:
> {code}
> {
> "type": "updated",
> "db_name": "test/aiocouchdb/0e6b5cb3b2e94376b0ecd6ec918e9704"
> }
> {code}
> Breaking changes:
> - db_name vs dbname
> - dbname doesn't contains full database name because first segment of slashed
> name goes to account field
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2673) "Location" header in HTTP response should properly encode the document _id
[
https://issues.apache.org/jira/browse/COUCHDB-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516989#comment-14516989
]
ASF GitHub Bot commented on COUCHDB-2673:
-
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb/pull/314
> "Location" header in HTTP response should properly encode the document _id
> --
>
> Key: COUCHDB-2673
> URL: https://issues.apache.org/jira/browse/COUCHDB-2673
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
>
> When inserting a document in a CouchDB 1.6.1 database, the response sent by
> CouchDB contains a "Location" HTTP header with the URI of the newly created
> document.
> However, if the "_id" of the new document contains non-ASCII characters, this
> "Location" header is not properly encoded.
> Example:
> {code}
> % curl -v -H "Content-Type: application/json" -X POST
> http://localhost:5984/test/ --data '{"_id": "xxxé"}'
> * Trying ::1...
> * Connected to localhost (::1) port 5984 (#0)
> > POST /test/ HTTP/1.1
> > Host: localhost:5984
> > User-Agent: curl/7.42.0
> > Accept: */*
> > Content-Type: application/json
> > Content-Length: 16
> >
> * upload completely sent off: 16 out of 16 bytes
> < HTTP/1.1 201 Created
> < Server: CouchDB/1.6.1 (Erlang OTP/17)
> < Location: http://localhost:5984/test/xxxé
> < ETag: "1-967a00dff5e02add41819138abb3284d"
> < Date: Sat, 25 Apr 2015 21:33:04 GMT
> < Content-Type: text/plain; charset=utf-8
> < Content-Length: 68
> < Cache-Control: must-revalidate
> <
> {"ok":true,"id":"xxxé","rev":"1-967a00dff5e02add41819138abb3284d"}
> {code}
> According to RFC 2616 ("HTTP headers only contain ASCII") and RFC 2396 ("here
> is how to construct an URI from ASCII characters"), the "Location" header
> should be formatted as:
> {code}
> Location: http://localhost:5984/test/xxx%C3%A9
> {code}
> The "spray.io" framework warns against this invalid response when doing such
> a request towards a CouchDB database.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2677) Wrong Expires header weekday
[
https://issues.apache.org/jira/browse/COUCHDB-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516842#comment-14516842
]
ASF GitHub Bot commented on COUCHDB-2677:
-
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb/pull/317
> Wrong Expires header weekday
>
>
> Key: COUCHDB-2677
> URL: https://issues.apache.org/jira/browse/COUCHDB-2677
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 2.0.0, 1.6.1
>Reporter: Samuel Tardieu
>
> The Expires header returned by /_uuids pretends that Jan. 1st 1990 was a
> Friday, while it was a Monday
> (http://www.timeanddate.com/calendar/?year=1990).
> {code}
> % curl -v http://localhost:5984/_uuids
> * Trying ::1...
> * Connected to localhost (::1) port 5984 (#0)
> > GET /_uuids HTTP/1.1
> > Host: localhost:5984
> > User-Agent: curl/7.42.0
> > Accept: */*
> >
> < HTTP/1.1 200 OK
> < Server: CouchDB/1.6.1 (Erlang OTP/17)
> < Pragma: no-cache
> < Expires: Fri, 01 Jan 1990 00:00:00 GMT
> < ETag: "6LTRS9X19427AV07PBMVAX1T5"
> < Date: Tue, 28 Apr 2015 10:57:30 GMT
> < Content-Type: text/plain; charset=utf-8
> < Content-Length: 47
> < Cache-Control: must-revalidate, no-cache
> <
> {"uuids":["a1e0504a69677e3fe4c0d7b65500059b"]}
> {code}
> The HTTP parser in Akka detects this and warns about it:
> {code}
> [WARN] [04/28/2015 12:57:59.649]
> [canape-test-akka.actor.default-dispatcher-2] [ActorSystem(canape-test)]
> Illegal response header: Illegal 'expires' header: Illegal weekday in date
> 1990-01-01T00:00:00: is 'Fri' but should be 'Mon'
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2677) Wrong Expires header weekday
[
https://issues.apache.org/jira/browse/COUCHDB-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516838#comment-14516838
]
ASF GitHub Bot commented on COUCHDB-2677:
-
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/46
> Wrong Expires header weekday
>
>
> Key: COUCHDB-2677
> URL: https://issues.apache.org/jira/browse/COUCHDB-2677
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 2.0.0, 1.6.1
>Reporter: Samuel Tardieu
>
> The Expires header returned by /_uuids pretends that Jan. 1st 1990 was a
> Friday, while it was a Monday
> (http://www.timeanddate.com/calendar/?year=1990).
> {code}
> % curl -v http://localhost:5984/_uuids
> * Trying ::1...
> * Connected to localhost (::1) port 5984 (#0)
> > GET /_uuids HTTP/1.1
> > Host: localhost:5984
> > User-Agent: curl/7.42.0
> > Accept: */*
> >
> < HTTP/1.1 200 OK
> < Server: CouchDB/1.6.1 (Erlang OTP/17)
> < Pragma: no-cache
> < Expires: Fri, 01 Jan 1990 00:00:00 GMT
> < ETag: "6LTRS9X19427AV07PBMVAX1T5"
> < Date: Tue, 28 Apr 2015 10:57:30 GMT
> < Content-Type: text/plain; charset=utf-8
> < Content-Length: 47
> < Cache-Control: must-revalidate, no-cache
> <
> {"uuids":["a1e0504a69677e3fe4c0d7b65500059b"]}
> {code}
> The HTTP parser in Akka detects this and warns about it:
> {code}
> [WARN] [04/28/2015 12:57:59.649]
> [canape-test-akka.actor.default-dispatcher-2] [ActorSystem(canape-test)]
> Illegal response header: Illegal 'expires' header: Illegal weekday in date
> 1990-01-01T00:00:00: is 'Fri' but should be 'Mon'
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2677) Wrong Expires header weekday
[
https://issues.apache.org/jira/browse/COUCHDB-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516830#comment-14516830
]
ASF GitHub Bot commented on COUCHDB-2677:
-
GitHub user samueltardieu opened a pull request:
https://github.com/apache/couchdb-couch/pull/46
Week of day for past expiration date 1990-01-01 is Monday
Fixes COUCHDB-2677
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samueltardieu/couchdb-couch
wrong-weekday-in-expires-header
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
commit 35bb5ddb4cf66e875755cb93e0718488e73336c7
Author: Samuel Tardieu
Date: 2015-04-28T11:17:05Z
Week of day for past expiration date 1990-01-01 is Monday
Fixes COUCHDB-2677
> Wrong Expires header weekday
>
>
> Key: COUCHDB-2677
> URL: https://issues.apache.org/jira/browse/COUCHDB-2677
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 2.0.0, 1.6.1
>Reporter: Samuel Tardieu
>
> The Expires header returned by /_uuids pretends that Jan. 1st 1990 was a
> Friday, while it was a Monday
> (http://www.timeanddate.com/calendar/?year=1990).
> {code}
> % curl -v http://localhost:5984/_uuids
> * Trying ::1...
> * Connected to localhost (::1) port 5984 (#0)
> > GET /_uuids HTTP/1.1
> > Host: localhost:5984
> > User-Agent: curl/7.42.0
> > Accept: */*
> >
> < HTTP/1.1 200 OK
> < Server: CouchDB/1.6.1 (Erlang OTP/17)
> < Pragma: no-cache
> < Expires: Fri, 01 Jan 1990 00:00:00 GMT
> < ETag: "6LTRS9X19427AV07PBMVAX1T5"
> < Date: Tue, 28 Apr 2015 10:57:30 GMT
> < Content-Type: text/plain; charset=utf-8
> < Content-Length: 47
> < Cache-Control: must-revalidate, no-cache
> <
> {"uuids":["a1e0504a69677e3fe4c0d7b65500059b"]}
> {code}
> The HTTP parser in Akka detects this and warns about it:
> {code}
> [WARN] [04/28/2015 12:57:59.649]
> [canape-test-akka.actor.default-dispatcher-2] [ActorSystem(canape-test)]
> Illegal response header: Illegal 'expires' header: Illegal weekday in date
> 1990-01-01T00:00:00: is 'Fri' but should be 'Mon'
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2677) Wrong Expires header weekday
[
https://issues.apache.org/jira/browse/COUCHDB-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516824#comment-14516824
]
ASF GitHub Bot commented on COUCHDB-2677:
-
GitHub user samueltardieu opened a pull request:
https://github.com/apache/couchdb/pull/317
Week of day for past expiration date 1990-01-01 is Monday
Fixes COUCHDB-2677
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samueltardieu/couchdb
wrong-weekday-in-expires-header
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/317.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #317
commit 6e0202cc757f8f8c19250b312d4ac2e25d642a88
Author: Samuel Tardieu
Date: 2015-04-28T11:12:42Z
Week of day for past expiration date 1990-01-01 is Monday
Fixes COUCHDB-2677
> Wrong Expires header weekday
>
>
> Key: COUCHDB-2677
> URL: https://issues.apache.org/jira/browse/COUCHDB-2677
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
>
> The Expires header returned by /_uuids pretends that Jan. 1st 1990 was a
> Friday, while it was a Monday
> (http://www.timeanddate.com/calendar/?year=1990).
> {code}
> % curl -v http://localhost:5984/_uuids
> * Trying ::1...
> * Connected to localhost (::1) port 5984 (#0)
> > GET /_uuids HTTP/1.1
> > Host: localhost:5984
> > User-Agent: curl/7.42.0
> > Accept: */*
> >
> < HTTP/1.1 200 OK
> < Server: CouchDB/1.6.1 (Erlang OTP/17)
> < Pragma: no-cache
> < Expires: Fri, 01 Jan 1990 00:00:00 GMT
> < ETag: "6LTRS9X19427AV07PBMVAX1T5"
> < Date: Tue, 28 Apr 2015 10:57:30 GMT
> < Content-Type: text/plain; charset=utf-8
> < Content-Length: 47
> < Cache-Control: must-revalidate, no-cache
> <
> {"uuids":["a1e0504a69677e3fe4c0d7b65500059b"]}
> {code}
> The HTTP parser in Akka detects this and warns about it:
> {code}
> [WARN] [04/28/2015 12:57:59.649]
> [canape-test-akka.actor.default-dispatcher-2] [ActorSystem(canape-test)]
> Illegal response header: Illegal 'expires' header: Illegal weekday in date
> 1990-01-01T00:00:00: is 'Fri' but should be 'Mon'
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2673) "Location" header in HTTP response should properly encode the document _id
[
https://issues.apache.org/jira/browse/COUCHDB-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512759#comment-14512759
]
ASF GitHub Bot commented on COUCHDB-2673:
-
GitHub user samueltardieu opened a pull request:
https://github.com/apache/couchdb/pull/314
Properly escape Location: HTTP header
Non-ASCII characters in the "Location:" header must be URL-encoded. This
can happen if a document is inserted with a user-defined "_id"
containing non-ASCII characters or if a filename contains non-ASCII
characters.
Fixes COUCHDB-2673
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samueltardieu/couchdb
urlencode-location-header
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #314
commit a3fee552ddc6014767f1ed393f0960ca1ada3fe5
Author: Samuel Tardieu
Date: 2015-04-25T22:10:04Z
Properly escape Location: HTTP header
Non-ASCII characters in the "Location:" header must be URL-encoded. This
can happen if a document is inserted with a user-defined "_id"
containing non-ASCII characters or if a filename contains non-ASCII
characters.
Fixes COUCHDB-2673
> "Location" header in HTTP response should properly encode the document _id
> --
>
> Key: COUCHDB-2673
> URL: https://issues.apache.org/jira/browse/COUCHDB-2673
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
>
> When inserting a document in a CouchDB 1.6.1 database, the response sent by
> CouchDB contains a "Location" HTTP header with the URI of the newly created
> document.
> However, if the "_id" of the new document contains non-ASCII characters, this
> "Location" header is not properly encoded.
> Example:
> {code}
> % curl -v -H "Content-Type: application/json" -X POST
> http://localhost:5984/test/ --data '{"_id": "xxxé"}'
> * Trying ::1...
> * Connected to localhost (::1) port 5984 (#0)
> > POST /test/ HTTP/1.1
> > Host: localhost:5984
> > User-Agent: curl/7.42.0
> > Accept: */*
> > Content-Type: application/json
> > Content-Length: 16
> >
> * upload completely sent off: 16 out of 16 bytes
> < HTTP/1.1 201 Created
> < Server: CouchDB/1.6.1 (Erlang OTP/17)
> < Location: http://localhost:5984/test/xxxé
> < ETag: "1-967a00dff5e02add41819138abb3284d"
> < Date: Sat, 25 Apr 2015 21:33:04 GMT
> < Content-Type: text/plain; charset=utf-8
> < Content-Length: 68
> < Cache-Control: must-revalidate
> <
> {"ok":true,"id":"xxxé","rev":"1-967a00dff5e02add41819138abb3284d"}
> {code}
> According to RFC 2616 ("HTTP headers only contain ASCII") and RFC 2396 ("here
> is how to construct an URI from ASCII characters"), the "Location" header
> should be formatted as:
> {code}
> Location: http://localhost:5984/test/xxx%C3%A9
> {code}
> The "spray.io" framework warns against this invalid response when doing such
> a request towards a CouchDB database.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2656) Update couch_mrview to use chttpd provided functions
[ https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509761#comment-14509761 ] ASF GitHub Bot commented on COUCHDB-2656: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/43 > Update couch_mrview to use chttpd provided functions > > > Key: COUCHDB-2656 > URL: https://issues.apache.org/jira/browse/COUCHDB-2656 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > couch_mrview uses functions from couch_http. For example > send_external_response is used by couch_mrview_show. This brakes CORS > support. Since couch_httpd's version of send_external_response doesn't have > support for CORS compared to chttpd's version > https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2656) Update couch_mrview to use chttpd provided functions
[ https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509755#comment-14509755 ] ASF GitHub Bot commented on COUCHDB-2656: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/31 > Update couch_mrview to use chttpd provided functions > > > Key: COUCHDB-2656 > URL: https://issues.apache.org/jira/browse/COUCHDB-2656 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > couch_mrview uses functions from couch_http. For example > send_external_response is used by couch_mrview_show. This brakes CORS > support. Since couch_httpd's version of send_external_response doesn't have > support for CORS compared to chttpd's version > https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2656) Update couch_mrview to use chttpd provided functions
[ https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509760#comment-14509760 ] ASF GitHub Bot commented on COUCHDB-2656: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-mrview/pull/17 > Update couch_mrview to use chttpd provided functions > > > Key: COUCHDB-2656 > URL: https://issues.apache.org/jira/browse/COUCHDB-2656 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > couch_mrview uses functions from couch_http. For example > send_external_response is used by couch_mrview_show. This brakes CORS > support. Since couch_httpd's version of send_external_response doesn't have > support for CORS compared to chttpd's version > https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2310) Add a bulk API for revs & open_revs
[
https://issues.apache.org/jira/browse/COUCHDB-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508858#comment-14508858
]
ASF GitHub Bot commented on COUCHDB-2310:
-
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/33
Implement /db/_bulk_get endpoint
Based on RCouch implementation by @benoitc.
COUCHDB-2310
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-chttpd 2310-bulk_get
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
commit ced8a8d77fa100ea83f1a8f87bccb6ea17799af9
Author: Alexander Shorin
Date: 2015-04-22T18:30:47Z
Implement /db/_bulk_get endpoint
Based on RCouch implementation by @benoitc.
COUCHDB-2310
> Add a bulk API for revs & open_revs
> ---
>
> Key: COUCHDB-2310
> URL: https://issues.apache.org/jira/browse/COUCHDB-2310
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Reporter: Nolan Lawson
>Assignee: Alexander Shorin
>
> CouchDB replication is too slow.
> And what makes it so slow is that it's just so unnecessarily chatty. During
> replication, you have to do a separate GET for each individual document, in
> order to get the full {{_revisions}} object for that document (using the
> {{revs}} and {{open_revs}} parameters – refer to [the TouchDB
> writeup|https://github.com/couchbaselabs/TouchDB-iOS/wiki/Replication-Algorithm]
> or [Benoit's writeup|http://dataprotocols.org/couchdb-replication/] if you
> need a refresher).
> So for example, let's say you've got a database full of 10,000 documents, and
> you replicate using a batch size of 500 (batch sizes are configurable in
> PouchDB). The conversation for a single batch basically looks like this:
> {code}
> - REPLICATOR: gimme 500 changes since seq X (1 GET request)
> - SOURCE: okay
> - REPLICATOR: gimme the _revs_diff for these 500 docs/_revs (1 POST request)
> - SOURCE: okay
> - repeat 500 times:
> - REPLICATOR: gimme the _revisions for doc n with _revs [...] (1 GET
> request)
> - SOURCE: okay
> - REPLICATOR: here's a _bulk_docs with 500 documents (1 POST request)
> - TARGET: okay
> {code}
> See the problem here? That 500-loop, where we have to do a GET for each one
> of 500 documents, is a lot of unnecessary back-and-forth, considering that
> the replicator already knows what it needs before the loop starts. You can
> parallelize, but if you assume a browser (e.g. for PouchDB), most browsers
> only let you do ~8 simultaneous requests at once. Plus, there's latency and
> HTTP headers to consider. So overall, it's not cool.
> So why do we even need to do the separate requests? Shouldn't {{_all_docs}}
> be good enough? Turns out it's not, because we need this special
> {{_revisions}} object.
> For example, consider a document {{'foo'}} with 10 revisions. You may compact
> the database, in which case revisions {{1-x}} through {{9-x}} are no longer
> retrievable. However, if you query using {{revs}} and {{open_revs}}, those
> rev IDs are still available:
> {code}
> $ curl 'http://nolan.iriscouch.com/test/foo?revs=true&open_revs=all'
> {
> "_id": "foo",
> "_rev": "10-c78e199ad5e996b240c9d6482907088e",
> "_revisions": {
> "start": 10,
> "ids": [
> "c78e199ad5e996b240c9d6482907088e",
> "f560283f1968a05046f0c38e468006bb",
> "0091198554171c632c27c8342ddec5af",
> "e0a023e2ea59db73f812ad773ea08b17",
> "65d7f8b8206a244035edd9f252f206ad",
> "069d1432a003c58bdd23f01ff80b718f",
> "d21f26bb604b7fe9eba03ce4562cf37b",
> "31d380f99a6e54875855e1c24469622d",
> "3b4791360024426eadafe31542a2c34b",
> "967a00dff5e02add41819138abb3284d"
> ]
> }
> }
> {code}
> And in the replication algorithm, _this full \_revisions object is required_
> at the point when you copy the document from one database to another, which
> is accomplished with a POST to {{_bulk_docs}} using {{new_edits=false}}. If
> you don't have the full {{_revisions}} object, CouchDB accepts the new
> revision, but considers it to be a conflict. (The exception is with
> generation-1 documents, since they have no history, so as it says in the
> TouchDB writeup, you can safely just use {{_all_docs}} as an optimization for
> such documents.)
> And unfortunately, this {{_revision}} object is only available from the {{GET
> /:dbid/:docid}} endpoint. Trust me; I've tried the other APIs. You can't get
> it anywhere else.
> This
[jira] [Commented] (COUCHDB-2671) Entering db name in DB search field on DB page shows wonky URL
[ https://issues.apache.org/jira/browse/COUCHDB-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507666#comment-14507666 ] ASF GitHub Bot commented on COUCHDB-2671: - GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/392 fix for DB typeahead link This adds a test to confirm the db name typeahead field in the header of the Database page works as expected, and that the URL it redirects to doesn't include an invalid 'undefined' string at the end of it. Closes COUCHDB-2671 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton db-name-redirect-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #392 commit 4ebb9e48a6108f2ebbe90bca3b4a57980b266d30 Author: Ben Keen Date: 2015-04-22T18:53:29Z fix for DB typeahead link This adds a test to confirm the db name typeahead field in the header of the Database page works as expected, and that the URL it redirects to doesn't include an invalid 'undefined' string at the end of it. Closes COUCHDB-2671 > Entering db name in DB search field on DB page shows wonky URL > -- > > Key: COUCHDB-2671 > URL: https://issues.apache.org/jira/browse/COUCHDB-2671 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Small thing, but when you select a database by entering its name in the > Search DB field at the top of the Databases page, you get redirect to the > database fine, but you see this in your URL: > http://you:8000/#database/one/_all_docsundefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2656) Update couch_mrview to use chttpd provided functions
[ https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498140#comment-14498140 ] ASF GitHub Bot commented on COUCHDB-2656: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/43 Add CORS test case for couch_mrview_show COUCHDB-2656 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch 2656-use-chttpd-functions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 6ddb2ab7a1af7a9def8b22dea013cc9f400ea084 Author: ILYA Khlopotov Date: 2015-04-16T14:49:30Z Add CORS test case for couch_mrview_show COUCHDB-2656 > Update couch_mrview to use chttpd provided functions > > > Key: COUCHDB-2656 > URL: https://issues.apache.org/jira/browse/COUCHDB-2656 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > couch_mrview uses functions from couch_http. For example > send_external_response is used by couch_mrview_show. This brakes CORS > support. Since couch_httpd's version of send_external_response doesn't have > support for CORS compared to chttpd's version > https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2548) "Collapse" should reduce docs to single line
[ https://issues.apache.org/jira/browse/COUCHDB-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487755#comment-14487755 ] ASF GitHub Bot commented on COUCHDB-2548: - GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/373 Docs now fully collapse to single line This reduces selected documents to a single line containing only the ID, rather than show a subset of the doc with an ID and rev. Closes COUCHDB-2548 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton full-collapse-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #373 commit 30c6cba09a07a63afafbaf2d3a082f935c0b6899 Author: Ben Keen Date: 2015-04-09T17:51:35Z Docs now fully collapse to single line This reduces selected documents to a single line containing only the ID, rather than show a subset of the doc with an ID and rev. Closes COUCHDB-2548 > "Collapse" should reduce docs to single line > > > Key: COUCHDB-2548 > URL: https://issues.apache.org/jira/browse/COUCHDB-2548 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Right now when you're on All Docs or anywhere that shows a list of documents, > the "Collapse" option doesn't fully collapse the list - but shows a > redundant, second _id row + _rev. This should be changed to just show a more > concise list of single rows with the IDs. > This has been requested in the past, just never gotten to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2548) "Collapse" should reduce docs to single line
[ https://issues.apache.org/jira/browse/COUCHDB-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487719#comment-14487719 ] ASF GitHub Bot commented on COUCHDB-2548: - Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/230 > "Collapse" should reduce docs to single line > > > Key: COUCHDB-2548 > URL: https://issues.apache.org/jira/browse/COUCHDB-2548 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Right now when you're on All Docs or anywhere that shows a list of documents, > the "Collapse" option doesn't fully collapse the list - but shows a > redundant, second _id row + _rev. This should be changed to just show a more > concise list of single rows with the IDs. > This has been requested in the past, just never gotten to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2627) Make Mango a first class citizen in the dashboard
[ https://issues.apache.org/jira/browse/COUCHDB-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483494#comment-14483494 ] ASF GitHub Bot commented on COUCHDB-2627: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/362 Part 2/2 for Mango: Adds search functionality, makes the feature visible and enables deletion of mango-created-indexes. closes COUCHDB-2627 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton mango-editor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit 7f659b5ffe59044f2ea6b0c3edaa50e60f702b33 Author: Robert Kowalski Date: 2015-04-01T11:11:15Z Part 2/2 for Mango: Adds search functionality, makes the feature visible and enables deletion of mango-created-indexes. closes COUCHDB-2627 > Make Mango a first class citizen in the dashboard > - > > Key: COUCHDB-2627 > URL: https://issues.apache.org/jira/browse/COUCHDB-2627 > Project: CouchDB > Issue Type: New Feature > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Robert Kowalski >Assignee: Robert Kowalski > > Make Mango usable from the dashboard > Notes: https://gist.github.com/robertkowalski/cf75e6fd0555218a2d6c > Concept: https://cldup.com/SjR0xfxpKg.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2656) Update couch_mrview to use chttpd provided functions
[ https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483402#comment-14483402 ] ASF GitHub Bot commented on COUCHDB-2656: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/31 Export etag_match/2 The exported function is used in COUCHDB-2656 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-chttpd 2656-use-chttpd-functions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/31.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #31 commit 1a15afcbf125fef512bf6a35e10bc25dc13cf4e9 Author: ILYA Khlopotov Date: 2015-04-07T15:49:53Z Export etag_match/2 COUCHDB-2656 > Update couch_mrview to use chttpd provided functions > > > Key: COUCHDB-2656 > URL: https://issues.apache.org/jira/browse/COUCHDB-2656 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > couch_mrview uses functions from couch_http. For example > send_external_response is used by couch_mrview_show. This brakes CORS > support. Since couch_httpd's version of send_external_response doesn't have > support for CORS compared to chttpd's version > https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2656) Update couch_mrview to use chttpd provided functions
[ https://issues.apache.org/jira/browse/COUCHDB-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483352#comment-14483352 ] ASF GitHub Bot commented on COUCHDB-2656: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/17 Use chttpd provided functions couch_mrview_show's usage of couch_chttp:send_external_response brakes CORS support. Since couch_httpd's version of send_external_response doesn't have support for CORS compared to chttpd's version. Other couch_http's functions are switched to corresponding chttpd's versions as well. COUCHDB-2656 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch-mrview 2656-use-chttpd-functions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-mrview/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 1dc8d5252d8fbaa9df56ee63800fa616c154602e Author: ILYA Khlopotov Date: 2015-04-07T14:59:00Z Use chttpd provided functions couch_mrview_show's usage of couch_chttp:send_external_response brakes CORS support. Since couch_httpd's version of send_external_response doesn't have support for CORS compared to chttpd's version. Other couch_http's functions are switched to corresponding chttpd's versions as well. COUCHDB-2656 > Update couch_mrview to use chttpd provided functions > > > Key: COUCHDB-2656 > URL: https://issues.apache.org/jira/browse/COUCHDB-2656 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > couch_mrview uses functions from couch_http. For example > send_external_response is used by couch_mrview_show. This brakes CORS > support. Since couch_httpd's version of send_external_response doesn't have > support for CORS compared to chttpd's version > https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_external.erl#L127. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2547) Fix broken tests for couch app
[ https://issues.apache.org/jira/browse/COUCHDB-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481506#comment-14481506 ] ASF GitHub Bot commented on COUCHDB-2547: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/8 > Fix broken tests for couch app > -- > > Key: COUCHDB-2547 > URL: https://issues.apache.org/jira/browse/COUCHDB-2547 > Project: CouchDB > Issue Type: Test > Security Level: public(Regular issues) >Reporter: ILYA >Assignee: ILYA > Fix For: 2.0.0 > > > Some of the tests suites are disabled with -ifdef(run_broken_tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395846#comment-14395846 ] ASF GitHub Bot commented on COUCHDB-2237: - GitHub user robertkowalski reopened a pull request: https://github.com/apache/couchdb-couch/pull/40 add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. PRs for the change: https://github.com/apache/couchdb/pull/307 https://github.com/apache/couchdb-couch/pull/40 https://github.com/apache/couchdb-chttpd/pull/28 closes COUCHDB-2237 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-couch 2237-stream Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit dfeb8ddb337631afd88d2b6d0648e9d1d1996059 Author: Robert Kowalski Date: 2015-03-01T14:44:25Z add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. PRs for the change: https://github.com/apache/couchdb/pull/307 https://github.com/apache/couchdb-couch/pull/40 https://github.com/apache/couchdb-chttpd/pull/28 closes COUCHDB-2237 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395845#comment-14395845 ] ASF GitHub Bot commented on COUCHDB-2237: - GitHub user robertkowalski reopened a pull request: https://github.com/apache/couchdb-chttpd/pull/28 add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. PRs for the change: https://github.com/apache/couchdb/pull/307 https://github.com/apache/couchdb-couch/pull/40 https://github.com/apache/couchdb-chttpd/pull/28 closes COUCHDB-2237 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-chttpd 2237-stream Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit faa3d9d4d259a72cf6f8a31123e52b1d570e2c27 Author: Robert Kowalski Date: 2015-03-01T14:42:24Z add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. PRs for the change: https://github.com/apache/couchdb/pull/307 https://github.com/apache/couchdb-couch/pull/40 https://github.com/apache/couchdb-chttpd/pull/28 closes COUCHDB-2237 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2601) Config section - remove handler from chttpd
[ https://issues.apache.org/jira/browse/COUCHDB-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395750#comment-14395750 ] ASF GitHub Bot commented on COUCHDB-2601: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/360 Cluster configuration fixes for 2.0 In CouchDB 2.0 we don't have `_config` on the clustered interface. As user/admin management also uses _config, also hide it on a cluster. We still support it on the backdoor ports. closes COUCHDB-2601 COUCHDB-2599 COUCHDB-2390 COUCHDB-2390 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton 2601-2390-config-backdoor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/360.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #360 commit b376bcaee66a605e9bb7bfc179fa797f8288f0b3 Author: Robert Kowalski Date: 2015-04-03T20:18:13Z test: remove confirmdialog when running the testsuite in the browser tests were stopped unti confirming with `OK` commit b026a0d85fd9e1251954ce588f7329318312d595 Author: Robert Kowalski Date: 2015-04-02T19:52:23Z config: just show config where it is available In CouchDB 2.0 we don't have `_config` on the clustered interface. We still support it on the backdoor ports. closes COUCHDB-2601 COUCHDB-2390 commit 28f6a12a103fdf98b2719ccd0eb4ae96e1059279 Author: Robert Kowalski Date: 2015-04-04T00:02:41Z login: remove dead code commit a2e499bc979c6eb46e6ec2cac9bb086ce5c5a810 Author: Robert Kowalski Date: 2015-04-04T00:05:09Z move usermanagement which uses `_config` to config commit 9340260d00caf1256d25e83d846b6dadca43f857 Author: Robert Kowalski Date: 2015-04-04T12:46:34Z admin: do not show up on a cluster `_config` is not available on a cluster, so don't offer to alter it for creating admins, changing passwords and fixing the party mode. closes COUCHDB-2601 COUCHDB-2599 COUCHDB-2390 > Config section - remove handler from chttpd > --- > > Key: COUCHDB-2601 > URL: https://issues.apache.org/jira/browse/COUCHDB-2601 > Project: CouchDB > Issue Type: Task > Security Level: public(Regular issues) > Components: Database Core, Fauxton >Reporter: Robert Kowalski >Assignee: Robert Kowalski >Priority: Blocker > Fix For: 2.0.0 > > > if Fauxton gets a 404 we are not using the backdoor port which still > supports `/_config` - this also solves the problem if user are using curl and > try to change configuration on a clustered CouchDB behind a LB -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2433) Allow downloading of views
[ https://issues.apache.org/jira/browse/COUCHDB-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395730#comment-14395730 ] ASF GitHub Bot commented on COUCHDB-2433: - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb/pull/310 > Allow downloading of views > -- > > Key: COUCHDB-2433 > URL: https://issues.apache.org/jira/browse/COUCHDB-2433 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Affects Versions: 2.0.0 >Reporter: Jan Lehnardt >Priority: Minor > > I have a non-technical user of CouchDB that would like a “JSON Export” of > views in Fauxton. They can’t use the command line where they can just `curl > $viewurl > export.json`. > One way to implement this is add a new query parameter to view queries could > be `/db/_design/_view/name?download=true` which adds a Content-Disposition > header so browsers offer the link as a download (and whatever else is > necessary to make browsers behave :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2433) Allow downloading of views
[ https://issues.apache.org/jira/browse/COUCHDB-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395727#comment-14395727 ] ASF GitHub Bot commented on COUCHDB-2433: - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-couch/pull/42 > Allow downloading of views > -- > > Key: COUCHDB-2433 > URL: https://issues.apache.org/jira/browse/COUCHDB-2433 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Affects Versions: 2.0.0 >Reporter: Jan Lehnardt >Priority: Minor > > I have a non-technical user of CouchDB that would like a “JSON Export” of > views in Fauxton. They can’t use the command line where they can just `curl > $viewurl > export.json`. > One way to implement this is add a new query parameter to view queries could > be `/db/_design/_view/name?download=true` which adds a Content-Disposition > header so browsers offer the link as a download (and whatever else is > necessary to make browsers behave :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2433) Allow downloading of views
[ https://issues.apache.org/jira/browse/COUCHDB-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395726#comment-14395726 ] ASF GitHub Bot commented on COUCHDB-2433: - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/30 > Allow downloading of views > -- > > Key: COUCHDB-2433 > URL: https://issues.apache.org/jira/browse/COUCHDB-2433 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Affects Versions: 2.0.0 >Reporter: Jan Lehnardt >Priority: Minor > > I have a non-technical user of CouchDB that would like a “JSON Export” of > views in Fauxton. They can’t use the command line where they can just `curl > $viewurl > export.json`. > One way to implement this is add a new query parameter to view queries could > be `/db/_design/_view/name?download=true` which adds a Content-Disposition > header so browsers offer the link as a download (and whatever else is > necessary to make browsers behave :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2651) Deleting a Mango Design Docs using bulk docs
[
https://issues.apache.org/jira/browse/COUCHDB-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388694#comment-14388694
]
ASF GitHub Bot commented on COUCHDB-2651:
-
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/343
> Deleting a Mango Design Docs using bulk docs
>
>
> Key: COUCHDB-2651
> URL: https://issues.apache.org/jira/browse/COUCHDB-2651
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: go
>Reporter: Robert Kowalski
>
> In Fauxtont the user can list documents / indexes and select multiple of
> them. The user can then press one button to delete all selected documents.
> This works for Mango created design docs, but it is quite hard to get the
> revision id as /_index does not list them. Current workarounds are:
> 1. firing a lot of multiple requests, but given that one doc list can have
> 100 entries this is not a viable solution:
> curl -XGET
> "http://localhost:8000/animaldb/_design/e4d338e5d6f047749f5399ab998b4fa04ba0c816";
> {"_id":"_design/e4d338e5d6f047749f5399ab998b4fa04ba0c816","_rev":"1-1f37105891681e717ae37dae973bc6a4","language":"query","views":{"e4d338e5d6f047749f5399ab998b4fa04ba0c816":{"map":{"fields":{"_id":"asc"}},"reduce":"_count","options":{"def":{"fields":["_id"]},"w":2
> 2. Querying all the design docs with includedocs, and don't use the _index
> endpoint, then filter out all all indexes which are not mango indexes and use
> the result for building the list of documents which then can get checked and
> deleted (downside: performance, not using the existing endpoint from mango
> which makes it a bit obsolete, at least for Fauxton)
> For me there are two possible solutions:
> - returning the rev id in GET /_index
> - implementing an additional POST /_bulk_index endpoint
> while I would prefer the first as the _bulk_docs endpoint already exists and
> works very well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2577) Invalid 'undefined' class in All Docs header button element
[ https://issues.apache.org/jira/browse/COUCHDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386804#comment-14386804 ] ASF GitHub Bot commented on COUCHDB-2577: - Github user wadsashika closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/332 > Invalid 'undefined' class in All Docs header button element > --- > > Key: COUCHDB-2577 > URL: https://issues.apache.org/jira/browse/COUCHDB-2577 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen > Attachments: Screen Shot 2015-02-11 at 8.08.19 AM.png > > > Super minor thing. > View source on the "Select" item in the All Docs page header. There's an > "undefined" class on the button.control-toggle-alternative-header element > (screenshot attached). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2651) Deleting a Mango Design Docs using bulk docs
[
https://issues.apache.org/jira/browse/COUCHDB-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386669#comment-14386669
]
ASF GitHub Bot commented on COUCHDB-2651:
-
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/343
Mango: creation and listing of indexes
Part 1/2 for Mango:
Creation of Mango indexes and listing them. Disabled pagination
and bulk-deletion for now, see:
https://issues.apache.org/jira/browse/COUCHDB-2651
https://issues.apache.org/jira/browse/COUCHDB-2652
As you can't use the feature right now (querying is part 2/2)
the buttons to reach the features are hidden behind a feature flip.
Use the direct urls to access the features:
http://localhost:8000/#database/$YOUR_DATABASE/_index
http://localhost:8000/#database/$YOUR_DATABASE/_indexlist
or add `?beta=showquery` to your url, e.g.
http://localhost:8000/#database/$YOUR_DATABASE/?beta=showquery
Additionally prepares the app for i18n.
COUCHDB-2627
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton
mango-tropical-fruits
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
commit 330c2585a77d03bbf7f66ebd22fd0f0ffc39836e
Author: Robert Kowalski
Date: 2015-03-27T13:16:43Z
Mango: creation and listing of indexes
Part 1/2 for Mango:
Creation of Mango indexes and listing them. Disabled pagination
and bulk-deletion for now, see:
https://issues.apache.org/jira/browse/COUCHDB-2651
https://issues.apache.org/jira/browse/COUCHDB-2652
As you can't use the feature right now (querying is part 2/2)
the buttons to reach the features are hidden behind a feature flip.
Use the direct urls to access the features:
http://localhost:8000/#database/$YOUR_DATABASE/_index
http://localhost:8000/#database/$YOUR_DATABASE/_indexlist
or add `?beta=showquery` to your url, e.g.
http://localhost:8000/#database/$YOUR_DATABASE/?beta=showquery
Additionally prepares the app for i18n.
COUCHDB-2627
> Deleting a Mango Design Docs using bulk docs
>
>
> Key: COUCHDB-2651
> URL: https://issues.apache.org/jira/browse/COUCHDB-2651
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: go
>Reporter: Robert Kowalski
>
> In Fauxtont the user can list documents / indexes and select multiple of
> them. The user can then press one button to delete all selected documents.
> This works for Mango created design docs, but it is quite hard to get the
> revision id as /_index does not list them. Current workarounds are:
> 1. firing a lot of multiple requests, but given that one doc list can have
> 100 entries this is not a viable solution:
> curl -XGET
> "http://localhost:8000/animaldb/_design/e4d338e5d6f047749f5399ab998b4fa04ba0c816";
> {"_id":"_design/e4d338e5d6f047749f5399ab998b4fa04ba0c816","_rev":"1-1f37105891681e717ae37dae973bc6a4","language":"query","views":{"e4d338e5d6f047749f5399ab998b4fa04ba0c816":{"map":{"fields":{"_id":"asc"}},"reduce":"_count","options":{"def":{"fields":["_id"]},"w":2
> 2. Querying all the design docs with includedocs, and don't use the _index
> endpoint, then filter out all all indexes which are not mango indexes and use
> the result for building the list of documents which then can get checked and
> deleted (downside: performance, not using the existing endpoint from mango
> which makes it a bit obsolete, at least for Fauxton)
> For me there are two possible solutions:
> - returning the rev id in GET /_index
> - implementing an additional POST /_bulk_index endpoint
> while I would prefer the first as the _bulk_docs endpoint already exists and
> works very well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2433) Allow downloading of views
[ https://issues.apache.org/jira/browse/COUCHDB-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385891#comment-14385891 ] ASF GitHub Bot commented on COUCHDB-2433: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-chttpd/pull/30 allow downloading docs/views this enables downloading of views using a browser, e.g. via a button in Fauxton. api: http://localhost:5984/mydb/_design/foobar?download=true PRs: https://github.com/apache/couchdb-couch/pull/42 https://github.com/apache/couchdb/pull/310 https://github.com/apache/couchdb-chttpd/pull/30 COUCHDB-2433 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-chttpd 2433-download-views Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit eb8dbbebec6d4143379f769728ef93403e10e3ce Author: Robert Kowalski Date: 2015-03-29T18:48:16Z allow downloading docs/views this enables downloading of views using a browser, e.g. via a button in Fauxton. api: http://localhost:5984/mydb/_design/foobar?download=true PRs: https://github.com/apache/couchdb-couch/pull/42 https://github.com/apache/couchdb/pull/310 https://github.com/apache/couchdb-chttpd/pull/30 COUCHDB-2433 > Allow downloading of views > -- > > Key: COUCHDB-2433 > URL: https://issues.apache.org/jira/browse/COUCHDB-2433 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Affects Versions: 2.0.0 >Reporter: Jan Lehnardt >Assignee: Robert Kowalski >Priority: Minor > > I have a non-technical user of CouchDB that would like a “JSON Export” of > views in Fauxton. They can’t use the command line where they can just `curl > $viewurl > export.json`. > One way to implement this is add a new query parameter to view queries could > be `/db/_design/_view/name?download=true` which adds a Content-Disposition > header so browsers offer the link as a download (and whatever else is > necessary to make browsers behave :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2154) Scrollbar is overlapped by action bar in Chrome for views page
[ https://issues.apache.org/jira/browse/COUCHDB-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385888#comment-14385888 ] ASF GitHub Bot commented on COUCHDB-2154: - Github user baweaver closed the pull request at: https://github.com/apache/couchdb/pull/176 > Scrollbar is overlapped by action bar in Chrome for views page > -- > > Key: COUCHDB-2154 > URL: https://issues.apache.org/jira/browse/COUCHDB-2154 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Alexander Shorin > Attachments: COUCHDB-2154-chrome-scrollbar-bug.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2433) Allow downloading of views
[ https://issues.apache.org/jira/browse/COUCHDB-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385886#comment-14385886 ] ASF GitHub Bot commented on COUCHDB-2433: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-couch/pull/42 allow downloading docs/views this enables downloading of views, e.g. via a button in Fauxton. api: http://localhost:5984/mydb/_design/foobar?download=true COUCHDB-2433 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-couch 2433-download-views Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit 175edbb895dcf335151c601bcca67c39f2fc2601 Author: Robert Kowalski Date: 2015-03-29T18:40:00Z allow downloading docs/views this enables downloading of views, e.g. via a button in Fauxton. api: http://localhost:5984/mydb/_design/foobar?download=true COUCHDB-2433 > Allow downloading of views > -- > > Key: COUCHDB-2433 > URL: https://issues.apache.org/jira/browse/COUCHDB-2433 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Affects Versions: 2.0.0 >Reporter: Jan Lehnardt >Assignee: Robert Kowalski >Priority: Minor > > I have a non-technical user of CouchDB that would like a “JSON Export” of > views in Fauxton. They can’t use the command line where they can just `curl > $viewurl > export.json`. > One way to implement this is add a new query parameter to view queries could > be `/db/_design/_view/name?download=true` which adds a Content-Disposition > header so browsers offer the link as a download (and whatever else is > necessary to make browsers behave :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2433) Allow downloading of views
[ https://issues.apache.org/jira/browse/COUCHDB-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385882#comment-14385882 ] ASF GitHub Bot commented on COUCHDB-2433: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb/pull/310 add tests for downloading docs/views COUCHDB-2433 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb 2433-download-views Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #310 commit ac46e5599c4cec3b4d8fb0c0a2ce8f6e2cfbf5e0 Author: Robert Kowalski Date: 2015-03-29T18:34:52Z add tests for downloading docs/views COUCHDB-2433 > Allow downloading of views > -- > > Key: COUCHDB-2433 > URL: https://issues.apache.org/jira/browse/COUCHDB-2433 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Affects Versions: 2.0.0 >Reporter: Jan Lehnardt >Assignee: Robert Kowalski >Priority: Minor > > I have a non-technical user of CouchDB that would like a “JSON Export” of > views in Fauxton. They can’t use the command line where they can just `curl > $viewurl > export.json`. > One way to implement this is add a new query parameter to view queries could > be `/db/_design/_view/name?download=true` which adds a Content-Disposition > header so browsers offer the link as a download (and whatever else is > necessary to make browsers behave :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2154) Scrollbar is overlapped by action bar in Chrome for views page
[ https://issues.apache.org/jira/browse/COUCHDB-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385881#comment-14385881 ] ASF GitHub Bot commented on COUCHDB-2154: - Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb/pull/176#issuecomment-87454376 this is fixed on fauxton's master @baweaver can you close the PR, we can't do it on our own > Scrollbar is overlapped by action bar in Chrome for views page > -- > > Key: COUCHDB-2154 > URL: https://issues.apache.org/jira/browse/COUCHDB-2154 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Alexander Shorin > Attachments: COUCHDB-2154-chrome-scrollbar-bug.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385394#comment-14385394 ] ASF GitHub Bot commented on COUCHDB-2237: - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb/pull/307 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey >Assignee: Robert Kowalski > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385392#comment-14385392 ] ASF GitHub Bot commented on COUCHDB-2237: - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/28 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey >Assignee: Robert Kowalski > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385393#comment-14385393 ] ASF GitHub Bot commented on COUCHDB-2237: - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-couch/pull/40 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey >Assignee: Robert Kowalski > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2552) unknown metric: [couchdb,mrview,map_docs]
[ https://issues.apache.org/jira/browse/COUCHDB-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381775#comment-14381775 ] ASF GitHub Bot commented on COUCHDB-2552: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch-mrview/pull/14 > unknown metric: [couchdb,mrview,map_docs] > - > > Key: COUCHDB-2552 > URL: https://issues.apache.org/jira/browse/COUCHDB-2552 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > There is a typo in priv/stats_descriptions.cfg of mrview app. It contains > definition of map_doc metric which should be map_docs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2646) Page displays blank when trying to access broken view index
[ https://issues.apache.org/jira/browse/COUCHDB-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381508#comment-14381508 ] ASF GitHub Bot commented on COUCHDB-2646: - Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/334 > Page displays blank when trying to access broken view index > --- > > Key: COUCHDB-2646 > URL: https://issues.apache.org/jira/browse/COUCHDB-2646 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Garren Smith > > When a user tries to access a view via the database menu (see attached > screenshot) and the view is broken and won't index, trying to access it > results in a blank page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-404) restfull and shorter urls for lists and shows
[ https://issues.apache.org/jira/browse/COUCHDB-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380970#comment-14380970 ] ASF GitHub Bot commented on COUCHDB-404: Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-mrview/pull/5 > restfull and shorter urls for lists and shows > - > > Key: COUCHDB-404 > URL: https://issues.apache.org/jira/browse/COUCHDB-404 > Project: CouchDB > Issue Type: Improvement > Components: HTTP Interface >Affects Versions: 0.10 > Environment: * >Reporter: Benoit Chesneau > Attachments: formuri.diff > > > We discussing yesterday with @jchris and @jasondavies about shortening > shows and lists urls and we arrived on this format : > /db/docid?show=dname/showname > /db/_view/dname/vname?list=listname > This change is very usefull since it allows shorter urls and I think > it's more RESTFul. I had time this morning to write this and I created > a branch on my github repository : > http://github.com/benoitc/couchdb/tree/formuri > To do this I refactored a little couch_httpd_show to reuse code to > display lists and shows and added URL parameters parsing/validation. > All changes made in this branch don't break current CouchDB behavior > so : > * Views are available on > /db/_design/designame/_view/viewname (current behavior) but also on > /db/_view/designame/viewname > * Lists are available on > /db/_design/designame/_list/listname/viewname (current behavior) > but also on > /db/_view/designame/viewname?list=listname > * Shows are available on > /db/_design/designame/_show/showname/docid > but also on > /db/docid?show=designame/showname -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2646) Page displays blank when trying to access broken view index
[ https://issues.apache.org/jira/browse/COUCHDB-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379678#comment-14379678 ] ASF GitHub Bot commented on COUCHDB-2646: - GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/334 Display view error if view is broken If a user saves a view that doesn't work the error will be displayed on to the user and the page will load. This fixes COUCHDB-2646 You can merge this pull request into a Git repository by running: $ git pull https://github.com/garrensmith/couchdb-fauxton fix-view-load Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #334 commit 8e86818c55d31ede75bbbe829b9ce8294f29cecf Author: Garren Smith Date: 2015-03-25T10:26:11Z Display view error if view is broken If a user saves a view that doesn't work the error will be displayed on to the user and the page will load. This fixes COUCHDB-2646 > Page displays blank when trying to access broken view index > --- > > Key: COUCHDB-2646 > URL: https://issues.apache.org/jira/browse/COUCHDB-2646 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Garren Smith > > When a user tries to access a view via the database menu (see attached > screenshot) and the view is broken and won't index, trying to access it > results in a blank page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2577) Invalid 'undefined' class in All Docs header button element
[ https://issues.apache.org/jira/browse/COUCHDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378491#comment-14378491 ] ASF GitHub Bot commented on COUCHDB-2577: - GitHub user wadsashika opened a pull request: https://github.com/apache/couchdb-fauxton/pull/332 Invalid 'undefined' class in All Docs header button element This will remove the invalid class named undefined which appear in the All Doc header button element when landing the page. Closes COUCHDB-2577 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wadsashika/couchdb-fauxton 2577-Invalid-undifined-class-in-All-Docs-header-button-element Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #332 commit ac1e525139964cf595f313be0c9c5d8a04a9ffc6 Author: Dulanga Sashika Date: 2015-03-24T20:07:47Z Invalid 'undefined' class in All Docs header button element This will remove the invalid class named undefined which appear in the All Doc header button element when landing the page. Closes COUCHDB-2577 > Invalid 'undefined' class in All Docs header button element > --- > > Key: COUCHDB-2577 > URL: https://issues.apache.org/jira/browse/COUCHDB-2577 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen > Attachments: Screen Shot 2015-02-11 at 8.08.19 AM.png > > > Super minor thing. > View source on the "Select" item in the All Docs page header. There's an > "undefined" class on the button.control-toggle-alternative-header element > (screenshot attached). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2583) ensure_full_commit requires empty but typed content or it will unexpectedly drops the connection
[
https://issues.apache.org/jira/browse/COUCHDB-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377516#comment-14377516
]
ASF GitHub Bot commented on COUCHDB-2583:
-
Github user samueltardieu closed the pull request at:
https://github.com/apache/couchdb/pull/304
> ensure_full_commit requires empty but typed content or it will unexpectedly
> drops the connection
>
>
> Key: COUCHDB-2583
> URL: https://issues.apache.org/jira/browse/COUCHDB-2583
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
> Fix For: 2.0.0, 1.7.0
>
> Attachments: 0001-Consume-JSON-body-even-if-ignored.patch
>
>
> When given an non-empty (but valid) JSON content, some methods such as
> {{_ensure_full_commit}} will abruptly drop a persistent connection instead of
> waiting for a new HTTP request even though no error is signaled in CouchDB
> logs:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Type: application/json
> Content-Length: 2
> {}
> {code}
> {code:title=Response}
> HTTP/1.1 201 Created
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:49:11 GMT
> Content-Type: application/json
> Content-Length: 53
> Cache-Control: must-revalidate
> {"ok":true,"instance_start_time":"1424085277160411"}
> {code}
> [connection is closed without warning by CouchDB at this point]
> To remedy that, one could try to give an empty content, but some frameworks
> (such as spray.io) will systematically omit the {{Content-Type}} header in
> this case since it makes little sense to type empty content. However, CouchDB
> will reject the request even though it does *not* want any content:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Length: 0
> {code}
> {code:title=Response}
> HTTP/1.1 415 Unsupported Media Type
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:55:52 GMT
> Content-Type: application/json
> Content-Length: 78
> Cache-Control: must-revalidate
> {"error":"bad_content_type","reason":"Content-Type must be application/json"}
> {code}
> This makes it impossible to use those methods with such frameworks. CouchDB
> should not drop the connection and ignore the data if {{Content-Length}} is
> not 0, nor require that data be typed with {{application/json}} if it is
> going to ignore it anyway or if it requires it to be empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2577) Invalid 'undefined' class in All Docs header button element
[ https://issues.apache.org/jira/browse/COUCHDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377442#comment-14377442 ] ASF GitHub Bot commented on COUCHDB-2577: - Github user wadsashika closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/329 > Invalid 'undefined' class in All Docs header button element > --- > > Key: COUCHDB-2577 > URL: https://issues.apache.org/jira/browse/COUCHDB-2577 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen > Attachments: Screen Shot 2015-02-11 at 8.08.19 AM.png > > > Super minor thing. > View source on the "Select" item in the All Docs page header. There's an > "undefined" class on the button.control-toggle-alternative-header element > (screenshot attached). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-1415) Re-insering a document silently fails after compact is executed
[
https://issues.apache.org/jira/browse/COUCHDB-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376956#comment-14376956
]
ASF GitHub Bot commented on COUCHDB-1415:
-
Github user davisp commented on the pull request:
https://github.com/apache/couchdb/pull/98#issuecomment-85254598
I'm pretty sure the underlying bug is fixed in 2.0. Might want to revisit
the docs on this.
> Re-insering a document silently fails after compact is executed
> ---
>
> Key: COUCHDB-1415
> URL: https://issues.apache.org/jira/browse/COUCHDB-1415
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
>Affects Versions: 1.1.1
> Environment: Tested on multiple linux platforms
>Reporter: Viktor Szabo
>Assignee: Paul Joseph Davis
> Fix For: 2.0.0
>
> Attachments: patch
>
>
> When a document is re-inserted after a compact operation using the same
> contents it was originally created, the insert operation is silently ignored,
> leaving the client unaware of the fact it's document is not available in the
> database.
> Can be reproduced using the following sequence of steps:
> alias curl='curl -H "Content-Type: application/json"'
> url="http://localhost:5984/database";
> 1 curl -X PUT $url
> 2 curl -X POST $url -d '{"_id": "bug", "key": "value"}'
> 3 curl -X DELETE "$url/bug?rev=1-59414e77c768bc202142ac82c2f129de"
> 4 curl -X POST "$url/_compact"
> 5 curl -X POST $url -d '{"_id": "bug", "key": "value"}'
> 6 curl -X GET "$url/bug"
> (bug here)
> 1 {"ok":true}
> 201
> 2 [{"ok":true,"id":"bug","rev":"1-59414e77c768bc202142ac82c2f129de"}]
> 201
> 3 {"ok":true,"id":"bug","rev":"2-9b2e3bcc3752a3a952a3570b2ed4d27e"}
> 200
> 4 {"ok":true}
> 202
> 5 [{"ok":true,"id":"bug","rev":"1-59414e77c768bc202142ac82c2f129de"}]
> 201
> 6 {"error":"not_found","reason":"deleted"}
> 404
> CouchDB shouldn't report "ok" on step 5 and then go on to claim that the doc
> is deleted. Also, it seems to work on second try:
> 7 curl -X POST $url -d '{"_id": "bug", "key": "value"}'
> 8 curl -X GET "$url/bug"
> 7 {"ok":true,"id":"bug","rev":"3-674f864b73df1c80925e48436e21d550"}
> 201
> 8 {"_id":"bug","_rev":"3-674f864b73df1c80925e48436e21d550","key":"value"}
> 200
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-1438) GET /// triggers a 500 error
[
https://issues.apache.org/jira/browse/COUCHDB-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376955#comment-14376955
]
ASF GitHub Bot commented on COUCHDB-1438:
-
Github user davisp commented on the pull request:
https://github.com/apache/couchdb/pull/122#issuecomment-85254157
Its fixed on the clustered interface though we'll may want to port this to
the couch_httpd.erl in couchdb-couch.git
> GET /// triggers a 500 error
>
>
> Key: COUCHDB-1438
> URL: https://issues.apache.org/jira/browse/COUCHDB-1438
> Project: CouchDB
> Issue Type: Bug
> Components: HTTP Interface
>Affects Versions: 1.2
>Reporter: Jason Smith
>Assignee: Jason Smith
>Priority: Minor
> Labels: http
>
> I just noticed this.
> $ curl -i http://localhost:5984//
> HTTP/1.1 500 Internal Server Error
> Server: CouchDB/1.2.0 (Erlang OTP/R15B)
> Date: Tue, 13 Mar 2012 08:48:46 GMT
> Content-Type: text/plain; charset=utf-8
> Content-Length: 53
> Cache-Control: must-revalidate
> {"error":"unknown_error","reason":"function_clause"}
> That's weird. Usually CouchDB strips trailing slashes:
> $ curl http://localhost:5984/x/
> {"db_name":"x","doc_count":1,...}
> $ curl http://localhost:5984/x/blah/
> {"_id":"blah","_rev":"2-6c4b3bc6c2fdc5043139942dc6f1b994","_attachments":{"out.txt"
> ...
> $ curl http://localhost:5984/x/blahout.txt///
> Hello, world!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2577) Invalid 'undefined' class in All Docs header button element
[ https://issues.apache.org/jira/browse/COUCHDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376671#comment-14376671 ] ASF GitHub Bot commented on COUCHDB-2577: - GitHub user wadsashika opened a pull request: https://github.com/apache/couchdb-fauxton/pull/329 Invalid 'undefined' class in All Docs header button element This remove the invalide undefined class in select button of All Docs header which appear when landing the page Closes COUCHDB-2577 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wadsashika/couchdb-fauxton 2577-Invalid-undifined-class-in-All-Docs-header-button-element Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #329 commit c24a4e4b64affb24b78e44a40e2105c484f5de01 Author: Dulanga Sashika Date: 2015-03-23T21:20:37Z Invalid 'undefined' class in All Docs header button element This remove the invalide undefined class in select button of All Docs header which appear when landing the page Closes COUCHDB-2577 > Invalid 'undefined' class in All Docs header button element > --- > > Key: COUCHDB-2577 > URL: https://issues.apache.org/jira/browse/COUCHDB-2577 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen > Attachments: Screen Shot 2015-02-11 at 8.08.19 AM.png > > > Super minor thing. > View source on the "Select" item in the All Docs page header. There's an > "undefined" class on the button.control-toggle-alternative-header element > (screenshot attached). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2635) Replace hardcoded list of systems dbs with registration approach
[ https://issues.apache.org/jira/browse/COUCHDB-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355922#comment-14355922 ] ASF GitHub Bot commented on COUCHDB-2635: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-fabric/pull/19 Use `couch_db:before_doc_update/2` COUCHDB-2635 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-fabric 2635-systems_dbs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fabric/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit de71221e297ccaf0e2f3541a9ac3a4f8f1081ca2 Author: ILYA Khlopotov Date: 2015-03-10T22:56:13Z Use `couch_db:before_doc_update/2` COUCHDB-2635 > Replace hardcoded list of systems dbs with registration approach > > > Key: COUCHDB-2635 > URL: https://issues.apache.org/jira/browse/COUCHDB-2635 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) >Reporter: ILYA >Assignee: ILYA > > To replace this > https://github.com/apache/couchdb-couch/blob/master/include/couch_db.hrl#L43:L49 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2635) Replace hardcoded list of systems dbs with registration approach
[ https://issues.apache.org/jira/browse/COUCHDB-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355920#comment-14355920 ] ASF GitHub Bot commented on COUCHDB-2635: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/9 Implement `couch_define_db` behaviour COUCHDB-2635 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch-replicator 2635-systems_dbs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 0b01dcc6a06b7c41e8786dc8bdfb0bfb1fb57c71 Author: ILYA Khlopotov Date: 2015-03-10T22:39:38Z Implement `couch_define_db` behaviour COUCHDB-2635 > Replace hardcoded list of systems dbs with registration approach > > > Key: COUCHDB-2635 > URL: https://issues.apache.org/jira/browse/COUCHDB-2635 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) >Reporter: ILYA >Assignee: ILYA > > To replace this > https://github.com/apache/couchdb-couch/blob/master/include/couch_db.hrl#L43:L49 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2635) Replace hardcoded list of systems dbs with registration approach
[ https://issues.apache.org/jira/browse/COUCHDB-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355911#comment-14355911 ] ASF GitHub Bot commented on COUCHDB-2635: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-mem3/pull/7 Implement `couch_define_db` behaviour COUCHDB-2635 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-mem3 2635-systems_dbs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-mem3/pull/7.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7 commit cfdc743501c81a3f346919a100da5d1c1eb25fdb Author: ILYA Khlopotov Date: 2015-03-10T23:01:30Z Implement `couch_define_db` behaviour COUCHDB-2635 > Replace hardcoded list of systems dbs with registration approach > > > Key: COUCHDB-2635 > URL: https://issues.apache.org/jira/browse/COUCHDB-2635 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) >Reporter: ILYA >Assignee: ILYA > > To replace this > https://github.com/apache/couchdb-couch/blob/master/include/couch_db.hrl#L43:L49 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2635) Replace hardcoded list of systems dbs with registration approach
[ https://issues.apache.org/jira/browse/COUCHDB-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355910#comment-14355910 ] ASF GitHub Bot commented on COUCHDB-2635: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb/pull/309 Configure `db_definitions` key in config COUCHDB-2635 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb 2635-systems_dbs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/309.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #309 commit 4bdab2e69b4934938b0610a8b188dbe7a6acfc09 Author: ILYA Khlopotov Date: 2015-03-10T23:13:48Z Configure `db_definitions` key in config COUCHDB-2635 > Replace hardcoded list of systems dbs with registration approach > > > Key: COUCHDB-2635 > URL: https://issues.apache.org/jira/browse/COUCHDB-2635 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) >Reporter: ILYA >Assignee: ILYA > > To replace this > https://github.com/apache/couchdb-couch/blob/master/include/couch_db.hrl#L43:L49 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2576) All Docs header shouldn't appear on Changes page
[ https://issues.apache.org/jira/browse/COUCHDB-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353165#comment-14353165 ] ASF GitHub Bot commented on COUCHDB-2576: - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/304 > All Docs header shouldn't appear on Changes page > > > Key: COUCHDB-2576 > URL: https://issues.apache.org/jira/browse/COUCHDB-2576 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Robert Kowalski > > To reproduce: > - go to the All Docs page & see the new header (with the "Select" button) > - go to the Changes page. > Result: the "Select" section of the header still appears. It should be gone. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2562) Wrong Content-Type for continuous changes feed
[ https://issues.apache.org/jira/browse/COUCHDB-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350662#comment-14350662 ] ASF GitHub Bot commented on COUCHDB-2562: - Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/40#issuecomment-77608180 +1 in general. Btw, in light of [COUCHDB-2562](https://issues.apache.org/jira/browse/COUCHDB-2562) how do you feel is "stream" feed type is good one or there could be something better? > Wrong Content-Type for continuous changes feed > -- > > Key: COUCHDB-2562 > URL: https://issues.apache.org/jira/browse/COUCHDB-2562 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) >Reporter: Nathan Vander Wilt > > When a client requests a continuous changes feed and includes an "Accept: > application/json" header, the response comes back as "Content-Type: > application/json" even though the content is not parseable as JSON. > I think the proper thing to do in this specific case is to respond with "406 > Not Acceptable", or if this is considered too extreme and HTTP allows it, > proceed anyway but claim "Content-Type: application/x-ldjson" instead (see > http://en.wikipedia.org/wiki/Line_Delimited_JSON#MIME_Type_and_File_Extensions). > This is an issue that some acknowledged as a bug during the discussion on > https://issues.apache.org/jira/browse/COUCHDB-604 but didn't get its own > ticket. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2572) Pagination broken
[ https://issues.apache.org/jira/browse/COUCHDB-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346887#comment-14346887 ] ASF GitHub Bot commented on COUCHDB-2572: - Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/301#issuecomment-77159942 fixes: https://issues.apache.org/jira/browse/COUCHDB-2572 :) > Pagination broken > - > > Key: COUCHDB-2572 > URL: https://issues.apache.org/jira/browse/COUCHDB-2572 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Robert Kowalski > > - Choose a high number of documents, e.g. 100 documents > - go back to 5 > You will get an error and the screen will freeze -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2216) Changes table: Performance issue with larger databases
[ https://issues.apache.org/jira/browse/COUCHDB-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346851#comment-14346851 ] ASF GitHub Bot commented on COUCHDB-2216: - Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/303#issuecomment-77153918 Commit message is missing that it also limit the number of changes to 1000 which closes COUCHDB-2216 > Changes table: Performance issue with larger databases > -- > > Key: COUCHDB-2216 > URL: https://issues.apache.org/jira/browse/COUCHDB-2216 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Robert Kowalski >Assignee: Ben Keen > > Replicate a larger DB, e.g. https://skimdb.npmjs.com/ (around 250 MB JSON > with ~65000 docs) > Go to Database -> Changes > Screen/Browsertab freezes (Chrome & Firefox) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2576) All Docs header shouldn't appear on Changes page
[ https://issues.apache.org/jira/browse/COUCHDB-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346831#comment-14346831 ] ASF GitHub Bot commented on COUCHDB-2576: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/304 remove select-all button on changes view closes COUCHDB-2576 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton 2216-select-all-changes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #304 commit af56c85e5985269964eff8129732040789ac5c3f Author: Robert Kowalski Date: 2015-03-04T12:29:17Z remove select-all button on changes view closes COUCHDB-2576 > All Docs header shouldn't appear on Changes page > > > Key: COUCHDB-2576 > URL: https://issues.apache.org/jira/browse/COUCHDB-2576 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Robert Kowalski > > To reproduce: > - go to the All Docs page & see the new header (with the "Select" button) > - go to the Changes page. > Result: the "Select" section of the header still appears. It should be gone. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2193) Invalid pagination when page size equals limit
[ https://issues.apache.org/jira/browse/COUCHDB-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345174#comment-14345174 ] ASF GitHub Bot commented on COUCHDB-2193: - Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/301#issuecomment-76960458 This fixes COUCHDB-2193 > Invalid pagination when page size equals limit > -- > > Key: COUCHDB-2193 > URL: https://issues.apache.org/jira/browse/COUCHDB-2193 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Alexander Shorin >Assignee: Garren Smith > Labels: advanced > > 1. Navigate to any view page which has more than 100 or 1 results > 2. Set view limit and page size as 20. Notice that Fauxton reports you > "Showing 1 - 20" > 3. Scroll down to the page bottom - notice that you're able to more on the > second page... > 4. ...where you'll see "Showing 0 documents. Create your first document." > message > 5. Click on "Previous" button > 6. Notice current report: "Showing 100 - 119" > If you have 1+ results for this view repeat steps 3-5 - you'll get new > report: "Showing 1 - 10019" > Also notice, that now "Previous" button on the page bottom is active, but > nothing happens if you click it. > Fauxton @ > [adf9ae2|https://git-wip-us.apache.org/repos/asf?p=couchdb.git;a=commit;h=adf9ae25c6be1c654fededfc72350b48abfda1de] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2607) Gracefully handle _stats request failure
[
https://issues.apache.org/jira/browse/COUCHDB-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345062#comment-14345062
]
ASF GitHub Bot commented on COUCHDB-2607:
-
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/299
> Gracefully handle _stats request failure
>
>
> Key: COUCHDB-2607
> URL: https://issues.apache.org/jira/browse/COUCHDB-2607
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
>Reporter: Alexander Shorin
>Assignee: Robert Kowalski
>
> {{_stats}} resource isn't available from cluster interface. But on browsing
> all documents page Fauxton makes a request to {{_stats}} and after receiving
> {{HTTP 404 Not Found}} response proudly reports that database doesn't exists
> and refuses to render inner sidebar elements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2607) Gracefully handle _stats request failure
[
https://issues.apache.org/jira/browse/COUCHDB-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343456#comment-14343456
]
ASF GitHub Bot commented on COUCHDB-2607:
-
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/299
Detect system databases on _
All system databases are now prefixed by `_`, so we can remove
a lot of detection logic.
Additionally colored the warning in red.
closes COUCHDB-2607
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton
COUCHDB-2607-is-system-db
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
commit c2646568418c5bffbe659f3b4f24d70c4258a245
Author: Robert Kowalski
Date: 2015-03-02T17:43:00Z
Detect system databases on _
All system databases are now prefixed by `_`, so we can remove
a lot of detection logic.
Additionally colored the warning in red.
closes COUCHDB-2607
> Gracefully handle _stats request failure
>
>
> Key: COUCHDB-2607
> URL: https://issues.apache.org/jira/browse/COUCHDB-2607
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
>Reporter: Alexander Shorin
>
> {{_stats}} resource isn't available from cluster interface. But on browsing
> all documents page Fauxton makes a request to {{_stats}} and after receiving
> {{HTTP 404 Not Found}} response proudly reports that database doesn't exists
> and refuses to render inner sidebar elements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342260#comment-14342260 ] ASF GitHub Bot commented on COUCHDB-2237: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-couch/pull/40 add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. closes COUCHDB-2237 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-couch 2237-stream Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit f9eaa6ab2b9b6e748ce8a55c05c8944c0cad8034 Author: Robert Kowalski Date: 2015-03-01T14:44:25Z add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. closes COUCHDB-2237 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey >Assignee: Robert Kowalski > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342262#comment-14342262 ] ASF GitHub Bot commented on COUCHDB-2237: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb/pull/307 add test for _changes?feed=stream COUCHDB-2237 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb 2237-stream Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/307.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #307 commit b63900e7942e7f8f67a69ce5e4c99cea2f2191ac Author: Robert Kowalski Date: 2015-03-01T14:40:51Z add test for _changes?feed=stream COUCHDB-2237 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey >Assignee: Robert Kowalski > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2237) Add a 'live' sugar for 'continuous'
[ https://issues.apache.org/jira/browse/COUCHDB-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342259#comment-14342259 ] ASF GitHub Bot commented on COUCHDB-2237: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-chttpd/pull/28 add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. closes COUCHDB-2237 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-chttpd 2237-stream Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 53b35d9977c8a3947b6ca51d2826adf0892bfe5c Author: Robert Kowalski Date: 2015-03-01T14:42:24Z add _changes?feed=stream sugar for continuous allow `feed=stream` as sugar for `continuous` which is hard to type. closes COUCHDB-2237 > Add a 'live' sugar for 'continuous' > --- > > Key: COUCHDB-2237 > URL: https://issues.apache.org/jira/browse/COUCHDB-2237 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: HTTP Interface >Reporter: Dale Harvey >Assignee: Robert Kowalski > > With PouchDB we generally try to stick to the same param names as Couch, we > are even changing some we implemented first to be compatible > (https://github.com/pouchdb/pouchdb/issues/2193) > However 'continuous' sucks to type, its confusing to type and spell and > everyone gets it wrong, we still support it but switched to documenting it as > 'live' and life is awesome again -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2619) Make all system databases start with underscore
[ https://issues.apache.org/jira/browse/COUCHDB-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1434#comment-1434 ] ASF GitHub Bot commented on COUCHDB-2619: - Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-76597305 @Poltergeist [COUCHDB-2619](https://issues.apache.org/jira/browse/COUCHDB-2619) fixed so all system databases are starts with underscore no matter on which iface they are. Could you please submit new PR? I'd tried by my own, but I don't understand what is going on in `IsSystemDatabaseModel`, why there is need to request `_stats` (which I strongly believe causes [COUCHDB-2607](https://issues.apache.org/jira/browse/COUCHDB-2607) ) when you could just GET app.host and look if uuid is in the response and how to turn it into simple property of Database model without ruining everything. Thanks (: > Make all system databases start with underscore > --- > > Key: COUCHDB-2619 > URL: https://issues.apache.org/jira/browse/COUCHDB-2619 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Database Core >Reporter: Alexander Shorin >Assignee: Alexander Shorin > Fix For: 2.0.0 > > > With 2.0 here comes three new system databases: dbs, nodes and cassim. They > need to have underscore in prefix as like as _users and _replicator has to > explicitly denote them from user databases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2585) Make admin check extensible in global_change
[ https://issues.apache.org/jira/browse/COUCHDB-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340216#comment-14340216 ] ASF GitHub Bot commented on COUCHDB-2585: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/37 > Make admin check extensible in global_change > > > Key: COUCHDB-2585 > URL: https://issues.apache.org/jira/browse/COUCHDB-2585 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > Currently there is no way to use different user here > https://github.com/apache/couchdb-global-changes/blob/master/src/global_changes_httpd.erl#L46 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2569) CORS CSS
[ https://issues.apache.org/jira/browse/COUCHDB-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340142#comment-14340142 ] ASF GitHub Bot commented on COUCHDB-2569: - Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/264 > CORS CSS > > > Key: COUCHDB-2569 > URL: https://issues.apache.org/jira/browse/COUCHDB-2569 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Michelle Phung >Priority: Minor > > Currently CORS is working. Some additional CSS could be useful. > This proposal is to allow: > - the 'update' input field for editing a domain name, to automatically > resize and doesn't overlaps the pencil/trashcan buttons > - users to hit 'enter' to validate and submit the 'Update' domain and > 'Add' domain fields > - page to not return an empty origin, if "specific origins" is set, but > there are no domains on that list > - CSS changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2625) Make customizable dbname_validator
[ https://issues.apache.org/jira/browse/COUCHDB-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336897#comment-14336897 ] ASF GitHub Bot commented on COUCHDB-2625: - Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/38#issuecomment-76021117 I found the related ticket: https://issues.apache.org/jira/browse/COUCHDB-2625 — It doesn’t answer my question though > Make customizable dbname_validator > --- > > Key: COUCHDB-2625 > URL: https://issues.apache.org/jira/browse/COUCHDB-2625 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > Currently allowed databases names are either should match regexp or hardcoded > list of internal databases like _users or _replicator. Which make it hard to > customize without modifying source code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2625) Make customizable dbname_validator
[ https://issues.apache.org/jira/browse/COUCHDB-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336895#comment-14336895 ] ASF GitHub Bot commented on COUCHDB-2625: - Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/37#issuecomment-76020970 Ah, found it, https://issues.apache.org/jira/browse/COUCHDB-2625 was probably meant as a reference. > Make customizable dbname_validator > --- > > Key: COUCHDB-2625 > URL: https://issues.apache.org/jira/browse/COUCHDB-2625 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > Currently allowed databases names are either should match regexp or hardcoded > list of internal databases like _users or _replicator. Which make it hard to > customize without modifying source code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2585) Make admin check extensible in global_change
[ https://issues.apache.org/jira/browse/COUCHDB-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336884#comment-14336884 ] ASF GitHub Bot commented on COUCHDB-2585: - Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/37#issuecomment-76019963 how is this related to https://issues.apache.org/jira/browse/COUCHDB-2585? > Make admin check extensible in global_change > > > Key: COUCHDB-2585 > URL: https://issues.apache.org/jira/browse/COUCHDB-2585 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > Currently there is no way to use different user here > https://github.com/apache/couchdb-global-changes/blob/master/src/global_changes_httpd.erl#L46 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2585) Make admin check extensible in global_change
[ https://issues.apache.org/jira/browse/COUCHDB-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336879#comment-14336879 ] ASF GitHub Bot commented on COUCHDB-2585: - Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/38#issuecomment-76019644 I’m with @kxepal: sceptical about the usefulness of letting the end user define how to validate database names. I’m not sure what problem this solves. The referenced issue in #37 (https://issues.apache.org/jira/browse/COUCHDB-2585) is about something else. > Make admin check extensible in global_change > > > Key: COUCHDB-2585 > URL: https://issues.apache.org/jira/browse/COUCHDB-2585 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > Currently there is no way to use different user here > https://github.com/apache/couchdb-global-changes/blob/master/src/global_changes_httpd.erl#L46 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2625) Make customizable dbname_validator
[ https://issues.apache.org/jira/browse/COUCHDB-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336736#comment-14336736 ] ASF GitHub Bot commented on COUCHDB-2625: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-fabric/pull/14 Use couch_db:validate_dbname COUCHDB-2625 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-fabric 2625-dbname_validator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fabric/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 8cdaea804687933b532d21e1991deda72baf4260 Author: ILYA Khlopotov Date: 2015-02-25T16:33:22Z Use couch_db:validate_dbname COUCHDB-2625 > Make customizable dbname_validator > --- > > Key: COUCHDB-2625 > URL: https://issues.apache.org/jira/browse/COUCHDB-2625 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > Currently allowed databases names are either should match regexp or hardcoded > list of internal databases like _users or _replicator. Which make it hard to > customize without modifying source code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2625) Make customizable dbname_validator
[
https://issues.apache.org/jira/browse/COUCHDB-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336734#comment-14336734
]
ASF GitHub Bot commented on COUCHDB-2625:
-
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/26
Return {error, Reason} for illegal_database_name
COUCHDB-2625
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-chttpd 2625-dbname_validator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
commit 6d98bf5545adabdc9dd5fb21440fd5f341e94205
Author: ILYA Khlopotov
Date: 2015-02-25T16:35:11Z
Return {error, Reason} for illegal_database_name
COUCHDB-2625
> Make customizable dbname_validator
> ---
>
> Key: COUCHDB-2625
> URL: https://issues.apache.org/jira/browse/COUCHDB-2625
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Database Core
>Reporter: ILYA
>Assignee: ILYA
>
> Currently allowed databases names are either should match regexp or hardcoded
> list of internal databases like _users or _replicator. Which make it hard to
> customize without modifying source code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2587) URI encode unicode chars in db typeahead
[ https://issues.apache.org/jira/browse/COUCHDB-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336649#comment-14336649 ] ASF GitHub Bot commented on COUCHDB-2587: - Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/274 > URI encode unicode chars in db typeahead > > > Key: COUCHDB-2587 > URL: https://issues.apache.org/jira/browse/COUCHDB-2587 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Encode the \u unicode char in the db search typeahead component. > N.B. This doesn't cause any errors on Fauxton right now, but if the params > were read by the server it would cause an error on IE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2585) Make admin check extensible in global_change
[ https://issues.apache.org/jira/browse/COUCHDB-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335471#comment-14335471 ] ASF GitHub Bot commented on COUCHDB-2585: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/37 Add couch_util:validate_callback_exists COUCHDB-2585 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch 2585-allowed_owner-hook Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit f54e965b139c65799ddb18cc504e1514b33ccfb1 Author: ILYA Khlopotov Date: 2015-02-24T21:06:29Z Add couch_util:validate_callback_exists COUCHDB-2585 > Make admin check extensible in global_change > > > Key: COUCHDB-2585 > URL: https://issues.apache.org/jira/browse/COUCHDB-2585 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Database Core >Reporter: ILYA >Assignee: ILYA > > Currently there is no way to use different user here > https://github.com/apache/couchdb-global-changes/blob/master/src/global_changes_httpd.erl#L46 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2601) Config section - remove handler from chttpd
[ https://issues.apache.org/jira/browse/COUCHDB-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329007#comment-14329007 ] ASF GitHub Bot commented on COUCHDB-2601: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/25 > Config section - remove handler from chttpd > --- > > Key: COUCHDB-2601 > URL: https://issues.apache.org/jira/browse/COUCHDB-2601 > Project: CouchDB > Issue Type: Task > Security Level: public(Regular issues) > Components: Database Core, Fauxton >Reporter: Robert Kowalski >Assignee: Robert Kowalski >Priority: Blocker > > if Fauxton gets a 404 we are not using the backdoor port which still > supports `/_config` - this also solves the problem if user are using curl and > try to change configuration on a clustered CouchDB behind a LB -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2583) ensure_full_commit requires empty but typed content or it will unexpectedly drops the connection
[
https://issues.apache.org/jira/browse/COUCHDB-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328332#comment-14328332
]
ASF GitHub Bot commented on COUCHDB-2583:
-
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/36
> ensure_full_commit requires empty but typed content or it will unexpectedly
> drops the connection
>
>
> Key: COUCHDB-2583
> URL: https://issues.apache.org/jira/browse/COUCHDB-2583
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
> Attachments: 0001-Consume-JSON-body-even-if-ignored.patch
>
>
> When given an non-empty (but valid) JSON content, some methods such as
> {{_ensure_full_commit}} will abruptly drop a persistent connection instead of
> waiting for a new HTTP request even though no error is signaled in CouchDB
> logs:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Type: application/json
> Content-Length: 2
> {}
> {code}
> {code:title=Response}
> HTTP/1.1 201 Created
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:49:11 GMT
> Content-Type: application/json
> Content-Length: 53
> Cache-Control: must-revalidate
> {"ok":true,"instance_start_time":"1424085277160411"}
> {code}
> [connection is closed without warning by CouchDB at this point]
> To remedy that, one could try to give an empty content, but some frameworks
> (such as spray.io) will systematically omit the {{Content-Type}} header in
> this case since it makes little sense to type empty content. However, CouchDB
> will reject the request even though it does *not* want any content:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Length: 0
> {code}
> {code:title=Response}
> HTTP/1.1 415 Unsupported Media Type
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:55:52 GMT
> Content-Type: application/json
> Content-Length: 78
> Cache-Control: must-revalidate
> {"error":"bad_content_type","reason":"Content-Type must be application/json"}
> {code}
> This makes it impossible to use those methods with such frameworks. CouchDB
> should not drop the connection and ignore the data if {{Content-Length}} is
> not 0, nor require that data be typed with {{application/json}} if it is
> going to ignore it anyway or if it requires it to be empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2601) Config section - remove handler from chttpd
[ https://issues.apache.org/jira/browse/COUCHDB-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328074#comment-14328074 ] ASF GitHub Bot commented on COUCHDB-2601: - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-chttpd/pull/25 Remove _config route on cluster In order to avoid users shooting themselves in the foot by using `/_config/` on a clustered CouchDB with a loadbalancer in front, we remove it on `15984` - it will be available for single-node- mode on the backdoor port (`15986`) or for users that are feeling lucky which want to fire curl requests to every node. It also allows Fauxton to detect if it is running on a the backdoor port. Fauxton will - if it gets a 200 instead of a 404 - show the config-section to the user. COUCHDB-2601 COUCHDB-2390 COUCHDB-2343 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-chttpd 2601-remove-config-handler Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 2a583cb0dfcd446ae259b272acd58068079c9b52 Author: Robert Kowalski Date: 2015-02-19T20:21:25Z Remove _config route on cluster In order to avoid users shooting themselves in the foot by using `/_config/` on a clustered CouchDB with a loadbalancer in front, we remove it on `15984` - it will be available for single-node- mode on the backdoor port (`15986`) or for users that are feeling lucky which want to fire curl requests to every node. It also allows Fauxton to detect if it is running on a the backdoor port. Fauxton will - if it gets a 200 instead of a 404 - show the config-section to the user. COUCHDB-2601 COUCHDB-2390 COUCHDB-2343 > Config section - remove handler from chttpd > --- > > Key: COUCHDB-2601 > URL: https://issues.apache.org/jira/browse/COUCHDB-2601 > Project: CouchDB > Issue Type: Task > Security Level: public(Regular issues) > Components: Database Core, Fauxton >Reporter: Robert Kowalski >Assignee: Robert Kowalski >Priority: Blocker > > if Fauxton gets a 404 we are not using the backdoor port which still > supports `/_config` - this also solves the problem if user are using curl and > try to change configuration on a clustered CouchDB behind a LB -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2583) ensure_full_commit requires empty but typed content or it will unexpectedly drops the connection
[
https://issues.apache.org/jira/browse/COUCHDB-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327127#comment-14327127
]
ASF GitHub Bot commented on COUCHDB-2583:
-
GitHub user samueltardieu opened a pull request:
https://github.com/apache/couchdb-couch/pull/36
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type
be set to "application/json". However, when some content is provided
(such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content
is read from the incoming HTTP request.
Mirrors the fix for COUCHDB-2583 in CouchDB 1.x.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samueltardieu/couchdb-couch
consume-json-body-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
commit 21bcf147f5e0b7e2ee06face3d2c7e41eae6cc6c
Author: Samuel Tardieu
Date: 2015-02-19T08:44:53Z
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type
be set to "application/json". However, when some content is provided
(such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content
is read from the incoming HTTP request.
Mirrors the fix for COUCHDB-2583 in CouchDB 1.x.
> ensure_full_commit requires empty but typed content or it will unexpectedly
> drops the connection
>
>
> Key: COUCHDB-2583
> URL: https://issues.apache.org/jira/browse/COUCHDB-2583
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
> Attachments: 0001-Consume-JSON-body-even-if-ignored.patch
>
>
> When given an non-empty (but valid) JSON content, some methods such as
> {{_ensure_full_commit}} will abruptly drop a persistent connection instead of
> waiting for a new HTTP request even though no error is signaled in CouchDB
> logs:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Type: application/json
> Content-Length: 2
> {}
> {code}
> {code:title=Response}
> HTTP/1.1 201 Created
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:49:11 GMT
> Content-Type: application/json
> Content-Length: 53
> Cache-Control: must-revalidate
> {"ok":true,"instance_start_time":"1424085277160411"}
> {code}
> [connection is closed without warning by CouchDB at this point]
> To remedy that, one could try to give an empty content, but some frameworks
> (such as spray.io) will systematically omit the {{Content-Type}} header in
> this case since it makes little sense to type empty content. However, CouchDB
> will reject the request even though it does *not* want any content:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Length: 0
> {code}
> {code:title=Response}
> HTTP/1.1 415 Unsupported Media Type
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:55:52 GMT
> Content-Type: application/json
> Content-Length: 78
> Cache-Control: must-revalidate
> {"error":"bad_content_type","reason":"Content-Type must be application/json"}
> {code}
> This makes it impossible to use those methods with such frameworks. CouchDB
> should not drop the connection and ignore the data if {{Content-Length}} is
> not 0, nor require that data be typed with {{application/json}} if it is
> going to ignore it anyway or if it requires it to be empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2583) ensure_full_commit requires empty but typed content or it will unexpectedly drops the connection
[
https://issues.apache.org/jira/browse/COUCHDB-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327122#comment-14327122
]
ASF GitHub Bot commented on COUCHDB-2583:
-
GitHub user samueltardieu opened a pull request:
https://github.com/apache/couchdb/pull/304
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type
be set to "application/json". However, when some content is provided
(such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content
is read from the incoming HTTP request.
Fixes COUCHDB-2583
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samueltardieu/couchdb consume-json-body
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
commit 220aba4c2bbd42045c994fd61c1757184e0ff59d
Author: Samuel Tardieu
Date: 2015-02-16T13:17:10Z
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type
be set to "application/json". However, when some content is provided
(such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content
is read from the incoming HTTP request.
Fixes COUCHDB-2583
> ensure_full_commit requires empty but typed content or it will unexpectedly
> drops the connection
>
>
> Key: COUCHDB-2583
> URL: https://issues.apache.org/jira/browse/COUCHDB-2583
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
> Attachments: 0001-Consume-JSON-body-even-if-ignored.patch
>
>
> When given an non-empty (but valid) JSON content, some methods such as
> {{_ensure_full_commit}} will abruptly drop a persistent connection instead of
> waiting for a new HTTP request even though no error is signaled in CouchDB
> logs:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Type: application/json
> Content-Length: 2
> {}
> {code}
> {code:title=Response}
> HTTP/1.1 201 Created
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:49:11 GMT
> Content-Type: application/json
> Content-Length: 53
> Cache-Control: must-revalidate
> {"ok":true,"instance_start_time":"1424085277160411"}
> {code}
> [connection is closed without warning by CouchDB at this point]
> To remedy that, one could try to give an empty content, but some frameworks
> (such as spray.io) will systematically omit the {{Content-Type}} header in
> this case since it makes little sense to type empty content. However, CouchDB
> will reject the request even though it does *not* want any content:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Length: 0
> {code}
> {code:title=Response}
> HTTP/1.1 415 Unsupported Media Type
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:55:52 GMT
> Content-Type: application/json
> Content-Length: 78
> Cache-Control: must-revalidate
> {"error":"bad_content_type","reason":"Content-Type must be application/json"}
> {code}
> This makes it impossible to use those methods with such frameworks. CouchDB
> should not drop the connection and ignore the data if {{Content-Length}} is
> not 0, nor require that data be typed with {{application/json}} if it is
> going to ignore it anyway or if it requires it to be empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2583) ensure_full_commit requires empty but typed content or it will unexpectedly drops the connection
[
https://issues.apache.org/jira/browse/COUCHDB-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327120#comment-14327120
]
ASF GitHub Bot commented on COUCHDB-2583:
-
Github user samueltardieu closed the pull request at:
https://github.com/apache/couchdb/pull/303
> ensure_full_commit requires empty but typed content or it will unexpectedly
> drops the connection
>
>
> Key: COUCHDB-2583
> URL: https://issues.apache.org/jira/browse/COUCHDB-2583
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
> Attachments: 0001-Consume-JSON-body-even-if-ignored.patch
>
>
> When given an non-empty (but valid) JSON content, some methods such as
> {{_ensure_full_commit}} will abruptly drop a persistent connection instead of
> waiting for a new HTTP request even though no error is signaled in CouchDB
> logs:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Type: application/json
> Content-Length: 2
> {}
> {code}
> {code:title=Response}
> HTTP/1.1 201 Created
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:49:11 GMT
> Content-Type: application/json
> Content-Length: 53
> Cache-Control: must-revalidate
> {"ok":true,"instance_start_time":"1424085277160411"}
> {code}
> [connection is closed without warning by CouchDB at this point]
> To remedy that, one could try to give an empty content, but some frameworks
> (such as spray.io) will systematically omit the {{Content-Type}} header in
> this case since it makes little sense to type empty content. However, CouchDB
> will reject the request even though it does *not* want any content:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Length: 0
> {code}
> {code:title=Response}
> HTTP/1.1 415 Unsupported Media Type
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:55:52 GMT
> Content-Type: application/json
> Content-Length: 78
> Cache-Control: must-revalidate
> {"error":"bad_content_type","reason":"Content-Type must be application/json"}
> {code}
> This makes it impossible to use those methods with such frameworks. CouchDB
> should not drop the connection and ignore the data if {{Content-Length}} is
> not 0, nor require that data be typed with {{application/json}} if it is
> going to ignore it anyway or if it requires it to be empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2580) Databases page doesn't update after adding new DB - IE11
[ https://issues.apache.org/jira/browse/COUCHDB-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326064#comment-14326064 ] ASF GitHub Bot commented on COUCHDB-2580: - Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/270 > Databases page doesn't update after adding new DB - IE11 > > > Key: COUCHDB-2580 > URL: https://issues.apache.org/jira/browse/COUCHDB-2580 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > After adding a database then navigating back to the databases page, the new > database doesn't get listed on the page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2587) URI encode unicode chars in db typeahead
[ https://issues.apache.org/jira/browse/COUCHDB-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324982#comment-14324982 ] ASF GitHub Bot commented on COUCHDB-2587: - GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/274 Fix for encoding unicode char Contains a small fix to ensure a unicode char in the db typeahead component is URL encoded. If the server needed to recognize the endkey parameter it would cause problems on IE. Closes COUCHDB-2587 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton 2587-typeahead-encoding-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #274 commit 4abfd6f01962d65e536a640791705487d4ee721a Author: Ben Keen Date: 2015-02-17T22:05:13Z Fix for encoding unicode char Contains a small fix to ensure a unicode char in the db typeahead component is URL encoded. If the server needed to recognize the endkey parameter it would cause problems on IE. Closes COUCHDB-2587 > URI encode unicode chars in db typeahead > > > Key: COUCHDB-2587 > URL: https://issues.apache.org/jira/browse/COUCHDB-2587 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Encode the \u unicode char in the db search typeahead component. > N.B. This doesn't cause any errors on Fauxton right now, but if the params > were read by the server it would cause an error on IE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2581) Improve tooltip for Databases page (!) icons
[ https://issues.apache.org/jira/browse/COUCHDB-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324393#comment-14324393 ] ASF GitHub Bot commented on COUCHDB-2581: - Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/271 > Improve tooltip for Databases page (!) icons > > > Key: COUCHDB-2581 > URL: https://issues.apache.org/jira/browse/COUCHDB-2581 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > Attachments: Screen Shot 2015-02-13 at 2.28.33 PM.png > > > The question mark icon that sometimes appears on the databases page has a > title, but not a corresponding tooltip() to make the tooltip appear > immediately. As such it's not very clear what the icon means. > Looking at the code, it looks like the tooltip() was just placed in the wrong > View. This ticket is just to improve the tooltip for that icon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2574) Clicking away from editor with unsaved changes should always show "do you want to save?" msg
[
https://issues.apache.org/jira/browse/COUCHDB-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324143#comment-14324143
]
ASF GitHub Bot commented on COUCHDB-2574:
-
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/267
> Clicking away from editor with unsaved changes should always show "do you
> want to save?" msg
>
>
> Key: COUCHDB-2574
> URL: https://issues.apache.org/jira/browse/COUCHDB-2574
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
>Reporter: Ben Keen
>Assignee: Ben Keen
>
> Any time the user has made changes to the content in an Ace Editor then tries
> navigating away from the page, it should confirm they don't want the
> information lost. We do this in a few places right now, but not everywhere.
> The core FauxtonAPI.navigate function checks any beforeUnload functions all
> pass prior to redirecting. The issue is that in main.js, the chief event
> delegation function running on all 's checks for the existence of a
> data-bypass attribute, but not that the attribute is set to true.
> Once we change this:
> bq. $(document).on("click", "a:not([data-bypass])", function(evt) {
> ... to this ...
> bq. $(document).on("click", "a:not([data-bypass=true])", function(evt) {
> ... the FauxtonAPI.navigate() function will be properly called for all links
> that aren't explicitly bypassing event delegation, and thus the beforeUnload
> function containing the alert() will get called as we want.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2584) Highlight user management section
[ https://issues.apache.org/jira/browse/COUCHDB-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324024#comment-14324024 ] ASF GitHub Bot commented on COUCHDB-2584: - Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/273 > Highlight user management section > -- > > Key: COUCHDB-2584 > URL: https://issues.apache.org/jira/browse/COUCHDB-2584 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Garren Smith > > Highlight user management section when it is active -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2583) ensure_full_commit requires empty but typed content or it will unexpectedly drops the connection
[
https://issues.apache.org/jira/browse/COUCHDB-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322979#comment-14322979
]
ASF GitHub Bot commented on COUCHDB-2583:
-
GitHub user samueltardieu opened a pull request:
https://github.com/apache/couchdb/pull/303
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type be set
to "application/json". However, when some content is provided (such as "{}" in
order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content is read
from the incoming HTTP request.
Fixes COUCHDB-2583
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samueltardieu/couchdb consume-json-body
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
commit 120ce333e8103d2cd8cf79fefaf1ced6d01db893
Author: Samuel Tardieu
Date: 2015-02-16T13:17:10Z
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type
be set to "application/json". However, when some content is provided
(such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content
is read from the incoming HTTP request.
Fixes COUCHDB-2583
> ensure_full_commit requires empty but typed content or it will unexpectedly
> drops the connection
>
>
> Key: COUCHDB-2583
> URL: https://issues.apache.org/jira/browse/COUCHDB-2583
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: HTTP Interface
>Affects Versions: 1.6.1
>Reporter: Samuel Tardieu
> Attachments: 0001-Consume-JSON-body-even-if-ignored.patch
>
>
> When given an non-empty (but valid) JSON content, some methods such as
> {{_ensure_full_commit}} will abruptly drop a persistent connection instead of
> waiting for a new HTTP request even though no error is signaled in CouchDB
> logs:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Type: application/json
> Content-Length: 2
> {}
> {code}
> {code:title=Response}
> HTTP/1.1 201 Created
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:49:11 GMT
> Content-Type: application/json
> Content-Length: 53
> Cache-Control: must-revalidate
> {"ok":true,"instance_start_time":"1424085277160411"}
> {code}
> [connection is closed without warning by CouchDB at this point]
> To remedy that, one could try to give an empty content, but some frameworks
> (such as spray.io) will systematically omit the {{Content-Type}} header in
> this case since it makes little sense to type empty content. However, CouchDB
> will reject the request even though it does *not* want any content:
> {code:title=Request}
> POST /testdb1/_ensure_full_commit HTTP/1.1
> Host: localhost:5984
> Accept: application/json
> Content-Length: 0
> {code}
> {code:title=Response}
> HTTP/1.1 415 Unsupported Media Type
> Server: CouchDB/1.6.1 (Erlang OTP/17)
> Date: Mon, 16 Feb 2015 11:55:52 GMT
> Content-Type: application/json
> Content-Length: 78
> Cache-Control: must-revalidate
> {"error":"bad_content_type","reason":"Content-Type must be application/json"}
> {code}
> This makes it impossible to use those methods with such frameworks. CouchDB
> should not drop the connection and ignore the data if {{Content-Length}} is
> not 0, nor require that data be typed with {{application/json}} if it is
> going to ignore it anyway or if it requires it to be empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2579) Polling interval label doesn't update when using slider
[ https://issues.apache.org/jira/browse/COUCHDB-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322928#comment-14322928 ] ASF GitHub Bot commented on COUCHDB-2579: - Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/269 > Polling interval label doesn't update when using slider > --- > > Key: COUCHDB-2579 > URL: https://issues.apache.org/jira/browse/COUCHDB-2579 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Small thing: the label for the Polling Interval slider on Active Tasks > doesn't update for IE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2566) Centralized system for retrieving, setting, and navigating URLs
[ https://issues.apache.org/jira/browse/COUCHDB-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322905#comment-14322905 ] ASF GitHub Bot commented on COUCHDB-2566: - Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/258 > Centralized system for retrieving, setting, and navigating URLs > > > Key: COUCHDB-2566 > URL: https://issues.apache.org/jira/browse/COUCHDB-2566 > Project: CouchDB > Issue Type: Improvement > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Michelle Phung >Assignee: Michelle Phung > > Hi, > I am proposing a more centralized system for retrieving, setting, and > navigating URLs. Currently urls needed for Fauxton depend on the url > specified within each model. But a URL is essentially a string, so my > proposal is that we re-write the retrieval for each URL into one file. > This should help when deciding what kind of URL a developer would need for > each specific task, and also help in debugging if they are working with URLs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2584) Highlight user management section
[ https://issues.apache.org/jira/browse/COUCHDB-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322716#comment-14322716 ] ASF GitHub Bot commented on COUCHDB-2584: - GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/273 Highlight User managment section Highlights user managment section when it is active Fixes COUCHDB-2584 You can merge this pull request into a Git repository by running: $ git pull https://github.com/garrensmith/couchdb-fauxton highlight-user-management Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #273 commit 51db3c9c087294e02ad5dcc6731fe6a8dd7bbaff Author: Garren Smith Date: 2015-02-16T12:39:30Z Highlight User managment section Highlights user managment section when it is active Fixes COUCHDB-2584 > Highlight user management section > -- > > Key: COUCHDB-2584 > URL: https://issues.apache.org/jira/browse/COUCHDB-2584 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Garren Smith > > Highlight user management section when it is active -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2582) Index Editor - view name resets
[ https://issues.apache.org/jira/browse/COUCHDB-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322625#comment-14322625 ] ASF GitHub Bot commented on COUCHDB-2582: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/272 > Index Editor - view name resets > --- > > Key: COUCHDB-2582 > URL: https://issues.apache.org/jira/browse/COUCHDB-2582 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Garren Smith > > Go to new view > Alter the Index name to "foo" > Select _count in the Reduce dropdown. > Note that the Index name has reverted to "new-view" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2582) Index Editor - view name resets
[ https://issues.apache.org/jira/browse/COUCHDB-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322612#comment-14322612 ] ASF GitHub Bot commented on COUCHDB-2582: - GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/272 View name resets When creating a new view if a user changed the reduce editor settings the view name would reset back to original This fixes COUCHDB-2582 You can merge this pull request into a Git repository by running: $ git pull https://github.com/garrensmith/couchdb-fauxton fix-view-name-change Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/272.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #272 commit 39a6f3387d88a0eccd84ba54f50d4b2d0f599951 Author: Garren Smith Date: 2015-02-16T10:12:27Z View name resets When creating a new view if a user changed the reduce editor settings the view name would reset back to original This fixes COUCHDB-2582 > Index Editor - view name resets > --- > > Key: COUCHDB-2582 > URL: https://issues.apache.org/jira/browse/COUCHDB-2582 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Garren Smith > > Go to new view > Alter the Index name to "foo" > Select _count in the Reduce dropdown. > Note that the Index name has reverted to "new-view" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2581) Improve tooltip for Databases page (!) icons
[ https://issues.apache.org/jira/browse/COUCHDB-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321001#comment-14321001 ] ASF GitHub Bot commented on COUCHDB-2581: - GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/271 Improved tooltip for ! icon on db page This adds a jQuery tooltip for the (!) icons on the Databases page and includes a nightwatch test to confirm the mouseover behaviour. Closes COUCHDB-2581 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton 2581-tooltip-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/271.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #271 commit 02321e9f256959aef4eb6d5dd6296c60d9e9b772 Author: Ben Keen Date: 2015-02-13T23:55:38Z Improved tooltip for ! icon on db page This adds a jQuery tooltip for the (!) icons on the Databases page and includes a nightwatch test to confirm the mouseover behaviour. Closes COUCHDB-2581 > Improve tooltip for Databases page (!) icons > > > Key: COUCHDB-2581 > URL: https://issues.apache.org/jira/browse/COUCHDB-2581 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > Attachments: Screen Shot 2015-02-13 at 2.28.33 PM.png > > > The question mark icon that sometimes appears on the databases page has a > title, but not a corresponding tooltip() to make the tooltip appear > immediately. As such it's not very clear what the icon means. > Looking at the code, it looks like the tooltip() was just placed in the wrong > View. This ticket is just to improve the tooltip for that icon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2574) Clicking away from editor with unsaved changes should always show "do you want to save?" msg
[
https://issues.apache.org/jira/browse/COUCHDB-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320824#comment-14320824
]
ASF GitHub Bot commented on COUCHDB-2574:
-
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/263
> Clicking away from editor with unsaved changes should always show "do you
> want to save?" msg
>
>
> Key: COUCHDB-2574
> URL: https://issues.apache.org/jira/browse/COUCHDB-2574
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
>Reporter: Ben Keen
>Assignee: Ben Keen
>
> Any time the user has made changes to the content in an Ace Editor then tries
> navigating away from the page, it should confirm they don't want the
> information lost. We do this in a few places right now, but not everywhere.
> The core FauxtonAPI.navigate function checks any beforeUnload functions all
> pass prior to redirecting. The issue is that in main.js, the chief event
> delegation function running on all 's checks for the existence of a
> data-bypass attribute, but not that the attribute is set to true.
> Once we change this:
> bq. $(document).on("click", "a:not([data-bypass])", function(evt) {
> ... to this ...
> bq. $(document).on("click", "a:not([data-bypass=true])", function(evt) {
> ... the FauxtonAPI.navigate() function will be properly called for all links
> that aren't explicitly bypassing event delegation, and thus the beforeUnload
> function containing the alert() will get called as we want.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2580) Databases page doesn't update after adding new DB - IE11
[ https://issues.apache.org/jira/browse/COUCHDB-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320819#comment-14320819 ] ASF GitHub Bot commented on COUCHDB-2580: - GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/270 Fix for DB page not updating after new db added Note: there's no new test for this because a test already existed to confirm exactly this, except it would have failed on IE if it ran on that browser. Closes COUCHDB-2580 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton 2580-ensure-db-list-updated Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/270.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #270 commit b6e9df89cafdbec1e927ca6a8a164495835ae74a Author: Ben Keen Date: 2015-02-13T21:49:13Z Fix for DB page not updating after new db added Note: there's no new test for this because (a) a test already existed to confirm exactly this, except it would have failed on IE if we could run it there. Closes COUCHDB-2580 > Databases page doesn't update after adding new DB - IE11 > > > Key: COUCHDB-2580 > URL: https://issues.apache.org/jira/browse/COUCHDB-2580 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > After adding a database then navigating back to the databases page, the new > database doesn't get listed on the page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2579) Polling interval label doesn't update when using slider
[ https://issues.apache.org/jira/browse/COUCHDB-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320681#comment-14320681 ] ASF GitHub Bot commented on COUCHDB-2579: - GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/269 Fix for polling interval label not updating Due to a bug in IE11, the onInput event doesn't fire on the range slider on incremental changes. This adds both onInput and onChange events to ensure it works for all browser environments. Closes COUCHDB-2579 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton 2579-polling-interval-label-ie-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #269 commit 78fe699221e35418b9179b367733cde2284be1a5 Author: Ben Keen Date: 2015-02-13T20:07:13Z Fix for polling interval label not updating Due to a bug in IE11, the onInput event doesn't fire on the range slider on incremental changes. This adds both onInput and onChange events to ensure it works for all browser environments. Closes COUCHDB-2579 > Polling interval label doesn't update when using slider > --- > > Key: COUCHDB-2579 > URL: https://issues.apache.org/jira/browse/COUCHDB-2579 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Small thing: the label for the Polling Interval slider on Active Tasks > doesn't update for IE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2573) Problems selecting text in Ace editor
[ https://issues.apache.org/jira/browse/COUCHDB-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320518#comment-14320518 ] ASF GitHub Bot commented on COUCHDB-2573: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/266 > Problems selecting text in Ace editor > -- > > Key: COUCHDB-2573 > URL: https://issues.apache.org/jira/browse/COUCHDB-2573 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Two issues: > 1. The background color isn't that different from the selected row colour, so > it's not clear what's selected. > 2. The selected text background looks like it's being shifted to the left, > rather than behind the actual text you're selecting -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2574) Clicking away from editor with unsaved changes should always show "do you want to save?" msg
[
https://issues.apache.org/jira/browse/COUCHDB-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318732#comment-14318732
]
ASF GitHub Bot commented on COUCHDB-2574:
-
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/267
Fix missing confirmation when leaving editor
To not render a property in React we need to pass `null` to it. If
we are passing `false` or `"false"` it gets rendered into the DOM.
This fixes a bug where you edited a document and then got no
confirmation dialog if you are really sure you want to leave the
page without saving if you clicked on the navigation bar on the
left.
Having `data-bypass="false"` will mean to the selector
`:not(["data-bypass"])` that there is a `data-bypass` - containing
a String! (which then matches the selector)
What we want is _no_ `data-bypass` if we don't want to bypass.
Looking at the old DOM a month ago shows how we used `data-bypass`:
Closes COUCHDB-2574
superseeds #263
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton
2574-save-editor-changed-confirmation-react-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
commit cf03798402d7c02b1d124e15960e9e203ae73ff8
Author: Robert Kowalski
Date: 2015-02-12T18:13:40Z
Fix coding style
commit 60dce889c5e0f950b948cb05811046f8eb4b93f6
Author: Robert Kowalski
Date: 2015-02-12T18:14:58Z
Fix missing confirmation when leaving editor
Fix for passing false as a string with is evaluated truthy
This fixes a bug where you edited a document and then got no
confirmation dialog if you are really sure you want to leave the
page without saving if you clicked on the navigation bar on the
left.
To not render a property in React we need to pass `null` to it. If
we are passing `false` or `"false"` it gets rendered into the DOM.
Having `data-bypass="false"` will mean to the selector
`:not(["data-bypass"])` that there is a `data-bypass` - containing
a String! (which then matches the selector)
What we want is _no_ `data-bypass` if we don't want to bypass.
Closes COUCHDB-2574
> Clicking away from editor with unsaved changes should always show "do you
> want to save?" msg
>
>
> Key: COUCHDB-2574
> URL: https://issues.apache.org/jira/browse/COUCHDB-2574
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
>Reporter: Ben Keen
>Assignee: Ben Keen
>
> Any time the user has made changes to the content in an Ace Editor then tries
> navigating away from the page, it should confirm they don't want the
> information lost. We do this in a few places right now, but not everywhere.
> The core FauxtonAPI.navigate function checks any beforeUnload functions all
> pass prior to redirecting. The issue is that in main.js, the chief event
> delegation function running on all 's checks for the existence of a
> data-bypass attribute, but not that the attribute is set to true.
> Once we change this:
> bq. $(document).on("click", "a:not([data-bypass])", function(evt) {
> ... to this ...
> bq. $(document).on("click", "a:not([data-bypass=true])", function(evt) {
> ... the FauxtonAPI.navigate() function will be properly called for all links
> that aren't explicitly bypassing event delegation, and thus the beforeUnload
> function containing the alert() will get called as we want.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2547) Fix broken tests for couch app
[ https://issues.apache.org/jira/browse/COUCHDB-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316987#comment-14316987 ] ASF GitHub Bot commented on COUCHDB-2547: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/24 Use started apps from test_util:start_applications COUCHDB-2547 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-chttpd 2547-fix-broken-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit 8461eb01680d8962c9544c3f3bdc4e6606a89c3c Author: ILYA Khlopotov Date: 2015-02-11T21:05:47Z Use started apps from test_util:start_applications COUCHDB-2547 > Fix broken tests for couch app > -- > > Key: COUCHDB-2547 > URL: https://issues.apache.org/jira/browse/COUCHDB-2547 > Project: CouchDB > Issue Type: Test > Security Level: public(Regular issues) >Reporter: ILYA >Assignee: ILYA > > Some of the tests suites are disabled with -ifdef(run_broken_tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2573) Problems selecting text in Ace editor
[ https://issues.apache.org/jira/browse/COUCHDB-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316498#comment-14316498 ] ASF GitHub Bot commented on COUCHDB-2573: - GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/266 Style fix for selecting text in Ace editor This PR contains two things: 1. reverts an old custom change to the Ace editor theme file 2. updates the select text style, as per: https://issues.apache.org/jira/browse/COUCHDB-2573 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton 2560-ace-editor-theme-update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/266.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #266 commit 1287abf9da29b965338a6559f7769e71ec3b3666 Author: Ben Keen Date: 2015-02-11T16:31:47Z Revert "Style fix for clicking on doc line nums" This reverts commit b53a4db5a4d48320da28fd0f9dd173cb94c67f5b. commit 3f51e122a8730e615bed23b69ebb94d8ceb10557 Author: Ben Keen Date: 2015-02-11T16:40:24Z Style fix for selected text in Ace editor This updates the background color and the location of the selected text bg color. Closes COUCHDB-2573 > Problems selecting text in Ace editor > -- > > Key: COUCHDB-2573 > URL: https://issues.apache.org/jira/browse/COUCHDB-2573 > Project: CouchDB > Issue Type: Bug > Security Level: public(Regular issues) > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Two issues: > 1. The background color isn't that different from the selected row colour, so > it's not clear what's selected. > 2. The selected text background looks like it's being shifted to the left, > rather than behind the actual text you're selecting -- This message was sent by Atlassian JIRA (v6.3.4#6332)
