[GitHub] couchdb-fauxton pull request: Fixes to creating views
Github user drsm79 commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/75#discussion_r18278924
--- Diff: app/addons/documents/views-index.js ---
@@ -524,7 +526,7 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb,
ddocAdded: function (ddoc) {
this.ddocName = ddoc.id;
- this.render();
+ //this.render();
--- End diff --
remove rather than comment out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fauxton View improvements
Github user drsm79 commented on the pull request: https://github.com/apache/couchdb/pull/254#issuecomment-47659961 LGTM - maybe worth squashing the first two commits and doing the stale fix in another PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Fauxton View improvements
Github user drsm79 commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/254#discussion_r14405549
--- Diff: src/fauxton/app/addons/documents/resources.js ---
@@ -482,6 +482,14 @@ function(app, FauxtonAPI, PagingCollection) {
});
return PagingCollection.prototype.parse.call(this, resp);
+},
+
+clone: function () {
--- End diff --
Would using http://backbonejs.org/#Collection-clone be better/possible here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2071 better create db ui
Github user drsm79 commented on the pull request: https://github.com/apache/couchdb/pull/155#issuecomment-43082545 It didn't - I've not had a chance to address the issue @BigBlueHat raised. That seems like a general issue - I was thinking of adding a listener for the route event to the modal base class. Sane? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: 2071 better create db ui
Github user drsm79 commented on the pull request: https://github.com/apache/couchdb/pull/155#issuecomment-36064001 I'd like to squash these before merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: 2071 better create db ui
GitHub user drsm79 opened a pull request: https://github.com/apache/couchdb/pull/155 2071 better create db ui Also fixes COUCHDB-2086 - one word change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/drsm79/couchdb 2071-better-create-db-ui Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 commit ee909bfe8b46a0492ea1c1c057a7774a7df12c11 Author: Simon Metson simon+git...@cloudant.com Date: 2014-02-20T22:53:34Z whitespace commit 5293af249654348e13817ddd92aab98800a51397 Author: Simon Metson simon+git...@cloudant.com Date: 2014-02-20T22:51:10Z Add modal for create db - fixes COUCHDB-2071 commit bf38c9e58f994b452d9ba5c930392abf31522174 Author: Simon Metson simon+git...@cloudant.com Date: 2014-02-21T22:19:16Z Fixes COUCHDB-2086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
couchdb pull request: 2038 improve db delete confirmation
Github user drsm79 closed the pull request at: https://github.com/apache/couchdb/pull/140
couchdb pull request: 2038 improve db delete confirmation
GitHub user drsm79 opened a pull request: https://github.com/apache/couchdb/pull/140 2038 improve db delete confirmation This adds a github like modal for confirming database deletion. There's scope to dry the code further - making a ModalView to have the various modals inherit from - but I thought pushing this up for review would be good, not least because I've not written any fauxton code for a while. I'm sure there's styling to improve, too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/drsm79/couchdb 2038-improve-db-delete-confirmation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/140.patch commit 5f03e34859c36fb7af85b1fbd41610e646866bf5 Author: Simon Metson simon+git...@cloudant.com Date: 2014-01-26T19:05:22Z Whitespace commit 8149e7132e4a3ca0370a51c3b6b2d4fd08b384f7 Author: Simon Metson simon+git...@cloudant.com Date: 2014-01-26T19:04:57Z dry out delete events commit 049e71e1a464d7298223f60e4b90dae875fdf166 Author: Simon Metson simon+git...@cloudant.com Date: 2014-01-26T19:06:18Z Modal instead of prompt for delete Display a modal asking for database name instead of a simple prompt.
