[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[
https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116108#comment-13116108
]
Paul Joseph Davis commented on COUCHDB-1265:
Really fixed in:
trunk r1176701
1.2.x r1176703
1.1.x r1176704
As a follow up to COUCHDB-1265 I was missing the fact that after the
insertion of a new update_seq into an internal node it is quite possible
that a compaction runs before the doc is updated again. This is
important because compaction removes information of the largest update
seq from the tree itself.
The fix is simple to include the update_seq from the #full_doc_info{}
record when calculating #doc_info.high_seq. The way to think of this
is that it's the maximum value from all known values for the update
sequence which can be defined as all values known in the tree or in the
full_doc_info record.
Replication can introduce duplicates into the seq_btree.
Key: COUCHDB-1265
URL: https://issues.apache.org/jira/browse/COUCHDB-1265
Project: CouchDB
Issue Type: Bug
Components: Database Core
Reporter: Paul Joseph Davis
Assignee: Paul Joseph Davis
Fix For: 1.1.1, 1.2
Attachments: COUCHDB-1265.patch, replication-frenzy.py
Full description, test, and patch to follow shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[ https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098788#comment-13098788 ] James Howe commented on COUCHDB-1265: - Presumably this bug could cause duplicate entries in views. Could it also cause views to contain deleted documents (that still had bodies which got them through the map)? Replication can introduce duplicates into the seq_btree. Key: COUCHDB-1265 URL: https://issues.apache.org/jira/browse/COUCHDB-1265 Project: CouchDB Issue Type: Bug Components: Database Core Reporter: Paul Joseph Davis Assignee: Paul Joseph Davis Attachments: COUCHDB-1265.patch, replication-frenzy.py Full description, test, and patch to follow shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[ https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13099131#comment-13099131 ] Paul Joseph Davis commented on COUCHDB-1265: Not directly, no. For a a doc to make it through to the map one of its leaves would have to be not deleted which would be visible when getting the doc directly. Replication can introduce duplicates into the seq_btree. Key: COUCHDB-1265 URL: https://issues.apache.org/jira/browse/COUCHDB-1265 Project: CouchDB Issue Type: Bug Components: Database Core Reporter: Paul Joseph Davis Assignee: Paul Joseph Davis Attachments: COUCHDB-1265.patch, replication-frenzy.py Full description, test, and patch to follow shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[ https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093903#comment-13093903 ] Joan Touzet commented on COUCHDB-1265: -- I'm +1 on this - now, I'm no longer seeing the Erlang traceback. It uncovered other issues (COUCHDB-1256 for one) but I'm chipping away at them too. THANK YOU! Replication can introduce duplicates into the seq_btree. Key: COUCHDB-1265 URL: https://issues.apache.org/jira/browse/COUCHDB-1265 Project: CouchDB Issue Type: Bug Components: Database Core Reporter: Paul Joseph Davis Assignee: Paul Joseph Davis Attachments: COUCHDB-1265.patch, replication-frenzy.py Full description, test, and patch to follow shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[ https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092815#comment-13092815 ] Adam Kocoloski commented on COUCHDB-1265: - Nice find, Paul. I'm not sure what our Erlang version we require on trunk these days, but if we're still supporting R13 you'll want to use the fully-qualified erlang:max/2. Otherwise the patch looks solid. Replication can introduce duplicates into the seq_btree. Key: COUCHDB-1265 URL: https://issues.apache.org/jira/browse/COUCHDB-1265 Project: CouchDB Issue Type: Bug Components: Database Core Reporter: Paul Joseph Davis Assignee: Paul Joseph Davis Attachments: COUCHDB-1265.patch, replication-frenzy.py Full description, test, and patch to follow shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[ https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092973#comment-13092973 ] Joan Touzet commented on COUCHDB-1265: -- This was my bug - thank you Mr. Davis! We will be testing today and providing feedback (most likely as a +1) Replication can introduce duplicates into the seq_btree. Key: COUCHDB-1265 URL: https://issues.apache.org/jira/browse/COUCHDB-1265 Project: CouchDB Issue Type: Bug Components: Database Core Reporter: Paul Joseph Davis Assignee: Paul Joseph Davis Attachments: COUCHDB-1265.patch, replication-frenzy.py Full description, test, and patch to follow shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[
https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093017#comment-13093017
]
Filipe Manana commented on COUCHDB-1265:
Paul, looks good.
Just a side note, due to upgrade code in trunk for the branch sizes, instead of
matching against {_Deleted, _DiskPos, OldTreeSeq, _Sie}, it would likely be
better to call is_tuple(Value) and a element(3, Value) (or match against 3 and
4 element tuples).
Replication can introduce duplicates into the seq_btree.
Key: COUCHDB-1265
URL: https://issues.apache.org/jira/browse/COUCHDB-1265
Project: CouchDB
Issue Type: Bug
Components: Database Core
Reporter: Paul Joseph Davis
Assignee: Paul Joseph Davis
Attachments: COUCHDB-1265.patch, replication-frenzy.py
Full description, test, and patch to follow shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1265) Replication can introduce duplicates into the seq_btree.
[ https://issues.apache.org/jira/browse/COUCHDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093024#comment-13093024 ] Paul Joseph Davis commented on COUCHDB-1265: @Filipe Good catch on that. Probably about time we start replacing some of these tuples with records that serialize to proplists for upgrades. But that's another ball of honey to catch snakes with. Replication can introduce duplicates into the seq_btree. Key: COUCHDB-1265 URL: https://issues.apache.org/jira/browse/COUCHDB-1265 Project: CouchDB Issue Type: Bug Components: Database Core Reporter: Paul Joseph Davis Assignee: Paul Joseph Davis Attachments: COUCHDB-1265.patch, replication-frenzy.py Full description, test, and patch to follow shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
