[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162421#comment-13162421 ] Benoit Chesneau commented on COUCHDB-1323: -- Full patch is available in my repo : https://github.com/benoitc/couchdb/compare/master...couch_replicator-2 couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-create-couch_replicator-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0002-refactor-couch_replicator.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162472#comment-13162472 ] Randall Leeds commented on COUCHDB-1323: Thanks, Benoit. Indentation in couch_replicator.app.src is inconsistent, but otherwise everything looks good. +1. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-create-couch_replicator-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0002-refactor-couch_replicator.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162504#comment-13162504 ] Filipe Manana commented on COUCHDB-1323: Benoît, just tried out your github branch. All tests pass for me and it looks ok, so +1 Looking at .gitignore changes, I see the following line added and I'm curious about it. +*.sw* What are the *.sw* files? couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-create-couch_replicator-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0002-refactor-couch_replicator.patch, 0002-refactor-couch_replicator.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (COUCHDB-1323) couch_replicator
On Sun, Dec 4, 2011 at 11:42 PM, Filipe Manana (Commented) (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162504#comment-13162504 ] Filipe Manana commented on COUCHDB-1323: Benoît, just tried out your github branch. All tests pass for me and it looks ok, so +1 Looking at .gitignore changes, I see the following line added and I'm curious about it. +*.sw* What are the *.sw* files? couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-create-couch_replicator-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0002-refactor-couch_replicator.patch, 0002-refactor-couch_replicator.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira sw file are vim swap files . I was tired to clean that every time ... - benoit
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162611#comment-13162611 ] Benoit Chesneau commented on COUCHDB-1323: -- @paul nice trick thanks. I will commit the patch later in the morning then. Thanks for the review. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-create-couch_replicator-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0002-refactor-couch_replicator.patch, 0002-refactor-couch_replicator.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152289#comment-13152289 ] Adam Kocoloski commented on COUCHDB-1323: - LGTM Benoit couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151247#comment-13151247 ] Benoit Chesneau commented on COUCHDB-1323: -- Ifit's OK I will commit that change later today. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151246#comment-13151246 ] Benoit Chesneau commented on COUCHDB-1323: -- I've upgraded my branch with latest changes in replication. Following are my answers: - couch_replicator.app is commited? Shouldn't be the case now. - couch_replicator_manager is now registered . I'm not sure why we need to register others here. What would be the benefit. - About records, I'm not sure if it could be usable actually for other things. However, that is something we could change easily in another patch I think once we are sure it couldn't be used in another parts? - nitpick, fixed. - I agree, more generally we could have such things in couch_core, for cache support as well imo. Side points. I think we could benefit here by using a simple_one_for_one supervisor for replication tasks rather a one_for_one . So it would simplify the calll and termination handling imo. We are in a case where this kind of supervision works pretty well. In near future I really would like couchdb built as a full erlang release where couch core and others are applications booted on start. Lot of things would benefit from it. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151337#comment-13151337 ] Adam Kocoloski commented on COUCHDB-1323: - Is the link still https://github.com/benoitc/couchdb/compare/master...couch_replicator ? I see a new commit from you but going through the checklist I see that couch_replicator.app is still being committed. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151343#comment-13151343 ] Benoit Chesneau commented on COUCHDB-1323: -- Thanks Adam, not sure why it has been committed at first... Anyway I've committed a new change : https://github.com/benoitc/couchdb/commit/2df4351cbfb28f543876377ba82be30175a95fff which fix that issue. If this is ok i will merge the changes and commit it to the head. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151377#comment-13151377 ] Benoit Chesneau commented on COUCHDB-1323: -- @davisp I fixed the indentation in https://github.com/benoitc/couchdb/commit/84f4e4179d29d8ffaf19ef846ae53cea3287ba87 but makefile was working without. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151389#comment-13151389 ] Paul Joseph Davis commented on COUCHDB-1323: Looks like I should've clicked through to the file view. Apparently GitHub has decided to start representing tabs as two space indents in diffs. +1 from me then. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140095#comment-13140095 ] Filipe Manana commented on COUCHDB-1323: All tests are now passing for me. Just noticed that src/couch_replicator/ebin/couch_replicator.app should be added to .gitignore as wel, since it's modified after every build. +1 to go to master couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[
https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139625#comment-13139625
]
Filipe Manana commented on COUCHDB-1323:
Thanks Benoit.
I tested the second patch, but test 002 is failing:
fdmanana 14:00:20 ~/git/hub/couchdb4 (master) ./test/etap/run -v
src/couch_replicator/test/002-replication-compact.t
src/couch_replicator/test/002-replication-compact.t ..
# Current time local 2011-10-30 14:00:25
# Using etap version 0.3.4
1..376
Apache CouchDB 0.0.0 (LogLevel=info) is starting.
Apache CouchDB has started. Time to relax.
[info] [0.2.0] Apache CouchDB has started on http://127.0.0.1:59045/
ok 1 - Source database is idle before starting replication
ok 2 - Target database is idle before starting replication
# Test died abnormally: {'EXIT',
{noproc,
{gen_server,call,
[couch_rep_sup,
{start_child,
{e0ce0ffa71ae1915f953eb8d2f93e348+continuous,
{gen_server,start_link,
[couch_replicator,
{rep,
{e0ce0ffa71ae1915f953eb8d2f93e348,
Good work :)
couch_replicator
Key: COUCHDB-1323
URL: https://issues.apache.org/jira/browse/COUCHDB-1323
Project: CouchDB
Issue Type: Improvement
Components: Replication
Affects Versions: 2.0, 1.3
Reporter: Benoit Chesneau
Labels: replication
Attachments:
0001-move-couchdb-replication-to-a-standalone-application.patch,
0001-move-couchdb-replication-to-a-standalone-application.patch
patch to move couch replication modules in in a standalone couch_replicator
application. It's also available on my github:
https://github.com/benoitc/couchdb/compare/master...couch_replicator
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1323) couch_replicator
[ https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139637#comment-13139637 ] Filipe Manana commented on COUCHDB-1323: All tests now pass except test/etap/001-load.t which needs some lines updated with the new module names. From my side, after that small change, it's ready to go into master. Thanks for doing this change Benoît. couch_replicator Key: COUCHDB-1323 URL: https://issues.apache.org/jira/browse/COUCHDB-1323 Project: CouchDB Issue Type: Improvement Components: Replication Affects Versions: 2.0, 1.3 Reporter: Benoit Chesneau Labels: replication Attachments: 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch, 0001-move-couchdb-replication-to-a-standalone-application.patch patch to move couch replication modules in in a standalone couch_replicator application. It's also available on my github: https://github.com/benoitc/couchdb/compare/master...couch_replicator -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
