[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-11-28 Thread Filipe Manana (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Filipe Manana updated COUCHDB-1289:
---

Attachment: 0002-Make-reset_heartbeat-0-a-no-op.patch

Added the patch as an attachment instead

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
>  Labels: patch
> Fix For: 1.2
>
> Attachments: 0001-Ensure-heartbeats-are-not-skipped.patch, 
> 0002-Failing-etap-for-heartbeats-skipped.patch, 
> 0002-Make-reset_heartbeat-0-a-no-op.patch
>
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-11-28 Thread Bob Dionne (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Dionne updated COUCHDB-1289:


Fix Version/s: 1.2
   Labels: patch  (was: )

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
>  Labels: patch
> Fix For: 1.2
>
> Attachments: 0001-Ensure-heartbeats-are-not-skipped.patch, 
> 0002-Failing-etap-for-heartbeats-skipped.patch
>
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-11-27 Thread Bob Dionne (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Dionne updated COUCHDB-1289:


Attachment: 0002-Failing-etap-for-heartbeats-skipped.patch
0001-Ensure-heartbeats-are-not-skipped.patch

Filipe,

  I pulled your last commit, fixed those nits, rebased, squashed and formatted 
two new patches. I made you author of one, since it doesn't look like git 
supports multiple authors. Thanks, this one was gnarly, I'm hopeful we got all 
the edges,

Bob

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
> Attachments: 0001-Ensure-heartbeats-are-not-skipped.patch, 
> 0002-Failing-etap-for-heartbeats-skipped.patch
>
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-11-27 Thread Bob Dionne (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Dionne updated COUCHDB-1289:


Attachment: (was: 0002-Failing-etap-for-heartbeats-skipped.patch)

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-11-27 Thread Bob Dionne (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Dionne updated COUCHDB-1289:


Attachment: (was: 0001-Ensure-heartbeats-are-not-skipped.patch)

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-11-25 Thread Bob Dionne (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Dionne updated COUCHDB-1289:


Attachment: 0002-Failing-etap-for-heartbeats-skipped.patch
0001-Ensure-heartbeats-are-not-skipped.patch

second draft of patch. Filipe, this handles both cases now and is refactored to 
be a bit simpler.

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
> Attachments: 0001-Ensure-heartbeats-are-not-skipped.patch, 
> 0002-Failing-etap-for-heartbeats-skipped.patch
>
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-11-25 Thread Bob Dionne (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Dionne updated COUCHDB-1289:


Attachment: (was: 
0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch)

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

2011-10-12 Thread Bob Dionne (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Dionne updated COUCHDB-1289:


Attachment: 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch

This patch against current master fixes the heartbeat issue

> heartbeats skipped when continuous changes feed filter function produces no 
> results
> ---
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Bob Dionne
>Assignee: Bob Dionne
>Priority: Minor
> Attachments: 
> 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch
>
>
> if the changes feed has a filter function that produces no results, 
> db_updated messages will still be sent and the heartbeat timeout will never 
> be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira