[jira] [Commented] (COUCHDB-833) Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace
[ https://issues.apache.org/jira/browse/COUCHDB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217361#comment-13217361 ] Jan Lehnardt commented on COUCHDB-833: -- we'd still need it to verify that "old" user docs still work, and it might be required in the ouath tests. that means we could remove it from futon and just have it in the test suite. > Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the > global namespace > - > > Key: COUCHDB-833 > URL: https://issues.apache.org/jira/browse/COUCHDB-833 > Project: CouchDB > Issue Type: Improvement > Components: Futon >Reporter: Devin Torres >Priority: Trivial > Attachments: better_js_sha1.patch, better_js_sha1.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > The current implementation by Paj is slow and pollutes the global namespace > with variables and functions. This implementation only exports the SHA1 > module and also happens to be up to 3 times faster as an added bonus. See > http://bit.ly/9wjjRG for benchmarks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-833) Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace
[ https://issues.apache.org/jira/browse/COUCHDB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217357#comment-13217357 ] Sam Bisbee commented on COUCHDB-833: Okay ... so does that mean we can remove it? :) > Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the > global namespace > - > > Key: COUCHDB-833 > URL: https://issues.apache.org/jira/browse/COUCHDB-833 > Project: CouchDB > Issue Type: Improvement > Components: Futon >Reporter: Devin Torres >Priority: Trivial > Attachments: better_js_sha1.patch, better_js_sha1.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > The current implementation by Paj is slow and pollutes the global namespace > with variables and functions. This implementation only exports the SHA1 > module and also happens to be up to 3 times faster as an added bonus. See > http://bit.ly/9wjjRG for benchmarks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-833) Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace
[ https://issues.apache.org/jira/browse/COUCHDB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213777#comment-13213777 ] Jan Lehnardt commented on COUCHDB-833: -- It used to be used in prepareUserAccount before 1.2.x/1.3.x _users db security changes. > Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the > global namespace > - > > Key: COUCHDB-833 > URL: https://issues.apache.org/jira/browse/COUCHDB-833 > Project: CouchDB > Issue Type: Improvement > Components: Futon >Reporter: Devin Torres >Priority: Trivial > Attachments: better_js_sha1.patch, better_js_sha1.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > The current implementation by Paj is slow and pollutes the global namespace > with variables and functions. This implementation only exports the SHA1 > module and also happens to be up to 3 times faster as an added bonus. See > http://bit.ly/9wjjRG for benchmarks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-833) Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace
[ https://issues.apache.org/jira/browse/COUCHDB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213182#comment-13213182 ] Sam Bisbee commented on COUCHDB-833: I just did a cursory review of where we use SHA1 in Futon and was under whelmed. As far as I can tell it's really only used in the tests even though it's included in every Futon page (creating a different issue for this). If someone cares enough about Futon tests' run time then we could replace the SHA1 implementation, but it doesn't seem like a worthwhile cause to me. Cheers. > Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the > global namespace > - > > Key: COUCHDB-833 > URL: https://issues.apache.org/jira/browse/COUCHDB-833 > Project: CouchDB > Issue Type: Improvement > Components: Futon >Reporter: Devin Torres >Priority: Trivial > Attachments: better_js_sha1.patch, better_js_sha1.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > The current implementation by Paj is slow and pollutes the global namespace > with variables and functions. This implementation only exports the SHA1 > module and also happens to be up to 3 times faster as an added bonus. See > http://bit.ly/9wjjRG for benchmarks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-833) Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace
[ https://issues.apache.org/jira/browse/COUCHDB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891477#action_12891477 ] Chris Anderson commented on COUCHDB-833: patch doesn't apply cleanly (might be because I did the json2.js update beforehand direct from json.org) Can you repost the patch against latest trunk, or a link to your git repo so I can clone directly? Thanks! Chris > Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the > global namespace > - > > Key: COUCHDB-833 > URL: https://issues.apache.org/jira/browse/COUCHDB-833 > Project: CouchDB > Issue Type: Improvement > Components: Futon >Reporter: Devin Torres >Priority: Trivial > Attachments: better_js_sha1.patch > > Original Estimate: 0.02h > Remaining Estimate: 0.02h > > The current implementation by Paj is slow and pollutes the global namespace > with variables and functions. This implementation only exports the SHA1 > module and also happens to be up to 3 times faster as an added bonus. See > http://bit.ly/9wjjRG for benchmarks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
