Re: Include Source URLs in Generated LICENSE...?

2012-11-05 Thread Chip Childers 
On Sat, Nov 3, 2012 at 2:12 PM, Robert Burrell Donkin
 wrote:
> On 11/01/12 14:02, sebb wrote:
>>
>> On 1 November 2012 13:16, Chip Childers  wrote:
>
>
> 
>
>
>>> The documentation [1] is a little confusing,
>
>
> I've added more content to [1] and to the FAQs on this topic. Is covered
> well enough now? Improvements? Corrections?
>
> Robert
>
>>> [1] http://creadur.apache.org/whisker/meta-data.html#Source_Links
>
>

Looks great.  Thanks for improving it!

Re: copyright-notice [WAS Re: [jira] [Commented] (WHISKER-3) The license.vm template makes too many assumptions about skipping licensing details for the primary org and license type.]

2012-11-05 Thread Chip Childers 
On Sat, Nov 3, 2012 at 2:49 PM, Robert Burrell Donkin
 wrote:
> On 11/03/12 12:20, Robert Burrell Donkin wrote:
>>
>> On 11/02/12 00:44, Chip Childers wrote:
>>>
>>> On Thu, Nov 1, 2012 at 4:52 PM, Robert Burrell Donkin
>>>  wrote:

 On 10/29/12 13:46, Chip Childers wrote:

 

> Please do let me know if I can be of any assistance!



 The descriptor[1] has a lot of elements for licenses
 where they aren't necessary[2]. Did the documentations or the element
 naming
 (say) give the impression that this information is necessary - or
 were they
 included because that the way you want the LICENSE to be ...?
>>
>>
>> 
>>
>>> Perhaps I hit a bug then, because I found that without a copyright
>>> tag, with-license elements were being skipped.
>>
>>
>> I'll create some tests to investigate
>
>
> With the latest code-base, the only difference after removing
> copyright-notice elements from with-license elements is that the copyright
> claims are gone. Could you check if the problem is fixed in the current code
> base...?
>
> Cheers
>
> Robert
>

I'm not able to reproduce this, so it may very well have been user
error.  Thanks Robert.

[jira] [Commented] (WHISKER-10) Investigate Whether with-license issues are skipped without copyright-notice

2012-11-05 Thread Robert Burrell Donkin (JIRA) 

[ 
https://issues.apache.org/jira/browse/WHISKER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490903#comment-13490903
 ] 

Robert Burrell Donkin commented on WHISKER-10:
--

Added a new integration test using the full descriptor, and then removed the 
copyright notices without harm to the resources.

Chip confirms that this potential issue doesn't seem to effect the current 
codebase.

[1] 
http://mail-archives.apache.org/mod_mbox/creadur-dev/201211.mbox/%3CCA%2B96GG5BtWqjkVTzCC8zGazCfvxwGZP9B7TK5-LYosVA_DBa-g%40mail.gmail.com%3E

> Investigate Whether with-license issues are skipped without copyright-notice
> 
>
> Key: WHISKER-10
> URL: https://issues.apache.org/jira/browse/WHISKER-10
> Project: Apache Whisker
>  Issue Type: Bug
>Reporter: Robert Burrell Donkin
>Assignee: Robert Burrell Donkin
>
> In some circumstances, it seems necessary to add copyright-notice elements 
> before with-license elements are printed correctly. Create tests to prove 
> whether this is still the case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (WHISKER-10) Investigate Whether with-license issues are skipped without copyright-notice

2012-11-05 Thread Robert Burrell Donkin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WHISKER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin closed WHISKER-10.


Resolution: Cannot Reproduce

This does not seem to be an issue in the current codebase

> Investigate Whether with-license issues are skipped without copyright-notice
> 
>
> Key: WHISKER-10
> URL: https://issues.apache.org/jira/browse/WHISKER-10
> Project: Apache Whisker
>  Issue Type: Bug
>Reporter: Robert Burrell Donkin
>Assignee: Robert Burrell Donkin
>
> In some circumstances, it seems necessary to add copyright-notice elements 
> before with-license elements are printed correctly. Create tests to prove 
> whether this is still the case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: copyright-notice [WAS Re: [jira] [Commented] (WHISKER-3) The license.vm template makes too many assumptions about skipping licensing details for the primary org and license type.]

2012-11-05 Thread Robert Burrell Donkin 

On 11/05/12 15:09, Chip Childers wrote:




I'm not able to reproduce this


I invested some time in improving the integration test fixtures and add 
an integration test based around your descriptor[1], hoping to be able 
to improve the test to ensure that future versions don't break your build/


Robert

[1] 
http://svn.apache.org/viewvc/creadur/whisker/trunk/apache-whisker-plugin4maven/src/it/whisker-10/

Re: Release Rat ...? [WAS Re: [DISCUSS] Minimum version of Maven to use the Rat plugin]

2012-11-05 Thread Robert Burrell Donkin 

On 11/04/12 16:52, Dennis Lundberg wrote:

On 2012-11-04 16:14, Robert Burrell Donkin wrote:





Does it make sense to start working towards a new release...?


Yes, I think so. I have these things left on my todo list:

A. Rewrite site for core module, which is now in JIRA as RAT-123
B. Add xml schema to assembly descriptors and site descriptors, so that
they can be validated
C. Rewrite src/site/apt/site-publish.apt, given that we're not in the
incubator any more

- Robert has assigned A to himself.


I wrote some stuff at the weekend, but then accidentally deleted tonight 
(Doh!)



- I'll take care of B tonight.


:-)


- We can probably do C as an exercise during the release, to bring it in
touch with reality


What's the current state of play wrt Maven -> Apache CMS integration...?

Robert

Build failed in Jenkins: rat-jdk-1.5-maven-2 #9

2012-11-05 Thread Apache Jenkins Server 
See 

Changes:

[rdonkin] RAT-123 starting to outline new documentation for core

[rdonkin] Replace older-style source headers, and Eclipse tidied up some 
whitespace

--
[...truncated 179 lines...]
AU
apache-rat-core/src/test/java/org/apache/rat/analysis/AnalyserFactoryTest.java
A apache-rat-core/src/test/java/org/apache/rat/analysis/generation
AU
apache-rat-core/src/test/java/org/apache/rat/analysis/generation/GeneratedLicenseNotRequiredTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/analysis/generation/JavaDocLicenseNotRequiredTest.java
A apache-rat-core/src/test/java/org/apache/rat/analysis/util
AU
apache-rat-core/src/test/java/org/apache/rat/analysis/util/MatcherMultiplexerTest.java
A apache-rat-core/src/test/java/org/apache/rat/walker
AU
apache-rat-core/src/test/java/org/apache/rat/walker/FileNameComparatorTest.java
A apache-rat-core/src/test/java/org/apache/rat/header
AU
apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherWithBeansTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/header/ArrayCharFilterTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/header/FilteringSequenceFactoryTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/header/SimpleCharFilter.java
A apache-rat-core/src/test/java/org/apache/rat/annotation
AU
apache-rat-core/src/test/java/org/apache/rat/annotation/TestLicenceAppender.java
AUapache-rat-core/src/test/java/org/apache/rat/ReportTest.java
A apache-rat-core/src/test/java/org/apache/rat/report
A apache-rat-core/src/test/java/org/apache/rat/report/xml
AUapache-rat-core/src/test/java/org/apache/rat/report/xml/XmlUtils.java
AU
apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/report/xml/MockXmlWriter.java
AU
apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportTest.java
A apache-rat-core/src/test/java/org/apache/rat/report/xml/writer
A apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/impl
A 
apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/impl/base
AU
apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/impl/base/XmlWriterTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java
A apache-rat-core/src/test/java/org/apache/rat/report/claim
A apache-rat-core/src/test/java/org/apache/rat/report/claim/impl
A apache-rat-core/src/test/java/org/apache/rat/report/claim/impl/xml
AU
apache-rat-core/src/test/java/org/apache/rat/report/claim/impl/xml/MockClaimReporter.java
A apache-rat-core/src/test/java/org/apache/rat/report/claim/util
A apache-rat-core/src/test/java/org/apache/rat/report/analyser
AU
apache-rat-core/src/test/java/org/apache/rat/ReportTransformerTest.java
A apache-rat-core/src/test/java/org/apache/rat/document
A apache-rat-core/src/test/java/org/apache/rat/document/impl
AU
apache-rat-core/src/test/java/org/apache/rat/document/impl/SingularFileDocumentTest.java
A apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser
AU
apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/ArchiveGuesserTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/NoteGuesserTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/GuessUtilsTest.java
A apache-rat-core/src/test/java/org/apache/rat/document/impl/util
AU
apache-rat-core/src/test/java/org/apache/rat/document/impl/util/DocumentAnalyserMultiplexerTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/document/MockLocation.java
AU
apache-rat-core/src/test/java/org/apache/rat/document/ToNameTransformerTest.java
AU
apache-rat-core/src/test/java/org/apache/rat/document/MockDocumentAnalyser.java
AU
apache-rat-core/src/test/java/org/apache/rat/document/MockDocument.java
A apache-rat-core/src/test/java/elements
A apache-rat-core/src/test/resources
A apache-rat-core/src/test/resources/artifacts
AUapache-rat-core/src/test/resources/artifacts/dummy.tar.gz
A apache-rat-core/src/test/resources/violations
AUapache-rat-core/src/test/resources/violations/bad.txt
A apache-rat-core/src/test/resources/violations/FilterTest.cs
A apache-rat-core/src/test/resources/javadocs
AUapache-rat-core/src/test/resources/javadocs/index.html
AUapache-rat-c