[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[
https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493073#comment-14493073
]
Christopher Tubbs commented on RAT-160:
---
I agree that {{**/build.log}} would be too much. A plain {{build.log}} should
be sufficient. maven-invoker-plugin does have the ability to suppress creating
build.log (that's my current workaround, but that information is too valuable
to make that permanent). I will file an issue to make the location of the
{{build.log}} file more configurable, or to put it in a different location by
default.
> Fails to ignore build.log created by maven-invoker-plugin
> -
>
> Key: RAT-160
> URL: https://issues.apache.org/jira/browse/RAT-160
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Christopher Tubbs
> Attachments: RAT-160-proposedPatch.txt
>
>
> When using maven-invoker-plugin to run integration-tests for a maven plugin
> project, maven-invoker-plugin creates a build.log file in the basedir for the
> project.
> This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this
> file in its build directory, rather than its basedir. Regardless, the
> apache-rat-plugin should ignore this build.log file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-161) Support exclusion of paths: "path/to/file.ext"
[ https://issues.apache.org/jira/browse/RAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493072#comment-14493072 ] Erik Erlandson commented on RAT-161: Philipp Ottlinger, it is OK with me to close the ticket. Supporting some kind of path-specific syntax seems like a useful feature to me, however as you say, the Spark ticket that raised the issue was resolved in some other way. I'm not aware of any other community motivation to pursue it. > Support exclusion of paths: "path/to/file.ext" > > > Key: RAT-161 > URL: https://issues.apache.org/jira/browse/RAT-161 > Project: Apache Rat > Issue Type: New Feature > Components: reports >Reporter: Erik Erlandson >Priority: Minor > Attachments: RAT-161.2.patch > > > It would be advantageous to be able to exclude specific files, e.g. > "path/to/file.ext" > The current '-E' feature cannot do this, as the filter patterns are only > applied to individual files as directory tree is traversed, so a filter will > never see "path/to/file.ext", only "path", "to" and "file.ext" > See for example: SPARK-1493 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-161) Support exclusion of paths: "path/to/file.ext"
[ https://issues.apache.org/jira/browse/RAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492925#comment-14492925 ] Philipp Ottlinger commented on RAT-161: --- [~eje] is the ticket still relevant? I see that SPARK-1493 is fixed. Does your request still make sense? To my mind it rather makes the exclusions configuration even more complex than it already is, which is why I'm in favour of closing your ticket. Thanks for feedback. > Support exclusion of paths: "path/to/file.ext" > > > Key: RAT-161 > URL: https://issues.apache.org/jira/browse/RAT-161 > Project: Apache Rat > Issue Type: New Feature > Components: reports >Reporter: Erik Erlandson >Priority: Minor > Attachments: RAT-161.2.patch > > > It would be advantageous to be able to exclude specific files, e.g. > "path/to/file.ext" > The current '-E' feature cannot do this, as the filter patterns are only > applied to individual files as directory tree is traversed, so a filter will > never see "path/to/file.ext", only "path", "to" and "file.ext" > See for example: SPARK-1493 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[
https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-160:
--
Attachment: RAT-160-proposedPatch.txt
Thanks for your example project. I've added some minor modification when
evaluating your bug report.
I'd personally file a bug in the maven-invoker-plugin to make the creation of a
logfile optional or to put it in a different location under /target as proposed
earlier. A build.log generated during maven-invoker-plugin runs should pollute
your project's basedir.
RAT puts it rat.txt under target as well.
On the other hand a fix is fairly easy to implement. Though I hesitate to add
{code}
**/build.log
{code}
to the default excludes.
Would a plain
{code}
build.log
{code} be okay for you?
> Fails to ignore build.log created by maven-invoker-plugin
> -
>
> Key: RAT-160
> URL: https://issues.apache.org/jira/browse/RAT-160
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Christopher Tubbs
> Attachments: RAT-160-proposedPatch.txt
>
>
> When using maven-invoker-plugin to run integration-tests for a maven plugin
> project, maven-invoker-plugin creates a build.log file in the basedir for the
> project.
> This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this
> file in its build directory, rather than its basedir. Regardless, the
> apache-rat-plugin should ignore this build.log file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-171:
--
Description:
h3. Context
The apache-rat-plugin ignores by default the .gitignore files. However, for
every file/pattern added to those files, an explicit exclusion must be set in
the plugin's configuration.
Given that git-ignored files won't be uploaded to the SCM and shouldn't be part
of a release, it would be nice that the apache-rat-plugin automatically
considered those git-ignored files as implicit exclusions.
h3. Implemented for
Currently implemented for the following soure code management systems:
* SVN
* Git
* Bazaar
* Mercurial and
* CVS.
h3. Example usage
You can configure parsing SCM ignore files by a environment variable
{code}
mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
{code}
or in your configuration section of apache-rat-maven plugin
{code}
true
{code}
This features is enabled by default.
In case you want to speed up the build you may disable it and set it to
{code}
false
{code}
.
was:
h3. Context
The apache-rat-plugin ignores by default the .gitignore files. However, for
every file/pattern added to those files, an explicit exclusion must be set in
the plugin's configuration.
Given that git-ignored files won't be uploaded to the SCM and shouldn't be part
of a release, it would be nice that the apache-rat-plugin automatically
considered those git-ignored files as implicit exclusions.
h3. Implemented for
Currently implemented for the following soure code management systems:
* SVN
* Git
* Bazaar
* Mercurial and
* CVS.
h3. Example usage
You can configure parsing SCM ignore files by a environment variable
{code}
mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
{code}
or in your configuration section of apache-rat-maven plugin
{code}
true
This features is enabled by default.
In case you want to speed up the build you may disable it and set it to false.
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: New Feature
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Fix For: 0.12
>
> Attachments: RAT-171.patch
>
>
> h3. Context
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
> h3. Implemented for
> Currently implemented for the following soure code management systems:
> * SVN
> * Git
> * Bazaar
> * Mercurial and
> * CVS.
> h3. Example usage
> You can configure parsing SCM ignore files by a environment variable
> {code}
> mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
> {code}
> or in your configuration section of apache-rat-maven plugin
> {code}
> true
> {code}
> This features is enabled by default.
> In case you want to speed up the build you may disable it and set it to
> {code}
> false
> {code}
> .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger resolved RAT-171.
---
Resolution: Fixed
Fix Version/s: 0.12
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: New Feature
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Fix For: 0.12
>
> Attachments: RAT-171.patch
>
>
> h3. Context
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
> h3. Implemented for
> Currently implemented for the following soure code management systems:
> * SVN
> * Git
> * Bazaar
> * Mercurial and
> * CVS.
> h3. Example usage
> You can configure parsing SCM ignore files by a environment variable
> {code}
> mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
> {code}
> or in your configuration section of apache-rat-maven plugin
> {code}
> true
> This features is enabled by default.
> In case you want to speed up the build you may disable it and set it to false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492848#comment-14492848
]
Philipp Ottlinger commented on RAT-171:
---
Thanks for your feedback - I've enabled the feature by default and added some
more documentation and an integration test that generates parsing errors to
proof the features usability on user-generated input.
Done in [1673261|http://svn.apache.org/r1673261]
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: New Feature
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Fix For: 0.12
>
> Attachments: RAT-171.patch
>
>
> h3. Context
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
> h3. Implemented for
> Currently implemented for the following soure code management systems:
> * SVN
> * Git
> * Bazaar
> * Mercurial and
> * CVS.
> h3. Example usage
> You can configure parsing SCM ignore files by a environment variable
> {code}
> mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
> {code}
> or in your configuration section of apache-rat-maven plugin
> {code}
> true
> This features is enabled by default.
> In case you want to speed up the build you may disable it and set it to false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-171:
--
Description:
h3. Context
The apache-rat-plugin ignores by default the .gitignore files. However, for
every file/pattern added to those files, an explicit exclusion must be set in
the plugin's configuration.
Given that git-ignored files won't be uploaded to the SCM and shouldn't be part
of a release, it would be nice that the apache-rat-plugin automatically
considered those git-ignored files as implicit exclusions.
h3. Implemented for
Currently implemented for the following soure code management systems:
* SVN
* Git
* Bazaar
* Mercurial and
* CVS.
h3. Example usage
You can configure parsing SCM ignore files by a environment variable
{code}
mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
{code}
or in your configuration section of apache-rat-maven plugin
{code}
true
This features is enabled by default.
In case you want to speed up the build you may disable it and set it to false.
was:
The apache-rat-plugin ignores by default the .gitignore files. However, for
every file/pattern added to those files, an explicit exclusion must be set in
the plugin's configuration.
Given that git-ignored files won't be uploaded to the SCM and shouldn't be part
of a release, it would be nice that the apache-rat-plugin automatically
considered those git-ignored files as implicit exclusions.
h3. Example usage
Either configure parsing SCM ignore files by a environment variable
{code}
mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
{code}
or in your configuration section of apache-rat-maven plugin
{code}
true
This features is enabled by default.
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: New Feature
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Attachments: RAT-171.patch
>
>
> h3. Context
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
> h3. Implemented for
> Currently implemented for the following soure code management systems:
> * SVN
> * Git
> * Bazaar
> * Mercurial and
> * CVS.
> h3. Example usage
> You can configure parsing SCM ignore files by a environment variable
> {code}
> mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
> {code}
> or in your configuration section of apache-rat-maven plugin
> {code}
> true
> This features is enabled by default.
> In case you want to speed up the build you may disable it and set it to false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-157) Use the *ignore file for the SCM to determine excludes
[ https://issues.apache.org/jira/browse/RAT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492833#comment-14492833 ] Philipp Ottlinger commented on RAT-157: --- Your request is implemented via RAT-171 and RAT-172 for the following soure code management systems: * SVN * Git * Bazaar * Mercurial and * CVS. > Use the *ignore file for the SCM to determine excludes > -- > > Key: RAT-157 > URL: https://issues.apache.org/jira/browse/RAT-157 > Project: Apache Rat > Issue Type: New Feature >Reporter: lucas theisen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.12 > > > As I understand it, RAT is used to ensure the LICENSE text is in all source > files. Anything ignored by SCM is not technically a source file. These > other files are usually specific to the developer environment. And the > developer will already be adding such files to their own `SCMignore`. > Perhaps a pluggable ingore mechanism that could have an implementation per > SCM and would know how to parse that ignore and translate filter out all the > files it specifies. Perhaps this could be an option to the the rat config > `useGitIgnore` or something. What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (RAT-157) Use the *ignore file for the SCM to determine excludes
[ https://issues.apache.org/jira/browse/RAT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger resolved RAT-157. --- Resolution: Fixed Assignee: Philipp Ottlinger > Use the *ignore file for the SCM to determine excludes > -- > > Key: RAT-157 > URL: https://issues.apache.org/jira/browse/RAT-157 > Project: Apache Rat > Issue Type: New Feature >Reporter: lucas theisen >Assignee: Philipp Ottlinger >Priority: Minor > > As I understand it, RAT is used to ensure the LICENSE text is in all source > files. Anything ignored by SCM is not technically a source file. These > other files are usually specific to the developer environment. And the > developer will already be adding such files to their own `SCMignore`. > Perhaps a pluggable ingore mechanism that could have an implementation per > SCM and would know how to parse that ignore and translate filter out all the > files it specifies. Perhaps this could be an option to the the rat config > `useGitIgnore` or something. What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-157) Use the *ignore file for the SCM to determine excludes
[ https://issues.apache.org/jira/browse/RAT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-157: -- Fix Version/s: 0.12 > Use the *ignore file for the SCM to determine excludes > -- > > Key: RAT-157 > URL: https://issues.apache.org/jira/browse/RAT-157 > Project: Apache Rat > Issue Type: New Feature >Reporter: lucas theisen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.12 > > > As I understand it, RAT is used to ensure the LICENSE text is in all source > files. Anything ignored by SCM is not technically a source file. These > other files are usually specific to the developer environment. And the > developer will already be adding such files to their own `SCMignore`. > Perhaps a pluggable ingore mechanism that could have an implementation per > SCM and would know how to parse that ignore and translate filter out all the > files it specifies. Perhaps this could be an option to the the rat config > `useGitIgnore` or something. What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-171:
--
Description:
The apache-rat-plugin ignores by default the .gitignore files. However, for
every file/pattern added to those files, an explicit exclusion must be set in
the plugin's configuration.
Given that git-ignored files won't be uploaded to the SCM and shouldn't be part
of a release, it would be nice that the apache-rat-plugin automatically
considered those git-ignored files as implicit exclusions.
h3. Example usage
Either configure parsing SCM ignore files by a environment variable
{code}
mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
{code}
or in your configuration section of apache-rat-maven plugin
{code}
true
This features is enabled by default.
was:
The apache-rat-plugin ignores by default the .gitignore files. However, for
every file/pattern added to those files, an explicit exclusion must be set in
the plugin's configuration.
Given that git-ignored files won't be uploaded to the SCM and shouldn't be part
of a release, it would be nice that the apache-rat-plugin automatically
considered those git-ignored files as implicit exclusions.
h3. Example usage
Either configure parsing SCM ignore files by a environment variable
{code}
mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
{code}
or in your configuration section of apache-rat-maven plugin
{code}
true
As if now this feature is not enabled by default.
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: New Feature
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Attachments: RAT-171.patch
>
>
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
> h3. Example usage
> Either configure parsing SCM ignore files by a environment variable
> {code}
> mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
> {code}
> or in your configuration section of apache-rat-maven plugin
> {code}
> true
> This features is enabled by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492233#comment-14492233
]
Ignasi Barrera commented on RAT-171:
Tested version 0.12-SNAPSHOT and works like a charm. Thanks [~hugo.hirsch]!
SCM ignored files are not checked into the SCM, and are not part of an Apache
release, so I think it is safe to make the feature enabled by default.
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: New Feature
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Attachments: RAT-171.patch
>
>
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
> h3. Example usage
> Either configure parsing SCM ignore files by a environment variable
> {code}
> mvn -U -debug -Drat.parseSCMIgnoresAsExcludes=true
> {code}
> or in your configuration section of apache-rat-maven plugin
> {code}
> true
> As if now this feature is not enabled by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
