[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781224#comment-17781224 ] Jean-Baptiste Onofré commented on RAT-325: -- I'm doing a new pass to be more precise on the change. I will do a test by removing the SPDX feature to narrow the issue. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
jbonofre commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1786512973 @ottlinger sure, I will :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: fyi: INFRA-25131 - Trying to change Creadur's Jira configuration
Hi Phil, Thanks ! Much appreciated. Regards JB On Mon, Oct 30, 2023 at 11:06 PM P. Ottlinger wrote: > > Hi *, > > I've filed https://issues.apache.org/jira/browse/INFRA-25131 in order to > ask how to allow non-pmc members to be issue assignees. > > This would make it easier to file an issue and work on it in order to > properly map any Github PRs with ASF-Jira issues. > > Just fyi & thanks for your interest in RAT et.al. > > Cheers, > Phil
fyi: INFRA-25131 - Trying to change Creadur's Jira configuration
Hi *, I've filed https://issues.apache.org/jira/browse/INFRA-25131 in order to ask how to allow non-pmc members to be issue assignees. This would make it easier to file an issue and work on it in order to properly map any Github PRs with ASF-Jira issues. Just fyi & thanks for your interest in RAT et.al. Cheers, Phil OpenPGP_signature.asc Description: OpenPGP digital signature
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781128#comment-17781128 ] Philipp Ottlinger commented on RAT-325: --- [~claud...@users.sourceforge.net] I assume the performance degradation is due to the new SPDX feature would it help to enable SPDX-scanning as a configuration parameter? > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Call for Presentations now open: Community over Code EU 2024
(Note: You are receiving this because you are subscribed to the dev@ list for one or more projects of the Apache Software Foundation.) It's back *and* it's new! We're excited to announce that the first edition of Community over Code Europe (formerly known as ApacheCon EU) which will be held at the Radisson Blu Carlton Hotel in Bratislava, Slovakia from June 03-05, 2024! This eagerly anticipated event will be our first live EU conference since 2019. The Call for Presentations (CFP) for Community Over Code EU 2024 is now open at https://eu.communityovercode.org/blog/cfp-open/, and will close 2024/01/12 23:59:59 GMT. We welcome submissions on any topic related to the Apache Software Foundation, Apache projects, or the communities around those projects. We are specifically looking for presentations in the following categories: * API & Microservices * Big Data Compute * Big Data Storage * Cassandra * CloudStack * Community * Data Engineering * Fintech * Groovy * Incubator * IoT * Performance Engineering * Search * Tomcat, Httpd and other servers Additionally, we are thrilled to introduce a new feature this year: a poster session. This addition will provide an excellent platform for showcasing high-level projects and incubator initiatives in a visually engaging manner. We believe this will foster lively discussions and facilitate networking opportunities among participants. All my best, and thanks so much for your participation, Ryan Skraba (on behalf of the program committee) [Countdown]: https://www.timeanddate.com/countdown/to?iso=20240112T2359&p0=1440
[jira] [Updated] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated RAT-325: - Description: While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than with 0.15. I'm investigating why. was: While testing 0.16-SNAPSHOT, I identified rat is way longer to execute than with 0.15. I'm investigating why. > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.16 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781062#comment-17781062
]
Jean-Baptiste Onofré commented on RAT-325:
--
With rat 0.16-SNAPSHOT:
{code:java}
44.53s user 0.51s system 103% cpu 43.501 total {code}
With rat 0.15:
{code:java}
2.25s user 0.33s system 279% cpu 0.923 total {code}
On the same machine, same JVM, same directory scanned.
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.16
>
>
> While testing 0.16-SNAPSHOT, I identified rat is way longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-326) Fix javadoc errors
[ https://issues.apache.org/jira/browse/RAT-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781057#comment-17781057 ] Jean-Baptiste Onofré commented on RAT-326: -- I fixed some in my PRs. I'm tackling this one (and also fixing some typos in comments). > Fix javadoc errors > -- > > Key: RAT-326 > URL: https://issues.apache.org/jira/browse/RAT-326 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.16 >Reporter: Claude Warren >Priority: Minor > > Build scripts report javadoc errors. For example: > > Warning: Javadoc Warnings > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java:84: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:339: > warning - Tag @see: can't find setAddingLicenses(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:371: > warning - Tag @see: can't find setAddingLicensesForced(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:217: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:252: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:431: > warning - @param argument "a" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:107: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:116: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:38: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:104: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:116: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "58" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see: reference not found: [https://spdx.dev/ids/] > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:117: > warning - Tag @link: can't find addStyleSheet(File) in > org.apache.rat.anttasks.Report -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1376539769
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory,
ReportConfiguration config) {
-try (PrintStream out = new PrintStream(config.getOutput().get())) {
-File base = new File(baseDirectory);
-if (!base.exists()) {
-out.print("ERROR: ");
-out.print(baseDirectory);
-out.print(" does not exist.\n");
-return null;
-}
+File base = new File(baseDirectory);
Review Comment:
FYI, `getDirectory()` method doesn't cleanly close the `Writer` from config,
e.g. we have a bug: nothing is printed to `System.out`.
This change here fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
jbonofre opened a new pull request, #161: URL: https://github.com/apache/creadur-rat/pull/161 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (RAT-326) Fix javadoc errors
Claude Warren created RAT-326: - Summary: Fix javadoc errors Key: RAT-326 URL: https://issues.apache.org/jira/browse/RAT-326 Project: Apache Rat Issue Type: Bug Components: site Affects Versions: 0.16 Reporter: Claude Warren Build scripts report javadoc errors. For example: Warning: Javadoc Warnings Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java:84: warning - @return tag has no arguments. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:339: warning - Tag @see: can't find setAddingLicenses(boolean) in org.apache.rat.ReportConfiguration Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:371: warning - Tag @see: can't find setAddingLicensesForced(boolean) in org.apache.rat.ReportConfiguration Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:217: warning - @param argument "license" is not a parameter name. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:252: warning - @param argument "license" is not a parameter name. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:431: warning - @param argument "a" is not a parameter name. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:107: warning - @param argument "name" is not a parameter name. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:116: warning - @param argument "name" is not a parameter name. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:38: warning - @return tag has no arguments. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:104: warning - @return tag has no arguments. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:116: warning - @return tag has no arguments. Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: warning - Tag @see:illegal character: "58" in "[https://spdx.dev/ids/]"; Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: warning - Tag @see: reference not found: [https://spdx.dev/ids/] Warning: /home/runner/work/creadur-rat/creadur-rat/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:117: warning - Tag @link: can't find addStyleSheet(File) in org.apache.rat.anttasks.Report -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
ottlinger commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1785002625 @jbonofre can you add an entry in the changelog? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-320) Add a command line option to output to a file.
[ https://issues.apache.org/jira/browse/RAT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780954#comment-17780954 ] Jean-Baptiste Onofré commented on RAT-320: -- [~claude] [~pottlinger] do you mind guys to assign this Jira to me (as I'm working on this one) ? > Add a command line option to output to a file. > -- > > Key: RAT-320 > URL: https://issues.apache.org/jira/browse/RAT-320 > Project: Apache Rat > Issue Type: Improvement > Components: cli >Affects Versions: 0.15 >Reporter: Claude Warren >Priority: Minor > > Currently the only way to capture output is to pipe it to a file. When > working in the codebase it is often necessary to review the output of a run, > adding the ability to pipe the output of the command line to a file is simple > and assistive. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-322) Add possibility to be able to scan objects in hidden directories
[
https://issues.apache.org/jira/browse/RAT-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780953#comment-17780953
]
Jean-Baptiste Onofré commented on RAT-322:
--
[~pottlinger] do you mind to assign this Jira to me ? Thanks !
> Add possibility to be able to scan objects in hidden directories
>
>
> Key: RAT-322
> URL: https://issues.apache.org/jira/browse/RAT-322
> Project: Apache Rat
> Issue Type: New Feature
> Components: cli, maven
>Affects Versions: 0.15
>Reporter: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.16
>
>
> Currently, the {{DirectoryWalker}} tests if a directory is "restricted":
> [https://github.com/apache/creadur-rat/blob/master/apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java#L71]
> Restricted means a directory starting with . e.g. a hidden directory:
> [https://github.com/apache/creadur-rat/blob/master/apache-rat-core/src/main/java/org/apache/rat/walker/Walker.java#L52]
> The problem is that rat doesn't scan files in *ANY* hidden directory.
> We should add a flag to scan hidden directories (the user can decide to
> bypass the hidden directories or not) and let the user eventually define
> excludes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (RAT-325) Performance degradation compared to 0.15
Jean-Baptiste Onofré created RAT-325: Summary: Performance degradation compared to 0.15 Key: RAT-325 URL: https://issues.apache.org/jira/browse/RAT-325 Project: Apache Rat Issue Type: Bug Components: cli Affects Versions: 0.16 Reporter: Jean-Baptiste Onofré Fix For: 0.16 While testing 0.16-SNAPSHOT, I identified rat is way longer to execute than with 0.15. I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-320) Add a command line option to output to a file.
[ https://issues.apache.org/jira/browse/RAT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780950#comment-17780950 ] Jean-Baptiste Onofré commented on RAT-320: -- It would be great to include this in next release (0.16). > Add a command line option to output to a file. > -- > > Key: RAT-320 > URL: https://issues.apache.org/jira/browse/RAT-320 > Project: Apache Rat > Issue Type: Improvement > Components: cli >Affects Versions: 0.15 >Reporter: Claude Warren >Priority: Minor > > Currently the only way to capture output is to pipe it to a file. When > working in the codebase it is often necessary to review the output of a run, > adding the ability to pipe the output of the command line to a file is simple > and assistive. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-320) Add a command line option to output to a file.
[ https://issues.apache.org/jira/browse/RAT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780948#comment-17780948 ] Jean-Baptiste Onofré commented on RAT-320: -- I'm on it as it need it :) > Add a command line option to output to a file. > -- > > Key: RAT-320 > URL: https://issues.apache.org/jira/browse/RAT-320 > Project: Apache Rat > Issue Type: Improvement > Components: cli >Affects Versions: 0.15 >Reporter: Claude Warren >Priority: Minor > > Currently the only way to capture output is to pipe it to a file. When > working in the codebase it is often necessary to review the output of a run, > adding the ability to pipe the output of the command line to a file is simple > and assistive. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
jbonofre commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1784902812 I quickly discussed with @Claudenw on Slack. I think it's aligned. As I detected issue in missing ASF headers in files located in hidden directories, it would be great to release a new rat version including this improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
jbonofre commented on code in PR #160:
URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1375978739
##
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##
@@ -194,7 +195,7 @@ public void addLicense(ILicense license) {
* Adds multiple licenses to the list of licenses. Does not add the
licenses to
* the list of approved licenses.
*
- * @param license The license t oadd.
+ * @param licenses The licenses to odd.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
ottlinger commented on code in PR #160:
URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1375938723
##
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##
@@ -194,7 +195,7 @@ public void addLicense(ILicense license) {
* Adds multiple licenses to the list of licenses. Does not add the
licenses to
* the list of approved licenses.
*
- * @param license The license t oadd.
+ * @param licenses The licenses to odd.
Review Comment:
to add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
ottlinger commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-178486 @Claudenw is this in sync with what you proposed in RAT-323? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
jbonofre commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1784632099 @ottlinger As discussed in Jira 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]
jbonofre opened a new pull request, #160: URL: https://github.com/apache/creadur-rat/pull/160 * add support to scan hidden directories flag to `DirectoryWalker` * add scan hidden directories to the `ReportConfiguration` * cleanup `Walker` moving `isRestricted` to the `DirectoryWalker` as it's specific * expose scan hidden directories configuration in CLI, Ant task and Maven plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
