Re: [PR] Bump loggerVersion from 2.20.0 to 2.22.0 [creadur-tentacles]
ottlinger merged PR #93: URL: https://github.com/apache/creadur-tentacles/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RAT-337 - Apache Creadur Rat - GitHub Action
Sorry for the late response. I just returned from vacation and joined the mailing list. This is a response to the last comments from the JIRA ticket: https://issues.apache.org/jira/browse/RAT-337 *1.) Rather than pulling the repo in (which would, most likely, involve the Incubator (in other words: All kinds of bureaucratic processes), I suggest that we simply copy the files action.yml, json.xsl, and possibly README.md.* I think transferring a repo should not be that complicated. There are only four files. I already appended the *Apache-2.0* licenses headers to each file. The only file missing, if needed, is the NOTICE file. Technically, we could create a new repository using the *ASF Self-serve. *I could then submit a PR with these files. I believe we can retain the commit history by merging without squashing. *2.) The main question for me is the target: Could we simply import these files into our main repository, or do we really need a separate repository within Github?* Maybe the content could be imported to the main repository, but you would need to figure out how you want to manage the tags. All other Actions use the following tag naming convention. v1 v1.0.0 v1.0.1 v2 v2.0.0 v2.1.0 E.g. - https://github.com/actions/setup-node - https://github.com/microsoft/setup-msbuild Basically *v1* and *v2 *will represent the latest version of that major release. With ever new minor or patch version, we force update the v tag with the latest commit id. This allows peoples to fetch the latest major version automatically without updating their workflow. Looking at the current tags in *apache/creadur-rat* repo, I am not sure if introducing these tags will confuse anyone, so I feel a new repo could be better? I never saw an action tag starting at v0 but maybe its not an issue. Then it could be inline with rat's release versions. v0 v0.15.0 The *action.yml* file would have to live in the *root *directory. The other files could be in its own folder but we would have to update the yml file appropriately. *If the latter, we could probably ask Infra for a second repository within the ASF, with an associated mirror on Github,* For the Apache Cordova project, which I am a part of, all of our ASF repos are mirrored on GitHub. I thought this was a default setting, but I could be wrong. Last time I created a new repo with the *ASF Self-serve,* I believe it was mirrored to GitHub for us. I* am leaning more towards a separate repo* because I don't think it's necessary for CI run to checkout the entire Apache Rat repo on every run. Depending on how the GitHub Action workflow is configured, it could run on every commit and to checkout the entire repo on every commit could be excessive. Though I do not believe the repo is that large. Another reason prefered on GitHub is because I never saw or tried to import from an external repo service. It might be possible with a full git URL path.
[jira] [Updated] (RAT-336) Use assertj in RAT tests
[ https://issues.apache.org/jira/browse/RAT-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated RAT-336: - Fix Version/s: 0.17 (was: 0.16) > Use assertj in RAT tests > > > Key: RAT-336 > URL: https://issues.apache.org/jira/browse/RAT-336 > Project: Apache Rat > Issue Type: Improvement > Components: build >Affects Versions: 0.15 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > As discussed during RAT-322 fix, I will refactore all tests to use assertj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated RAT-325: - Fix Version/s: 0.17 (was: 0.16) > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: RAT-337 - Apache Creadur Rat - GitHub Action
Hi Bryan, Am 12.12.23 um 14:02 schrieb Bryan Ellis: > Sorry for the late response. > > I just returned from vacation and joined the mailing list. > > > This is a response to the last comments from the JIRA ticket: > https://issues.apache.org/jira/browse/RAT-337 thanks again for your contribution, idea and all the technical details - I'd like to step a little bit back and change the perspective. Creadur is a rather small PMC at the moment. Ingesting a new artifact would mean that we should/could/want to support this artifact .. * is there a downstream interest in having such an action? * would this be a good way to leave the ASF-centric eco-system (dominated by Maven & Ant-based consumers)? * are there other general issues that need to be concerned? @all: WDYT? Thanks, Phil OpenPGP_signature.asc Description: OpenPGP digital signature
[jira] [Commented] (RAT-326) Fix javadoc errors
[ https://issues.apache.org/jira/browse/RAT-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795929#comment-17795929 ] ASF subversion and git services commented on RAT-326: - Commit c3106cac76e4a792205032ebd64cc0fba15c6f31 in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=c3106cac ] RAT-326: Fix javadoc build errors > Fix javadoc errors > -- > > Key: RAT-326 > URL: https://issues.apache.org/jira/browse/RAT-326 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16 > > > Build scripts report javadoc errors and warnings. For example: > h1. Javadoc errors > * broken markup > > h1. Warnings > Warning: Javadoc Warnings > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java:84: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:339: > warning - Tag @see: can't find setAddingLicenses(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:371: > warning - Tag @see: can't find setAddingLicensesForced(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:217: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:252: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:431: > warning - @param argument "a" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:107: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:116: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:38: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:104: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:116: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "58" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see: reference not found: [https://spdx.dev/ids/] > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:117: > warning - Tag @link: can't find addStyleSheet(File) in > org.apache.rat.anttasks.Report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-326) Fix javadoc errors
[ https://issues.apache.org/jira/browse/RAT-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795928#comment-17795928 ] ASF subversion and git services commented on RAT-326: - Commit f6aa0edffc7903abed51735b38695e1249ee27d0 in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=f6aa0edf ] RAT-326: Add explicit goal on GHA to break the build in case of javadoc errors > Fix javadoc errors > -- > > Key: RAT-326 > URL: https://issues.apache.org/jira/browse/RAT-326 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16 > > > Build scripts report javadoc errors and warnings. For example: > h1. Javadoc errors > * broken markup > > h1. Warnings > Warning: Javadoc Warnings > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java:84: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:339: > warning - Tag @see: can't find setAddingLicenses(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:371: > warning - Tag @see: can't find setAddingLicensesForced(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:217: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:252: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:431: > warning - @param argument "a" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:107: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:116: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:38: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:104: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:116: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "58" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see: reference not found: [https://spdx.dev/ids/] > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:117: > warning - Tag @link: can't find addStyleSheet(File) in > org.apache.rat.anttasks.Report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-326) Fix javadoc errors
[ https://issues.apache.org/jira/browse/RAT-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795927#comment-17795927 ] ASF subversion and git services commented on RAT-326: - Commit 4c6777ba0876e678ad76f90ac7a8f267017762d2 in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=4c6777ba ] RAT-326: Fix more javadoc build errors > Fix javadoc errors > -- > > Key: RAT-326 > URL: https://issues.apache.org/jira/browse/RAT-326 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16 > > > Build scripts report javadoc errors and warnings. For example: > h1. Javadoc errors > * broken markup > > h1. Warnings > Warning: Javadoc Warnings > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java:84: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:339: > warning - Tag @see: can't find setAddingLicenses(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:371: > warning - Tag @see: can't find setAddingLicensesForced(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:217: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:252: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:431: > warning - @param argument "a" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:107: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:116: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:38: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:104: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:116: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "58" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see: reference not found: [https://spdx.dev/ids/] > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:117: > warning - Tag @link: can't find addStyleSheet(File) in > org.apache.rat.anttasks.Report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-326) Fix javadoc errors
[ https://issues.apache.org/jira/browse/RAT-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795930#comment-17795930 ] ASF subversion and git services commented on RAT-326: - Commit e5dabb9063dbf7d685cceeaad25c76c8be390b4d in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=e5dabb90 ] RAT-326: Add changelog about introduction of javadoc:javadoc into GHA build > Fix javadoc errors > -- > > Key: RAT-326 > URL: https://issues.apache.org/jira/browse/RAT-326 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16 > > > Build scripts report javadoc errors and warnings. For example: > h1. Javadoc errors > * broken markup > > h1. Warnings > Warning: Javadoc Warnings > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java:84: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:339: > warning - Tag @see: can't find setAddingLicenses(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:371: > warning - Tag @see: can't find setAddingLicensesForced(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:217: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:252: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:431: > warning - @param argument "a" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:107: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:116: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:38: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:104: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:116: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "58" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see: reference not found: [https://spdx.dev/ids/] > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:117: > warning - Tag @link: can't find addStyleSheet(File) in > org.apache.rat.anttasks.Report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (RAT-326) Fix javadoc errors
[ https://issues.apache.org/jira/browse/RAT-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger resolved RAT-326. --- Resolution: Fixed Existing errors fixed. Introduced individual build step javadoc:javadoc on GHA in order to not introduce build errors. Problem with JDK17 remains; warnings should be fixed step by step. > Fix javadoc errors > -- > > Key: RAT-326 > URL: https://issues.apache.org/jira/browse/RAT-326 > Project: Apache Rat > Issue Type: Bug > Components: site >Affects Versions: 0.16 >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.16 > > > Build scripts report javadoc errors and warnings. For example: > h1. Javadoc errors > * broken markup > > h1. Warnings > Warning: Javadoc Warnings > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java:84: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:339: > warning - Tag @see: can't find setAddingLicenses(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:371: > warning - Tag @see: can't find setAddingLicensesForced(boolean) in > org.apache.rat.ReportConfiguration > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:217: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:252: > warning - @param argument "license" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:431: > warning - @param argument "a" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:107: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/Format.java:116: > warning - @param argument "name" is not a parameter name. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:38: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:104: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/license/LicenseFamilySetFactory.java:116: > warning - @return tag has no arguments. > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "58" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see:illegal character: "47" in "[https://spdx.dev/ids/]"; > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-core/src/main/java/org/apache/rat/analysis/matchers/SPDXMatcherFactory.java:42: > warning - Tag @see: reference not found: [https://spdx.dev/ids/] > > Warning: > /home/runner/work/creadur-rat/creadur-rat/apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:117: > warning - Tag @link: can't find addStyleSheet(File) in > org.apache.rat.anttasks.Report -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: RAT-337 - Apache Creadur Rat - GitHub Action
** is there a downstream interest in having such an action?* Could create a survey and see if ASF can share it with the other projects? Might help with getting an understanding if they would find it beneficial. ** would this be a good way to leave the ASF-centric eco-system (dominated by Maven & Ant-based consumers)?* I don't know the percentage of projects that are, or not, Maven/Ant-based, but Apache Cordova is not Maven/Ant-based. The majority of our code is JavaScript. We use the Rat CLI tool (JAR) and run it against all files to ensure license compliance. This proves that Rat is, and can be, used outside of Maven/Ant. ** are there other general issues that need to be concerned?* I don't think it's a concern, but will a PMC vote be required when releasing a new tag for the action? The only change between tags is the default version of the Rat binary to download and use. The Rat CLI tool would have already gone through the voting process. I suspect there is no need for an additional vote. On Wed, Dec 13, 2023 at 1:20 AM P. Ottlinger wrote: > Hi Bryan, > > Am 12.12.23 um 14:02 schrieb Bryan Ellis: > > Sorry for the late response. > > > > I just returned from vacation and joined the mailing list. > > > > > > This is a response to the last comments from the JIRA ticket: > > https://issues.apache.org/jira/browse/RAT-337 > > thanks again for your contribution, idea and all the technical details - > I'd like to step a little bit back and change the perspective. > > Creadur is a rather small PMC at the moment. > > Ingesting a new artifact would mean that we should/could/want to support > this artifact .. > > * is there a downstream interest in having such an action? > * would this be a good way to leave the ASF-centric eco-system > (dominated by Maven & Ant-based consumers)? > * are there other general issues that need to be concerned? > > @all: WDYT? > > Thanks, > Phil > >
