[PR] Bump org.apache:apache from 31 to 32 [creadur-whisker]

2024-04-16 Thread via GitHub


dependabot[bot] opened a new pull request, #139:
URL: https://github.com/apache/creadur-whisker/pull/139

   Bumps [org.apache:apache](https://github.com/apache/maven-apache-parent) 
from 31 to 32.
   
   Release notes
   Sourced from https://github.com/apache/maven-apache-parent/releases;>org.apache:apache's
 releases.
   
   Apache Parent POM version 32
   Improvement
   
   [https://issues.apache.org/jira/browse/MPOM-264;>MPOM-264] 
- Parameterize maven-compiler-plugin with parameter release when 
running on JDK 9+
   [https://issues.apache.org/jira/browse/MPOM-452;>MPOM-452] 
- Apache Parent POM - Use property for Apache Repository IDs
   [https://issues.apache.org/jira/browse/MPOM-478;>MPOM-478] 
- Remove manually maintained history from site
   [https://issues.apache.org/jira/browse/MPOM-480;>MPOM-480] 
- Remove maven-site-plugin:attach-descriptor from ASF parent
   [https://issues.apache.org/jira/browse/MPOM-481;>MPOM-481] 
- Improve description of maven-gpg-plugin settings
   [https://issues.apache.org/jira/browse/MPOM-483;>MPOM-483] 
- Make a separate module for documentation
   [https://issues.apache.org/jira/browse/MPOM-486;>MPOM-486] 
- Enable autoVersionSubmodules for maven-release-plugin
   
   Task
   
   [https://issues.apache.org/jira/browse/MPOM-467;>MPOM-467] 
- Remove old property maven.plugin.tools.version
   
   Dependency upgrade
   
   [https://issues.apache.org/jira/browse/MPOM-456;>MPOM-456] 
- Bump surefire/failsafe from 3.2.2 to 3.2.5
   [https://issues.apache.org/jira/browse/MPOM-457;>MPOM-457] 
- Bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.13.0
   [https://issues.apache.org/jira/browse/MPOM-458;>MPOM-458] 
- Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.2 to 3.6.3
   [https://issues.apache.org/jira/browse/MPOM-465;>MPOM-465] 
- Bump org.apache.maven.plugins:maven-project-info-reports-plugin from 3.4.5 to 
3.5.0
   [https://issues.apache.org/jira/browse/MPOM-466;>MPOM-466] 
- Bump org.apache.rat:apache-rat-plugin from 0.15 to 0.16.1
   [https://issues.apache.org/jira/browse/MPOM-469;>MPOM-469] 
- Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.1 to 3.5.2
   [https://issues.apache.org/jira/browse/MPOM-470;>MPOM-470] 
- Bump org.apache.maven.plugins:maven-remote-resources-plugin from 3.1.0 to 
3.2.0
   [https://issues.apache.org/jira/browse/MPOM-471;>MPOM-471] 
- Bump org.apache.maven.plugins:maven-assembly-plugin from 3.6.0 to 3.7.1
   [https://issues.apache.org/jira/browse/MPOM-472;>MPOM-472] 
- Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.3
   [https://issues.apache.org/jira/browse/MPOM-475;>MPOM-475] 
- Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1
   [https://issues.apache.org/jira/browse/MPOM-476;>MPOM-476] 
- Bump version.maven-plugin-tools from 3.10.2 to 3.12.0
   [https://issues.apache.org/jira/browse/MPOM-479;>MPOM-479] 
- Bump org.apache.maven.plugins:maven-source-plugin from 3.3.0 to 3.3.1
   [https://issues.apache.org/jira/browse/MPOM-484;>MPOM-484] 
- Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0
   
   
   
   
   Commits
   
   See full diff in https://github.com/apache/maven-apache-parent/commits;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache:apache=maven=31=32)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - 

[PR] Bump org.apache:apache from 31 to 32 [creadur-rat]

2024-04-16 Thread via GitHub


dependabot[bot] opened a new pull request, #239:
URL: https://github.com/apache/creadur-rat/pull/239

   Bumps [org.apache:apache](https://github.com/apache/maven-apache-parent) 
from 31 to 32.
   
   Release notes
   Sourced from https://github.com/apache/maven-apache-parent/releases;>org.apache:apache's
 releases.
   
   Apache Parent POM version 32
   Improvement
   
   [https://issues.apache.org/jira/browse/MPOM-264;>MPOM-264] 
- Parameterize maven-compiler-plugin with parameter release when 
running on JDK 9+
   [https://issues.apache.org/jira/browse/MPOM-452;>MPOM-452] 
- Apache Parent POM - Use property for Apache Repository IDs
   [https://issues.apache.org/jira/browse/MPOM-478;>MPOM-478] 
- Remove manually maintained history from site
   [https://issues.apache.org/jira/browse/MPOM-480;>MPOM-480] 
- Remove maven-site-plugin:attach-descriptor from ASF parent
   [https://issues.apache.org/jira/browse/MPOM-481;>MPOM-481] 
- Improve description of maven-gpg-plugin settings
   [https://issues.apache.org/jira/browse/MPOM-483;>MPOM-483] 
- Make a separate module for documentation
   [https://issues.apache.org/jira/browse/MPOM-486;>MPOM-486] 
- Enable autoVersionSubmodules for maven-release-plugin
   
   Task
   
   [https://issues.apache.org/jira/browse/MPOM-467;>MPOM-467] 
- Remove old property maven.plugin.tools.version
   
   Dependency upgrade
   
   [https://issues.apache.org/jira/browse/MPOM-456;>MPOM-456] 
- Bump surefire/failsafe from 3.2.2 to 3.2.5
   [https://issues.apache.org/jira/browse/MPOM-457;>MPOM-457] 
- Bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.13.0
   [https://issues.apache.org/jira/browse/MPOM-458;>MPOM-458] 
- Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.2 to 3.6.3
   [https://issues.apache.org/jira/browse/MPOM-465;>MPOM-465] 
- Bump org.apache.maven.plugins:maven-project-info-reports-plugin from 3.4.5 to 
3.5.0
   [https://issues.apache.org/jira/browse/MPOM-466;>MPOM-466] 
- Bump org.apache.rat:apache-rat-plugin from 0.15 to 0.16.1
   [https://issues.apache.org/jira/browse/MPOM-469;>MPOM-469] 
- Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.1 to 3.5.2
   [https://issues.apache.org/jira/browse/MPOM-470;>MPOM-470] 
- Bump org.apache.maven.plugins:maven-remote-resources-plugin from 3.1.0 to 
3.2.0
   [https://issues.apache.org/jira/browse/MPOM-471;>MPOM-471] 
- Bump org.apache.maven.plugins:maven-assembly-plugin from 3.6.0 to 3.7.1
   [https://issues.apache.org/jira/browse/MPOM-472;>MPOM-472] 
- Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.3
   [https://issues.apache.org/jira/browse/MPOM-475;>MPOM-475] 
- Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1
   [https://issues.apache.org/jira/browse/MPOM-476;>MPOM-476] 
- Bump version.maven-plugin-tools from 3.10.2 to 3.12.0
   [https://issues.apache.org/jira/browse/MPOM-479;>MPOM-479] 
- Bump org.apache.maven.plugins:maven-source-plugin from 3.3.0 to 3.3.1
   [https://issues.apache.org/jira/browse/MPOM-484;>MPOM-484] 
- Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0
   
   
   
   
   Commits
   
   See full diff in https://github.com/apache/maven-apache-parent/commits;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache:apache=maven=31=32)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - 

Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]

2024-04-16 Thread via GitHub


ottlinger commented on PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2059927715

   In order to be able to bring changes intro master I'd prefer to configure 
limits per module with the current threshold, thus we could make sure that no 
new stuff is being added and can fix the errors in an incremental way - 
WDYT @Claudenw ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

2024-04-16 Thread via GitHub


ottlinger commented on code in PR #233:
URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1567942299


##
apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml:
##
@@ -59,7 +58,7 @@
   
 
   
-
+

Review Comment:
   I guess we should a not about the deprecation and the new attribute in:
   
https://github.com/apache/creadur-rat/blob/master/apache-rat-tasks/src/site/apt/report.apt



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]

2024-04-16 Thread via GitHub


ottlinger commented on PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2059919599

   @Claudenw in case of any errors the build fails. I'm not sure if it's that 
helpful or if we remove this setting on the branch . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837884#comment-17837884
 ] 

ASF subversion and git services commented on RAT-369:
-

Commit b23aac3e2e5ec0666eb577ba1f30ef0de6e7b77c in creadur-rat's branch 
refs/heads/feature/RAT-369 from Philipp Ottlinger
[ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=b23aac3e ]

RAT-369: Fail the build if there are any bugs


> Add SpotBugs to the pom files.
> --
>
> Key: RAT-369
> URL: https://issues.apache.org/jira/browse/RAT-369
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: Client - ant, Client - cli, Client - maven, core engine
>Reporter: Claude Warren
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.17
>
>
> Currently we have a number of issues that Spotbugs will detect.  I ran a 
> quick test this afternoon and it found 60 potential bugs.  This ticket is to 
> add spotbugs to the maven build, ensure that no bugs are found and ensure 
> that the build will fail if bugs are found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]

2024-04-16 Thread via GitHub


ottlinger opened a new pull request, #238:
URL: https://github.com/apache/creadur-rat/pull/238

   I verified locally (via ./.buildtools/generateStagingSiteInWebpageRepo) that 
a report is generated, but the build is not yet configured to fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837879#comment-17837879
 ] 

ASF subversion and git services commented on RAT-369:
-

Commit b404d02d2cdd33192e84a3cb100a165176626a48 in creadur-rat's branch 
refs/heads/feature/RAT-369 from Philipp Ottlinger
[ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=b404d02d ]

RAT-369: Add spotbugs to build and generate a report


> Add SpotBugs to the pom files.
> --
>
> Key: RAT-369
> URL: https://issues.apache.org/jira/browse/RAT-369
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: Client - ant, Client - cli, Client - maven, core engine
>Reporter: Claude Warren
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.17
>
>
> Currently we have a number of issues that Spotbugs will detect.  I ran a 
> quick test this afternoon and it found 60 potential bugs.  This ticket is to 
> add spotbugs to the maven build, ensure that no bugs are found and ensure 
> that the build will fail if bugs are found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

2024-04-16 Thread via GitHub


ottlinger commented on code in PR #233:
URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1567906675


##
apache-rat-tasks/pom.xml:
##
@@ -105,7 +105,7 @@
   
 
   
-  
+  

[jira] [Updated] (RAT-345) Dependency updates via dependabot performed for release 0.17

2024-04-16 Thread Philipp Ottlinger (Jira)


 [ 
https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philipp Ottlinger updated RAT-345:
--
Description: 
h1. Updates via dependabot in RAT 0.17

h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3
* https://github.com/apache/creadur-rat/pull/209 3.25.2
* https://github.com/apache/creadur-rat/pull/212 3.25.3

h2. (/) Update slf4j-simple from 2.0.11 to 2.0.13
* https://github.com/apache/creadur-rat/pull/213 2.0.12
* https://github.com/apache/creadur-rat/pull/237 2.0.13

h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2
* https://github.com/apache/creadur-rat/pull/211

h2. (/) Update junit.version from 5.10.1 to 5.10.2
* https://github.com/apache/creadur-rat/pull/210

h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0
* https://github.com/apache/creadur-rat/pull/214

h2. (/) Update commons-compress from 1.25.0 to 1.26.1
* https://github.com/apache/creadur-rat/pull/215 1.26.0
* https://github.com/apache/creadur-rat/pull/220 1.26.1

h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0
* https://github.com/apache/creadur-rat/pull/219 3.2.0

h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0
* https://github.com/apache/creadur-rat/pull/218

h2. (/) Update actions/cache from 4.0.0 to 4.0.2
* https://github.com/apache/creadur-rat/pull/217 4.0.1
* https://github.com/apache/creadur-rat/pull/226 4.0.2

h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0
* https://github.com/apache/creadur-rat/pull/216 4.1.0
* https://github.com/apache/creadur-rat/pull/222 4.2.0

h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0
* https://github.com/apache/creadur-rat/pull/225

h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1
* https://github.com/apache/creadur-rat/pull/229/ 1.5.1

h2. (/) Update commons-io from 2.15.1 to 2.16.1
* https://github.com/apache/creadur-rat/pull/231 2.16.0
* https://github.com/apache/creadur-rat/pull/236 2.16.1

h2. (/) Update maven-invoker-plugin from 3.6.0 to 3.6.1.
* https://github.com/apache/creadur-rat/pull/234 3.6.1

h2. (/) Update org.apache.maven.plugin-tools:maven-plugin-annotations from 
3.11.0 to 3.12.0
* https://github.com/apache/creadur-rat/pull/235 3.12.0

h2. (/) Update 
h2. (/) Update 


h1. TODO before release
 * add changelog entries for each above PRs

  was:
h1. Updates via dependabot in RAT 0.17

h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3
* https://github.com/apache/creadur-rat/pull/209 3.25.2
* https://github.com/apache/creadur-rat/pull/212 3.25.3

h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12
* https://github.com/apache/creadur-rat/pull/213

h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2
* https://github.com/apache/creadur-rat/pull/211

h2. (/) Update junit.version from 5.10.1 to 5.10.2
* https://github.com/apache/creadur-rat/pull/210

h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0
* https://github.com/apache/creadur-rat/pull/214

h2. (/) Update commons-compress from 1.25.0 to 1.26.1
* https://github.com/apache/creadur-rat/pull/215 1.26.0
* https://github.com/apache/creadur-rat/pull/220 1.26.1

h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0
* https://github.com/apache/creadur-rat/pull/219 3.2.0

h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0
* https://github.com/apache/creadur-rat/pull/218

h2. (/) Update actions/cache from 4.0.0 to 4.0.2
* https://github.com/apache/creadur-rat/pull/217 4.0.1
* https://github.com/apache/creadur-rat/pull/226 4.0.2

h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0
* https://github.com/apache/creadur-rat/pull/216 4.1.0
* https://github.com/apache/creadur-rat/pull/222 4.2.0

h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0
* https://github.com/apache/creadur-rat/pull/225

h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1
* https://github.com/apache/creadur-rat/pull/229/ 1.5.1

h2. (/) Update commons-io from 2.15.1 to 2.16.1
* https://github.com/apache/creadur-rat/pull/231 2.16.0
* https://github.com/apache/creadur-rat/pull/236 2.16.1

h2. (/) Update maven-invoker-plugin from 3.6.0 to 3.6.1.
* https://github.com/apache/creadur-rat/pull/234 3.6.1

h2. (/) Update org.apache.maven.plugin-tools:maven-plugin-annotations from 
3.11.0 to 3.12.0
* https://github.com/apache/creadur-rat/pull/235 3.12.0

h2. (/) Update 
h2. (/) Update 


h1. TODO before release
 * add changelog entries for each above PRs


> Dependency updates via dependabot performed for release 0.17
> 
>
> Key: RAT-345
> URL: https://issues.apache.org/jira/browse/RAT-345
> Project: Apache Rat
>  Issue Type: Improvement
>Affects Versions: 0.16
>Reporter: Philipp Ottlinger
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.17
>
>
> h1. Updates via dependabot in RAT 0.17
> h2. (/) Update Bump 

Re: [PR] RAT-345: Bump org.slf4j:slf4j-simple from 2.0.12 to 2.0.13 [creadur-rat]

2024-04-16 Thread via GitHub


ottlinger merged PR #237:
URL: https://github.com/apache/creadur-rat/pull/237


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (RAT-369) Add SpotBugs to the pom files.

2024-04-16 Thread Philipp Ottlinger (Jira)


 [ 
https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philipp Ottlinger reassigned RAT-369:
-

Assignee: Philipp Ottlinger

> Add SpotBugs to the pom files.
> --
>
> Key: RAT-369
> URL: https://issues.apache.org/jira/browse/RAT-369
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: Client - ant, Client - cli, Client - maven, core engine
>Reporter: Claude Warren
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.17
>
>
> Currently we have a number of issues that Spotbugs will detect.  I ran a 
> quick test this afternoon and it found 60 potential bugs.  This ticket is to 
> add spotbugs to the maven build, ensure that no bugs are found and ensure 
> that the build will fail if bugs are found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.

2024-04-16 Thread Philipp Ottlinger (Jira)


[ 
https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837869#comment-17837869
 ] 

Philipp Ottlinger commented on RAT-369:
---

I'll add spotbugs on a branch and see if it breaks the build  maybe we can 
fix the problems on that branch as well.

> Add SpotBugs to the pom files.
> --
>
> Key: RAT-369
> URL: https://issues.apache.org/jira/browse/RAT-369
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: Client - ant, Client - cli, Client - maven, core engine
>Reporter: Claude Warren
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.17
>
>
> Currently we have a number of issues that Spotbugs will detect.  I ran a 
> quick test this afternoon and it found 60 potential bugs.  This ticket is to 
> add spotbugs to the maven build, ensure that no bugs are found and ensure 
> that the build will fail if bugs are found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (RAT-369) Add SpotBugs to the pom files.

2024-04-16 Thread Philipp Ottlinger (Jira)


 [ 
https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philipp Ottlinger updated RAT-369:
--
Fix Version/s: 0.17

> Add SpotBugs to the pom files.
> --
>
> Key: RAT-369
> URL: https://issues.apache.org/jira/browse/RAT-369
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: Client - ant, Client - cli, Client - maven, core engine
>Reporter: Claude Warren
>Priority: Major
> Fix For: 0.17
>
>
> Currently we have a number of issues that Spotbugs will detect.  I ran a 
> quick test this afternoon and it found 60 potential bugs.  This ticket is to 
> add spotbugs to the maven build, ensure that no bugs are found and ensure 
> that the build will fail if bugs are found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RAT-369) Add SpotBugs to the pom files.

2024-04-16 Thread Claude Warren (Jira)
Claude Warren created RAT-369:
-

 Summary: Add SpotBugs to the pom files.
 Key: RAT-369
 URL: https://issues.apache.org/jira/browse/RAT-369
 Project: Apache Rat
  Issue Type: Improvement
  Components: Client - ant, Client - cli, Client - maven, core engine
Reporter: Claude Warren


Currently we have a number of issues that Spotbugs will detect.  I ran a quick 
test this afternoon and it found 60 potential bugs.  This ticket is to add 
spotbugs to the maven build, ensure that no bugs are found and ensure that the 
build will fail if bugs are found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (RAT-368) Removed unused classes

2024-04-16 Thread Claude Warren (Jira)


 [ 
https://issues.apache.org/jira/browse/RAT-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claude Warren reassigned RAT-368:
-

Assignee: Claude Warren

> Removed unused classes
> --
>
> Key: RAT-368
> URL: https://issues.apache.org/jira/browse/RAT-368
> Project: Apache Rat
>  Issue Type: Improvement
>  Components: core engine
>Affects Versions: 0.16.1
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> There are several classes/interfaces that are either  unused or only used 
> within a set of classes/interfaces that are otherwise unused.  They should be 
> removed from the system.
> In core the following files are unused
>  * ReportTransformer, ReportFailedRuntimeException, ReportTransformerTest are 
> mutually used but not by any class/interface outside the 3.
>  * RatReportAnalysisResultException
>  * FullTestMatchingLicense – used in old style license definition
>  * SimplePatternBasedLicense – used in old style license definition
>  * MimeTyper
>  * ToNameTransformer, ToNameTransformerTest
>  * UnsuitableDocumentException
>  * o.a.rat.header all classes/interfaces in this package are mutually used 
> but not by any class outside the package.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RAT-368) Removed unused classes

2024-04-16 Thread Claude Warren (Jira)
Claude Warren created RAT-368:
-

 Summary: Removed unused classes
 Key: RAT-368
 URL: https://issues.apache.org/jira/browse/RAT-368
 Project: Apache Rat
  Issue Type: Improvement
  Components: core engine
Affects Versions: 0.16.1
Reporter: Claude Warren


There are several classes/interfaces that are either  unused or only used 
within a set of classes/interfaces that are otherwise unused.  They should be 
removed from the system.

In core the following files are unused
 * ReportTransformer, ReportFailedRuntimeException, ReportTransformerTest are 
mutually used but not by any class/interface outside the 3.
 * RatReportAnalysisResultException
 * FullTestMatchingLicense – used in old style license definition
 * SimplePatternBasedLicense – used in old style license definition
 * MimeTyper
 * ToNameTransformer, ToNameTransformerTest
 * UnsuitableDocumentException
 * o.a.rat.header all classes/interfaces in this package are mutually used but 
not by any class outside the package.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)