[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839428#comment-17839428 ] ASF subversion and git services commented on RAT-369: - Commit 706732f4f51be9f66c94c727a5c5004e1bae4809 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=706732f4 ] RAT-369: Add tweak info about subpackage syntax > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839424#comment-17839424 ] ASF subversion and git services commented on RAT-369: - Commit d929953b559e7fbd0a89295066d1d0228854ab58 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=d929953b ] RAT-369: Fix spotbugs warning > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839425#comment-17839425 ] ASF subversion and git services commented on RAT-369: - Commit 39cb8b14b63abd4a11981fc0242638d7d99d199c in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=39cb8b14 ] RAT-369: Tweak config and add exclusion files in submodules > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839422#comment-17839422 ] ASF subversion and git services commented on RAT-369: - Commit a9169510d667f5c9e2bcf70115fdcc2451b92091 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=a9169510 ] RAT-369: Ignore false positive > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839421#comment-17839421 ] ASF subversion and git services commented on RAT-369: - Commit 191b119bb0edc37d79ad806d0f29cc614520b9e8 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=191b119b ] RAT-369: Issue errors but do not fail the build in order to work incrementally > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839418#comment-17839418 ] ASF subversion and git services commented on RAT-369: - Commit 7fee5e229ccae9c1e4b7a47d099865908744e273 in creadur-rat's branch refs/heads/feature/RAT-369 from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=7fee5e22 ] RAT-369: Fix reliance on default encoding in some JDK8-compliant settings > Add SpotBugs to the pom files. > -- > > Key: RAT-369 > URL: https://issues.apache.org/jira/browse/RAT-369 > Project: Apache Rat > Issue Type: Improvement > Components: Client - ant, Client - cli, Client - maven, core engine >Reporter: Claude Warren >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > Currently we have a number of issues that Spotbugs will detect. I ran a > quick test this afternoon and it found 60 potential bugs. This ticket is to > add spotbugs to the maven build, ensure that no bugs are found and ensure > that the build will fail if bugs are found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2068186230 Most of the errors relate to the fact that many file operations rely on the default charset. Unfortunately newer version of the JDK provide constructors to specify an encoding, but as RAT still relies on JDK8 these changes will be bigger. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2067991533 @Claudenw the thing is that it either breaks the build or not. One can configure exclusions in an XML file in order to tolerate certain bugs explicitly . I'll have a look, but the first report said roughly up to 100 errors per submodule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
Claudenw commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2067961771 My thought was to turn on the spotbugs and fix any critical errors at that time (the ones with the red circles). We should then open fixes to remove the yellow ones and/or determine if there are way to ignore them in specific cases (annotations perhaps?) so that we can fix the ones that need fixing and mark the ones that we determine are not an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
