[jira] [Commented] (RAT-150) RAT should use Apache Tika to simply guess ignored [application/X] file types and focus on the [text/Y] family as a sensible default
[ https://issues.apache.org/jira/browse/RAT-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753677#comment-13753677 ] Chris A. Mattmann commented on RAT-150: --- Agree, will support this in a back compat way. I'm working on a patch for your guys review. Do you use Review Board? RAT should use Apache Tika to simply guess ignored [application/X] file types and focus on the [text/Y] family as a sensible default Key: RAT-150 URL: https://issues.apache.org/jira/browse/RAT-150 Project: Apache Rat Issue Type: New Feature Components: mime-meta-data, scan Affects Versions: 0.8 Reporter: Chris A. Mattmann RAT could use Apache Tika to automatically guess file types, obviating the need to specify an explicit white list or black list. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-148) LicenseAddingReport#report has useless call to metaData.getData
Chris A. Mattmann created RAT-148:
-
Summary: LicenseAddingReport#report has useless call to
metaData.getData
Key: RAT-148
URL: https://issues.apache.org/jira/browse/RAT-148
Project: Apache Rat
Issue Type: Bug
Components: reports
Reporter: Chris A. Mattmann
Fix For: 0.9
While perusing the current trunk code, I noticed that
LicenseAddingReport.java#report has a useless call to metaData.getData:
{code:java}
public class LicenseAddingReport extends AbstractReport {
private final AbstractLicenceAppender appender;
public LicenseAddingReport(String pCopyrightMsg, boolean pForced) {
appender = pCopyrightMsg == null ? new ApacheV2LicenceAppender() : new
ApacheV2LicenceAppender(pCopyrightMsg);
appender.setForce(pForced);
}
@Override
public void report(org.apache.rat.api.Document document) throws
RatException {
final MetaData metaData = document.getMetaData();
final Datum licenseHeader =
metaData.get(MetaData.RAT_URL_HEADER_CATEGORY);
if (licenseHeader == null
||
MetaData.RAT_LICENSE_FAMILY_CATEGORY_DATUM_UNKNOWN.getValue().equals(licenseHeader.getValue()))
{
final File file = new File(document.getName());
if (file.isFile()) {
try {
appender.append(file);
} catch (IOException e) {
throw new RatException(e.getMessage(), e);
}
}
}
metaData.getData();
}
}
{code}
Looks to me that metaData is a local final variable, and that the call to
getData returns a MetaData object, which in turn is never used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-148) LicenseAddingReport#report has useless call to metaData.getData
[
https://issues.apache.org/jira/browse/RAT-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris A. Mattmann updated RAT-148:
--
Attachment: RAT-148.Mattmann.082813.patch.txt
LicenseAddingReport#report has useless call to metaData.getData
---
Key: RAT-148
URL: https://issues.apache.org/jira/browse/RAT-148
Project: Apache Rat
Issue Type: Bug
Components: reports
Reporter: Chris A. Mattmann
Fix For: 0.9
Attachments: RAT-148.Mattmann.082813.patch.txt
While perusing the current trunk code, I noticed that
LicenseAddingReport.java#report has a useless call to metaData.getData:
{code:java}
public class LicenseAddingReport extends AbstractReport {
private final AbstractLicenceAppender appender;
public LicenseAddingReport(String pCopyrightMsg, boolean pForced) {
appender = pCopyrightMsg == null ? new ApacheV2LicenceAppender() :
new ApacheV2LicenceAppender(pCopyrightMsg);
appender.setForce(pForced);
}
@Override
public void report(org.apache.rat.api.Document document) throws
RatException {
final MetaData metaData = document.getMetaData();
final Datum licenseHeader =
metaData.get(MetaData.RAT_URL_HEADER_CATEGORY);
if (licenseHeader == null
||
MetaData.RAT_LICENSE_FAMILY_CATEGORY_DATUM_UNKNOWN.getValue().equals(licenseHeader.getValue()))
{
final File file = new File(document.getName());
if (file.isFile()) {
try {
appender.append(file);
} catch (IOException e) {
throw new RatException(e.getMessage(), e);
}
}
}
metaData.getData();
}
}
{code}
Looks to me that metaData is a local final variable, and that the call to
getData returns a MetaData object, which in turn is never used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-149) RAT provides no incremental output
[ https://issues.apache.org/jira/browse/RAT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris A. Mattmann updated RAT-149: -- Issue Type: Improvement (was: Bug) RAT provides no incremental output -- Key: RAT-149 URL: https://issues.apache.org/jira/browse/RAT-149 Project: Apache Rat Issue Type: Improvement Components: scan Affects Versions: 0.8 Reporter: Chris A. Mattmann I've got a current RAT job running through a fairly large (30Gb) Git repository and it's been running for over 8 days straight. We need RAT to generate incremental output, perhaps with a verbose flag, and something to the effect of: Processing [filename] Time to analyze: [Xms] Approved licenses: [Y] Disapproved licenses: [Z] Or something on 1 line, or whatever. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-149) RAT provides no incremental output
Chris A. Mattmann created RAT-149: - Summary: RAT provides no incremental output Key: RAT-149 URL: https://issues.apache.org/jira/browse/RAT-149 Project: Apache Rat Issue Type: Bug Components: scan Affects Versions: 0.8 Reporter: Chris A. Mattmann I've got a current RAT job running through a fairly large (30Gb) Git repository and it's been running for over 8 days straight. We need RAT to generate incremental output, perhaps with a verbose flag, and something to the effect of: Processing [filename] Time to analyze: [Xms] Approved licenses: [Y] Disapproved licenses: [Z] Or something on 1 line, or whatever. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
