[jira] [Created] (RAT-119) Upgrade Maven prerequisite to 2.0.6
Dennis Lundberg created RAT-119: --- Summary: Upgrade Maven prerequisite to 2.0.6 Key: RAT-119 URL: https://issues.apache.org/jira/browse/RAT-119 Project: Apache Rat Issue Type: Task Components: maven Affects Versions: 0.8 Reporter: Dennis Lundberg Fix For: 0.9 Because we use an updated version of plexus-utils in our code, we must upgrade to at least Maven 2.0.6. That is the first version of Maven which allows you to change the version of plexus-utils being used. Version of Maven prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-119) Upgrade Maven prerequisite to 2.0.6
[ https://issues.apache.org/jira/browse/RAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-119. --- Resolution: Fixed Fixed in [r1389108|http://svn.apache.org/viewvc?view=revision&revision=1389108]. > Upgrade Maven prerequisite to 2.0.6 > --- > > Key: RAT-119 > URL: https://issues.apache.org/jira/browse/RAT-119 > Project: Apache Rat > Issue Type: Task > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg > Fix For: 0.9 > > > Because we use an updated version of plexus-utils in our code, we must > upgrade to at least Maven 2.0.6. That is the first version of Maven which > allows you to change the version of plexus-utils being used. Version of Maven > prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-119) Upgrade Maven prerequisite to 2.0.6
[ https://issues.apache.org/jira/browse/RAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-119. --- Resolution: Fixed > Upgrade Maven prerequisite to 2.0.6 > --- > > Key: RAT-119 > URL: https://issues.apache.org/jira/browse/RAT-119 > Project: Apache Rat > Issue Type: Task > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.9 > > > Because we use an updated version of plexus-utils in our code, we must > upgrade to at least Maven 2.0.6. That is the first version of Maven which > allows you to change the version of plexus-utils being used. Version of Maven > prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (RAT-119) Upgrade Maven prerequisite to 2.0.6
[ https://issues.apache.org/jira/browse/RAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reopened RAT-119: - Assignee: Dennis Lundberg > Upgrade Maven prerequisite to 2.0.6 > --- > > Key: RAT-119 > URL: https://issues.apache.org/jira/browse/RAT-119 > Project: Apache Rat > Issue Type: Task > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.9 > > > Because we use an updated version of plexus-utils in our code, we must > upgrade to at least Maven 2.0.6. That is the first version of Maven which > allows you to change the version of plexus-utils being used. Version of Maven > prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-78) Support doxia 1.1.2
[ https://issues.apache.org/jira/browse/RAT-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-78. -- Resolution: Fixed Fix Version/s: 0.9 Assignee: Dennis Lundberg (was: Robert Burrell Donkin) Fixed in [r1396207|http://svn.apache.org/viewvc?view=revision&revision=1396207]. This also forces us to require Maven 2.2.1 to be able to run the plugin. > Support doxia 1.1.2 > --- > > Key: RAT-78 > URL: https://issues.apache.org/jira/browse/RAT-78 > Project: Apache Rat > Issue Type: New Feature > Components: maven >Affects Versions: 0.7 > Environment: Fedora Rawhide > maven-doxia 1.1.2 >Reporter: Orion Poplawski >Assignee: Dennis Lundberg > Fix For: 0.9 > > Attachments: apache-rat-0.8-doxia-1.1.patch, apache-rat-0.8-test.patch > > > Trying to package up apache-rat for Fedora. Fails to build from source with: > [INFO] Compilation failure > /builddir/build/BUILD/apache-rat-0.8-20100713/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java:[42,60] > package org.apache.maven.doxia.module.xhtml.decoration.render does not exist > /builddir/build/BUILD/apache-rat-0.8-20100713/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java:[215,12] > cannot find symbol > symbol : class RenderingContext > location: class org.apache.rat.mp.RatReportMojo > /builddir/build/BUILD/apache-rat-0.8-20100713/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java:[215,43] > cannot find symbol > symbol : class RenderingContext > location: class org.apache.rat.mp.RatReportMojo -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (RAT-119) Upgrade Maven prerequisite to 2.0.6
[ https://issues.apache.org/jira/browse/RAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reopened RAT-119: - > Upgrade Maven prerequisite to 2.0.6 > --- > > Key: RAT-119 > URL: https://issues.apache.org/jira/browse/RAT-119 > Project: Apache Rat > Issue Type: Task > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.9 > > > Because we use an updated version of plexus-utils in our code, we must > upgrade to at least Maven 2.0.6. That is the first version of Maven which > allows you to change the version of plexus-utils being used. Version of Maven > prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-119) Upgrade Maven prerequisite to 2.2.1
[ https://issues.apache.org/jira/browse/RAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-119. --- Resolution: Fixed Fixed in http://svn.apache.org/viewvc?view=revision&revision=1396207. > Upgrade Maven prerequisite to 2.2.1 > --- > > Key: RAT-119 > URL: https://issues.apache.org/jira/browse/RAT-119 > Project: Apache Rat > Issue Type: Task > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.9 > > > Because we use an updated version of plexus-utils in our code, we must > upgrade to at least Maven 2.0.6. That is the first version of Maven which > allows you to change the version of plexus-utils being used. Version of Maven > prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-119) Upgrade Maven prerequisite to 2.2.1
[ https://issues.apache.org/jira/browse/RAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472649#comment-13472649 ] Dennis Lundberg commented on RAT-119: - Fixing RAT-78 means that we need to require Maven 2.2.1. > Upgrade Maven prerequisite to 2.2.1 > --- > > Key: RAT-119 > URL: https://issues.apache.org/jira/browse/RAT-119 > Project: Apache Rat > Issue Type: Task > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.9 > > > Because we use an updated version of plexus-utils in our code, we must > upgrade to at least Maven 2.0.6. That is the first version of Maven which > allows you to change the version of plexus-utils being used. Version of Maven > prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-119) Upgrade Maven prerequisite to 2.2.1
[ https://issues.apache.org/jira/browse/RAT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-119: Summary: Upgrade Maven prerequisite to 2.2.1 (was: Upgrade Maven prerequisite to 2.0.6) > Upgrade Maven prerequisite to 2.2.1 > --- > > Key: RAT-119 > URL: https://issues.apache.org/jira/browse/RAT-119 > Project: Apache Rat > Issue Type: Task > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.9 > > > Because we use an updated version of plexus-utils in our code, we must > upgrade to at least Maven 2.0.6. That is the first version of Maven which > allows you to change the version of plexus-utils being used. Version of Maven > prior to 2.0.6 always use plexus-utils:1.1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-3) Incorrect alignment of file contents
[ https://issues.apache.org/jira/browse/RAT-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-3. - Resolution: Fixed > Incorrect alignment of file contents > > > Key: RAT-3 > URL: https://issues.apache.org/jira/browse/RAT-3 > Project: Apache Rat > Issue Type: Bug > Components: reports >Affects Versions: 0.6 >Reporter: Sebb >Priority: Minor > Fix For: 0.9 > > > The alignment of file contents is incorrect; the first line is indented, but > subsequent ones are not, e.g. > === > ==1.1-RC3/samples/osgi-supplychain/src/main/resources/osgi/ds/Shipper.mf > === > Manifest-Version: 1.0 > Bundle-ManifestVersion: 2 > Bundle-Name: Shipper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-124) Rat plugin should exclude the configuration directory used by IDEA
Dennis Lundberg created RAT-124: --- Summary: Rat plugin should exclude the configuration directory used by IDEA Key: RAT-124 URL: https://issues.apache.org/jira/browse/RAT-124 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.8 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.9 The plugin currently excludes the older file based configuration files for IDEA: *.ipr, *.iml, *.iws. It should also exclude the newer directory based configuration directory: .idea. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-124) Rat plugin should exclude the configuration directory used by IDEA
[ https://issues.apache.org/jira/browse/RAT-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-124. --- Resolution: Fixed Fixed in r1405594 http://svn.apache.org/viewvc?view=revision&revision=1405594 > Rat plugin should exclude the configuration directory used by IDEA > -- > > Key: RAT-124 > URL: https://issues.apache.org/jira/browse/RAT-124 > Project: Apache Rat > Issue Type: Bug > Components: maven >Affects Versions: 0.8 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.9 > > > The plugin currently excludes the older file based configuration files for > IDEA: *.ipr, *.iml, *.iws. It should also exclude the newer directory based > configuration directory: .idea. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAT-116) Docs don't say what the default excludes are
[ https://issues.apache.org/jira/browse/RAT-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-116. - Resolution: Fixed Fix Version/s: 0.9 Assignee: Dennis Lundberg Documentation updated in r1405598 to better show what is excluded http://svn.apache.org/viewvc?view=revision&revision=1405598 We should probably open new issues if we want to exclude more files by default. > Docs don't say what the default excludes are > > > Key: RAT-116 > URL: https://issues.apache.org/jira/browse/RAT-116 > Project: Apache Rat > Issue Type: Bug > Components: docs, maven >Reporter: Sebb >Assignee: Dennis Lundberg > Fix For: 0.9 > > > The description for "useDefaultExcludes" does not say what the excludes are. > The default should exclude .pmd but does not seem to. > Probably all .* files in the top level directory should be excluded. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-98) Maven RAT report does not document skipped files
[
https://issues.apache.org/jira/browse/RAT-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490248#comment-13490248
]
Dennis Lundberg commented on RAT-98:
The current behavior of the Maven plugin is to log the files that are excluded
in the build log.
It can look like this example, where I have excluded the BUILD.txt file:
[INFO]
[INFO] Building Apache Rat
[INFO]task-segment: [org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check]
[INFO]
[INFO] snapshot org.apache.rat:apache-rat-core:0.9-SNAPSHOT: checking for
updates from apache.snapshots
[INFO] [apache-rat:check {execution: default-cli}]
[INFO] Exclude: BUILD.txt
Did you want for this to be included in the report?
> Maven RAT report does not document skipped files
>
>
> Key: RAT-98
> URL: https://issues.apache.org/jira/browse/RAT-98
> Project: Apache Rat
> Issue Type: Bug
>Reporter: Sebb
>
> The Maven RAT report should document which files have been skipped using the
> option.
> Either by listing the configuration details, or better by listing the file
> names with a marker, e.g. EX to show they were deliberately skipped.
> Note: this only refers to files listed in entries, not files which
> are excluded by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-151) Detect more archive file formats
Dennis Lundberg created RAT-151: --- Summary: Detect more archive file formats Key: RAT-151 URL: https://issues.apache.org/jira/browse/RAT-151 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 There are a couple of obscure, and one not so obscure, archive formats that Rat doesn't detect today. These are: * ear * mar * par * xar -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-152) Recognize the format for .bsh, .fml and .jsp file types
Dennis Lundberg created RAT-152: --- Summary: Recognize the format for .bsh, .fml and .jsp file types Key: RAT-152 URL: https://issues.apache.org/jira/browse/RAT-152 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 These file type are currently not recognized, but they are easily mapped to already existing formats: .bsh -> C .fml -> SGML .jsp -> SGML -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (RAT-152) Recognize the format for .bsh, .fml and .jsp file types
[ https://issues.apache.org/jira/browse/RAT-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-152. - Resolution: Fixed Fixed in [r1545772|http://svn.apache.org/viewvc?view=revision&revision=1545772]. > Recognize the format for .bsh, .fml and .jsp file types > --- > > Key: RAT-152 > URL: https://issues.apache.org/jira/browse/RAT-152 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.11 > > > These file type are currently not recognized, but they are easily mapped to > already existing formats: > .bsh -> C > .fml -> SGML > .jsp -> SGML -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (RAT-151) Detect more archive file formats
[ https://issues.apache.org/jira/browse/RAT-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-151. - Resolution: Fixed Fixed in [r1545767|http://svn.apache.org/viewvc?view=revision&revision=1545767]. > Detect more archive file formats > > > Key: RAT-151 > URL: https://issues.apache.org/jira/browse/RAT-151 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.11 > > > There are a couple of obscure, and one not so obscure, archive formats that > Rat doesn't detect today. These are: > * ear > * mar > * par > * xar -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-153) Do not add extra empty lines when appending headers for the Apache License
Dennis Lundberg created RAT-153: --- Summary: Do not add extra empty lines when appending headers for the Apache License Key: RAT-153 URL: https://issues.apache.org/jira/browse/RAT-153 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 When adding license headers for the Apache License empty leading and trailing lines are added, although these lines should not be part of the license header. See http://www.apache.org/legal/src-headers.html for reference. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-154) Indentation of the license header should be decided per family
Dennis Lundberg created RAT-154: --- Summary: Indentation of the license header should be decided per family Key: RAT-154 URL: https://issues.apache.org/jira/browse/RAT-154 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 The current indentation of the license header is done the same way for every family of source files. This is not optimal as different families might want different indentations. Move the indentation to each family instead. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (RAT-153) Do not add extra empty lines when appending headers for the Apache License
[ https://issues.apache.org/jira/browse/RAT-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-153. - Resolution: Fixed Fixed in [r1545775|http://svn.apache.org/viewvc?view=revision&revision=1545775]. > Do not add extra empty lines when appending headers for the Apache License > -- > > Key: RAT-153 > URL: https://issues.apache.org/jira/browse/RAT-153 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.11 > > > When adding license headers for the Apache License empty leading and trailing > lines are added, although these lines should not be part of the license > header. > See http://www.apache.org/legal/src-headers.html for reference. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (RAT-154) Indentation of the license header should be decided per family
[ https://issues.apache.org/jira/browse/RAT-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-154. - Resolution: Fixed Fixed in [r1545780|http://svn.apache.org/viewvc?view=revision&revision=1545780]. > Indentation of the license header should be decided per family > -- > > Key: RAT-154 > URL: https://issues.apache.org/jira/browse/RAT-154 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.11 > > > The current indentation of the license header is done the same way for every > family of source files. This is not optimal as different families might want > different indentations. > Move the indentation to each family instead. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (RAT-135) addLicenseHeaders is missing a space on license header.
[ https://issues.apache.org/jira/browse/RAT-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-135. - Resolution: Fixed Fix Version/s: 0.11 Assignee: Dennis Lundberg Fixed in [r1545782|http://svn.apache.org/viewvc?view=revision&revision=1545782]. > addLicenseHeaders is missing a space on license header. > --- > > Key: RAT-135 > URL: https://issues.apache.org/jira/browse/RAT-135 > Project: Apache Rat > Issue Type: Bug > Components: cli, maven >Affects Versions: 0.10 >Reporter: Chris Riccomini >Assignee: Dennis Lundberg > Fix For: 0.11 > > > The Apache license that gets pre-pended by default is as follows: > bq. /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > *http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ > The last line is missing a space. It should be: > bq. /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > *http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-155) Do not add empty first and last lines in the license header for certain families
Dennis Lundberg created RAT-155: --- Summary: Do not add empty first and last lines in the license header for certain families Key: RAT-155 URL: https://issues.apache.org/jira/browse/RAT-155 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 For families with asymmetrical comment formats like C and SGML it makes sense to have specially crafted first and last lines, simply because the format demands them. For other families it makes no sense because they are just empty (commented out) lines, so they should be removed. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (RAT-155) Do not add empty first and last lines in the license header for certain families
[ https://issues.apache.org/jira/browse/RAT-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-155. - Resolution: Fixed Fixed in [r1545785|http://svn.apache.org/viewvc?view=revision&revision=1545785]. > Do not add empty first and last lines in the license header for certain > families > > > Key: RAT-155 > URL: https://issues.apache.org/jira/browse/RAT-155 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.11 > > > For families with asymmetrical comment formats like C and SGML it makes sense > to have specially crafted first and last lines, simply because the format > demands them. For other families it makes no sense because they are just > empty (commented out) lines, so they should be removed. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-156) Add some symmetry when applying license headers to files with file type specific headers
Dennis Lundberg created RAT-156:
---
Summary: Add some symmetry when applying license headers to files
with file type specific headers
Key: RAT-156
URL: https://issues.apache.org/jira/browse/RAT-156
Project: Apache Rat
Issue Type: Bug
Affects Versions: 0.10
Reporter: Dennis Lundberg
Assignee: Dennis Lundberg
Fix For: 0.11
Some file types may have a file type specific "header". For example a java file
should start with a package declaration, an XML file might have an XML
declaration and similarly for PHP files. The current output in not symmetrical
when applying license headers to these files.
Current formats, after license headers have been applied by Rat:
{code:xml}
[license header]
[empty line]
...
{code}
{code:java}
package org.apache.rat;
[license header]
[empty line]
public class MyClass {
...
}
{code}
We should add an empty line before the license headers, like this:
{code:xml}
[empty line]
[license header]
[empty line]
...
{code}
{code:java}
package org.apache.rat;
[empty line]
[license header]
[empty line]
public class MyClass {
...
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Resolved] (RAT-156) Add some symmetry when applying license headers to files with file type specific headers
[
https://issues.apache.org/jira/browse/RAT-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg resolved RAT-156.
-
Resolution: Fixed
Fixed in [r1545788|http://svn.apache.org/viewvc?view=revision&revision=1545788].
> Add some symmetry when applying license headers to files with file type
> specific headers
>
>
> Key: RAT-156
> URL: https://issues.apache.org/jira/browse/RAT-156
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Dennis Lundberg
>Assignee: Dennis Lundberg
> Fix For: 0.11
>
>
> Some file types may have a file type specific "header". For example a java
> file should start with a package declaration, an XML file might have an XML
> declaration and similarly for PHP files. The current output in not
> symmetrical when applying license headers to these files.
> Current formats, after license headers have been applied by Rat:
> {code:xml}
>
> [license header]
> [empty line]
>
> ...
>
> {code}
> {code:java}
> package org.apache.rat;
> [license header]
> [empty line]
> public class MyClass {
> ...
> }
> {code}
> We should add an empty line before the license headers, like this:
> {code:xml}
>
> [empty line]
> [license header]
> [empty line]
>
> ...
>
> {code}
> {code:java}
> package org.apache.rat;
> [empty line]
> [license header]
> [empty line]
> public class MyClass {
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (RAT-129) Add support for CDDL 1.0
[ https://issues.apache.org/jira/browse/RAT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832906#comment-13832906 ] Dennis Lundberg commented on RAT-129: - Shouldn't this issue be resolved if the patch has been applied? > Add support for CDDL 1.0 > > > Key: RAT-129 > URL: https://issues.apache.org/jira/browse/RAT-129 > Project: Apache Rat > Issue Type: Improvement >Reporter: Francesco Chicchiriccò > Fix For: 0.11 > > Attachments: RAT-129.patch > > > The CDDL 1.0 is not currently supported. > The attached patch adds this feature. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-159) Detect OpenOffice documents as being archives
Dennis Lundberg created RAT-159: --- Summary: Detect OpenOffice documents as being archives Key: RAT-159 URL: https://issues.apache.org/jira/browse/RAT-159 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 Rat currently does not recognize OpenOffice documents. This means that they will be flagged as not having a license header. They are in fact archives, so Rat should detect them as such. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (RAT-159) Detect OpenOffice documents as being archives
[ https://issues.apache.org/jira/browse/RAT-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-159. --- Resolution: Fixed Fixed in [r1585578|http://svn.apache.org/viewvc?view=revision&revision=1585578]. > Detect OpenOffice documents as being archives > - > > Key: RAT-159 > URL: https://issues.apache.org/jira/browse/RAT-159 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.11 > > > Rat currently does not recognize OpenOffice documents. This means that they > will be flagged as not having a license header. They are in fact archives, so > Rat should detect them as such. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (RAT-129) Add support for CDDL 1.0
[ https://issues.apache.org/jira/browse/RAT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reassigned RAT-129: --- Assignee: Sebb > Add support for CDDL 1.0 > > > Key: RAT-129 > URL: https://issues.apache.org/jira/browse/RAT-129 > Project: Apache Rat > Issue Type: Improvement >Reporter: Francesco Chicchiriccò >Assignee: Sebb > Fix For: 0.11 > > Attachments: RAT-129.patch > > > The CDDL 1.0 is not currently supported. > The attached patch adds this feature. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-129) Add support for CDDL 1.0
[ https://issues.apache.org/jira/browse/RAT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-129: Assignee: Sebb Sebb, you were the one who applied the patch. That means you are the assignee of this issue. > Add support for CDDL 1.0 > > > Key: RAT-129 > URL: https://issues.apache.org/jira/browse/RAT-129 > Project: Apache Rat > Issue Type: Improvement >Reporter: Francesco Chicchiriccò >Assignee: Sebb > Fix For: 0.11 > > Attachments: RAT-129.patch > > > The CDDL 1.0 is not currently supported. > The attached patch adds this feature. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[
https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965797#comment-13965797
]
Dennis Lundberg commented on RAT-160:
-
Christopher,
The way we in the Maven project use the Invoker plugin is to have the ITs
copied to the target directory before running the ITs, using this parameter:
{code}
${project.build.directory}/it
{code}
That way the build.log is tucked away somewhere under the target directory and
excluded from Rat. For more info see
http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-plugins/25/maven-plugins-25.pom
> Fails to ignore build.log created by maven-invoker-plugin
> -
>
> Key: RAT-160
> URL: https://issues.apache.org/jira/browse/RAT-160
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Christopher Tubbs
> Fix For: 0.11
>
>
> When using maven-invoker-plugin to run integration-tests for a maven plugin
> project, maven-invoker-plugin creates a build.log file in the basedir for the
> project.
> This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this
> file in its build directory, rather than its basedir. Regardless, the
> apache-rat-plugin should ignore this build.log file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[ https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968689#comment-13968689 ] Dennis Lundberg commented on RAT-160: - Christopher Tubbs, I'm not sure I understand your structure, but the Rat plugin excludes the "target" directory by default. So it should not be checked by Rat at all. Could you share you configuration? > Fails to ignore build.log created by maven-invoker-plugin > - > > Key: RAT-160 > URL: https://issues.apache.org/jira/browse/RAT-160 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Christopher Tubbs > Fix For: 0.11 > > > When using maven-invoker-plugin to run integration-tests for a maven plugin > project, maven-invoker-plugin creates a build.log file in the basedir for the > project. > This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this > file in its build directory, rather than its basedir. Regardless, the > apache-rat-plugin should ignore this build.log file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[ https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968761#comment-13968761 ] Dennis Lundberg commented on RAT-160: - Thanks, now I see more clearly. Why do you have the check-licenses-inner execution? The check-licenses-outer execution covers the main project, including all its IT projects. > Fails to ignore build.log created by maven-invoker-plugin > - > > Key: RAT-160 > URL: https://issues.apache.org/jira/browse/RAT-160 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Christopher Tubbs > Fix For: 0.11 > > > When using maven-invoker-plugin to run integration-tests for a maven plugin > project, maven-invoker-plugin creates a build.log file in the basedir for the > project. > This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this > file in its build directory, rather than its basedir. Regardless, the > apache-rat-plugin should ignore this build.log file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[ https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979981#comment-13979981 ] Dennis Lundberg commented on RAT-160: - Christopher, Sorry, you lost me again. Do you think you can put together a sample project structure that resembles what you want to do. What do you want to do with Rat? Do you want it to check your code for license headers? If so you'll only ever need one execution. > Fails to ignore build.log created by maven-invoker-plugin > - > > Key: RAT-160 > URL: https://issues.apache.org/jira/browse/RAT-160 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Christopher Tubbs > Fix For: 0.11 > > > When using maven-invoker-plugin to run integration-tests for a maven plugin > project, maven-invoker-plugin creates a build.log file in the basedir for the > project. > This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this > file in its build directory, rather than its basedir. Regardless, the > apache-rat-plugin should ignore this build.log file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-161) Support exclusion of paths: "path/to/file.ext"
[
https://issues.apache.org/jira/browse/RAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026438#comment-14026438
]
Dennis Lundberg commented on RAT-161:
-
Hi Erik,
First some questions that are not really related to your question. Are you
using Rat from the command line today? What build tool is Spark using? Perhaps
it would be easier for you to use either the Ant task or Maven plugin for Rat.
As far as I understand it, the -E option specifies a file that contains regular
expressions which are then used as exclude patterns. There is also the -e
option which can be used to specify an exclude pattern directly. Some examples
might explain better:
{noformat}
rat -E file-that-contains-regular-expressions
rat -e pattern-for-files-that-should-be-excluded
{noformat}
Over at the Maven project we use the Maven plugin to run Rat, and there we use
the excludes configuration, which corresponds to the -e option, see
http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html#excludes
Here is an example:
{code:xml}
org.apache.rat
apache-rat-plugin
src/it/multi-modules-aggregate/child-b/src/test/java/org/apache/maven/plugins/checkstyle/its/AppTest.java
src/main/resources/config/maven-header.txt
src/it/MCHECKSTYLE-225-customHeader/build-tools/src/main/resources/test/custom-header.txt
src/it/MCHECKSTYLE-225-LICENSE.txt/build-tools/src/main/resources/LICENSE.txt
src/main/resources/config/sun_checks.xml
{code}
Note that the code you referred to in SPARK-1493 is a very old branch from when
Rat was first accepted into the Incubator. Current code is in svn here:
http://svn.apache.org/viewvc/creadur/rat/trunk/
> Support exclusion of paths: "path/to/file.ext"
>
>
> Key: RAT-161
> URL: https://issues.apache.org/jira/browse/RAT-161
> Project: Apache Rat
> Issue Type: New Feature
> Components: reports
>Reporter: Erik Erlandson
>Priority: Minor
> Fix For: 0.11
>
>
> It would be advantageous to be able to exclude specific files, e.g.
> "path/to/file.ext"
> The current '-E' feature cannot do this, as the filter patterns are only
> applied to individual files as directory tree is traversed, so a filter will
> never see "path/to/file.ext", only "path", "to" and "file.ext"
> See for example: SPARK-1493
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (RAT-158) SAXParser warnings
[
https://issues.apache.org/jira/browse/RAT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070333#comment-14070333
]
Dennis Lundberg commented on RAT-158:
-
Confirmed on Windows 7 with Maven 3.0.5 using Java 1.7.0_60 and Java 1.8.0_05.
Cannot reproduce using Java 1.6.0_45. All versions are 64-bit.
> SAXParser warnings
> --
>
> Key: RAT-158
> URL: https://issues.apache.org/jira/browse/RAT-158
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
> Environment: Apache Maven 3.0.4
> Maven home: /usr/share/maven
> Java version: 1.6.0_30, vendor: Sun Microsystems Inc.
> Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.11.0-17-generic", arch: "amd64", family: "unix"
>Reporter: John Vines
>Priority: Minor
>
> I have rat configured as such
> {code}
> org.apache.rat
> apache-rat-plugin
> false
>
>
> verify
>
>check
>
>
>
>
>
> **/conf/**
>
>
>
> {code}
> And with every build where it triggers, I see
> {code}
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Feature
> 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[ https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-160: Fix Version/s: (was: 0.11) > Fails to ignore build.log created by maven-invoker-plugin > - > > Key: RAT-160 > URL: https://issues.apache.org/jira/browse/RAT-160 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Christopher Tubbs > > When using maven-invoker-plugin to run integration-tests for a maven plugin > project, maven-invoker-plugin creates a build.log file in the basedir for the > project. > This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this > file in its build directory, rather than its basedir. Regardless, the > apache-rat-plugin should ignore this build.log file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-161) Support exclusion of paths: "path/to/file.ext"
[ https://issues.apache.org/jira/browse/RAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-161: Fix Version/s: (was: 0.11) > Support exclusion of paths: "path/to/file.ext" > > > Key: RAT-161 > URL: https://issues.apache.org/jira/browse/RAT-161 > Project: Apache Rat > Issue Type: New Feature > Components: reports >Reporter: Erik Erlandson >Priority: Minor > Attachments: RAT-161.2.patch > > > It would be advantageous to be able to exclude specific files, e.g. > "path/to/file.ext" > The current '-E' feature cannot do this, as the filter patterns are only > applied to individual files as directory tree is traversed, so a filter will > never see "path/to/file.ext", only "path", "to" and "file.ext" > See for example: SPARK-1493 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-136) Upgrade commons-lang to latest commons-lang3
[ https://issues.apache.org/jira/browse/RAT-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-136: Fix Version/s: (was: 0.11) > Upgrade commons-lang to latest commons-lang3 > > > Key: RAT-136 > URL: https://issues.apache.org/jira/browse/RAT-136 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.8 >Reporter: Stevo Slavic >Assignee: Philipp Ottlinger >Priority: Trivial > Labels: build, maven > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-129) Add support for CDDL 1.0
[ https://issues.apache.org/jira/browse/RAT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-129: Assignee: Sebb Assigning issue to Sebb, as he was the one who fixed this issue. That makes this issue look like all the others in this regard, for the upcoming 0.11 release. > Add support for CDDL 1.0 > > > Key: RAT-129 > URL: https://issues.apache.org/jira/browse/RAT-129 > Project: Apache Rat > Issue Type: Improvement >Reporter: Francesco Chicchiriccò >Assignee: Sebb > Fix For: 0.11 > > Attachments: RAT-129.patch > > > The CDDL 1.0 is not currently supported. > The attached patch adds this feature. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-158) SAXParser warnings
[
https://issues.apache.org/jira/browse/RAT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095519#comment-14095519
]
Dennis Lundberg commented on RAT-158:
-
This java bug seems to be related:
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8016153
> SAXParser warnings
> --
>
> Key: RAT-158
> URL: https://issues.apache.org/jira/browse/RAT-158
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
> Environment: Apache Maven 3.0.4
> Maven home: /usr/share/maven
> Java version: 1.6.0_30, vendor: Sun Microsystems Inc.
> Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.11.0-17-generic", arch: "amd64", family: "unix"
>Reporter: John Vines
>Priority: Minor
>
> I have rat configured as such
> {code}
> org.apache.rat
> apache-rat-plugin
> false
>
>
> verify
>
>check
>
>
>
>
>
> **/conf/**
>
>
>
> {code}
> And with every build where it triggers, I see
> {code}
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Feature
> 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (RAT-169) IT tests it2 and it3 don't appear to be run
[ https://issues.apache.org/jira/browse/RAT-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097484#comment-14097484 ] Dennis Lundberg commented on RAT-169: - I moved the resources for these tests in [r1618014|http://svn.apache.org/viewvc?view=revision&revision=1618014] to make it more obvious that these tests are run during the unit testing phase. > IT tests it2 and it3 don't appear to be run > --- > > Key: RAT-169 > URL: https://issues.apache.org/jira/browse/RAT-169 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Sebb > > The Maven build output does not show that the it2 and it3 tests have been run. > I suspect this is because there are no it2/it3 folders under the invoker > folder. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-168) Add integration test for apache-rat:rat to catch NPE
[
https://issues.apache.org/jira/browse/RAT-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated RAT-168:
Summary: Add integration test for apache-rat:rat to catch NPE (was: Tests
don't check CLI usage)
> Add integration test for apache-rat:rat to catch NPE
>
>
> Key: RAT-168
> URL: https://issues.apache.org/jira/browse/RAT-168
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.11
>Reporter: Sebb
> Fix For: 0.11
>
>
> The unit/IT tests clearly don't test the Maven CLI functionality.
> mvn apache-rat:rat is currently failing with an NPE, even on the RAT project
> itself.
> To show this, do the following:
> {noformat}
> mvn or mvn clean install
> mvn -o org.apache.rat:apache-rat-plugin::0.12-SNAPSHOT:rat
> (change the version as required)
> {noformat}
> Note that the -o is essential, otherwise Maven will try to download the
> current snapshot
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (RAT-158) SAXParser warnings
[
https://issues.apache.org/jira/browse/RAT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102148#comment-14102148
]
Dennis Lundberg commented on RAT-158:
-
Hi Phillipp,
I don't think that is the problem described in this issue. The problem is not
that the value of the limit property is wrong, but rather that the newer JDKs
are setting properties that Xerces don't know about. I had a look in the latest
release of Xerces and the problem is still there, so upgrading to that version
will not work.
> SAXParser warnings
> --
>
> Key: RAT-158
> URL: https://issues.apache.org/jira/browse/RAT-158
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
> Environment: Apache Maven 3.0.4
> Maven home: /usr/share/maven
> Java version: 1.6.0_30, vendor: Sun Microsystems Inc.
> Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.11.0-17-generic", arch: "amd64", family: "unix"
>Reporter: John Vines
>Priority: Minor
>
> I have rat configured as such
> {code}
> org.apache.rat
> apache-rat-plugin
> false
>
>
> verify
>
>check
>
>
>
>
>
> **/conf/**
>
>
>
> {code}
> And with every build where it triggers, I see
> {code}
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Feature
> 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (RAT-170) RAT should use itself during build and site generation
[ https://issues.apache.org/jira/browse/RAT-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reassigned RAT-170: --- Assignee: Dennis Lundberg > RAT should use itself during build and site generation > -- > > Key: RAT-170 > URL: https://issues.apache.org/jira/browse/RAT-170 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11, 0.12 >Reporter: Philipp Ottlinger >Assignee: Dennis Lundberg > > During the work on 0.11 we had several issues with RAT itself that could have > been discovered if we had eaten our own dog food. > Thus: > * enable RAT site-report generation when running site:site > * always run RAT on RAT itself to prevent errors > to cover all goals provided by RAT itself. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-170) RAT should use itself during build and site generation
[ https://issues.apache.org/jira/browse/RAT-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124599#comment-14124599 ] Dennis Lundberg commented on RAT-170: - Always run Rat when building Rat was fixed in [r1622908|http://svn.apache.org/viewvc?view=revision&revision=1622908]. > RAT should use itself during build and site generation > -- > > Key: RAT-170 > URL: https://issues.apache.org/jira/browse/RAT-170 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11, 0.12 >Reporter: Philipp Ottlinger >Assignee: Dennis Lundberg > > During the work on 0.11 we had several issues with RAT itself that could have > been discovered if we had eaten our own dog food. > Thus: > * enable RAT site-report generation when running site:site > * always run RAT on RAT itself to prevent errors > to cover all goals provided by RAT itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (RAT-170) RAT should use itself during build and site generation
[ https://issues.apache.org/jira/browse/RAT-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-170. - Resolution: Fixed Enabled Rat site report in [r1622920|http://svn.apache.org/viewvc?view=revision&revision=1622920]. > RAT should use itself during build and site generation > -- > > Key: RAT-170 > URL: https://issues.apache.org/jira/browse/RAT-170 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11, 0.12 >Reporter: Philipp Ottlinger >Assignee: Dennis Lundberg > > During the work on 0.11 we had several issues with RAT itself that could have > been discovered if we had eaten our own dog food. > Thus: > * enable RAT site-report generation when running site:site > * always run RAT on RAT itself to prevent errors > to cover all goals provided by RAT itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-170) RAT should use itself during build and site generation
[ https://issues.apache.org/jira/browse/RAT-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-170: Fix Version/s: 0.12 > RAT should use itself during build and site generation > -- > > Key: RAT-170 > URL: https://issues.apache.org/jira/browse/RAT-170 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11, 0.12 >Reporter: Philipp Ottlinger >Assignee: Dennis Lundberg > Fix For: 0.12 > > > During the work on 0.11 we had several issues with RAT itself that could have > been discovered if we had eaten our own dog food. > Thus: > * enable RAT site-report generation when running site:site > * always run RAT on RAT itself to prevent errors > to cover all goals provided by RAT itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-167) Cleanup Build Infrastructure
[ https://issues.apache.org/jira/browse/RAT-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124638#comment-14124638 ] Dennis Lundberg commented on RAT-167: - Is there anything more that needs to be done on this issue? We have: - enforcement of Java version (1.5) in the POM with the help of maven-enforcer and animal-sniffer - requirement of Maven version (3.0.5) in the POM Documentation for the above is currently as comments in the POM file. > Cleanup Build Infrastructure > > > Key: RAT-167 > URL: https://issues.apache.org/jira/browse/RAT-167 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.12 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > > Currently there are the following build jobs that need to be cleaned up and > properly documented: > # buildbot > # Creadur-Rat > # Creadur-Rat-Site > Each build should enforce the correct targetJdk version. > Furthermore we need to discuss which maven version we rely on - see > WHISKER-12 for the same stuff in a different component. > Since many maven plugins remain on JDK5-compliant compiler level we should > use the same for all creadur maven plugins. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-167) Cleanup Build Infrastructure
[ https://issues.apache.org/jira/browse/RAT-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-167: Affects Version/s: (was: 0.12) 0.11 Fix Version/s: 0.12 > Cleanup Build Infrastructure > > > Key: RAT-167 > URL: https://issues.apache.org/jira/browse/RAT-167 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > Fix For: 0.12 > > > Currently there are the following build jobs that need to be cleaned up and > properly documented: > # buildbot > # Creadur-Rat > # Creadur-Rat-Site > Each build should enforce the correct targetJdk version. > Furthermore we need to discuss which maven version we rely on - see > WHISKER-12 for the same stuff in a different component. > Since many maven plugins remain on JDK5-compliant compiler level we should > use the same for all creadur maven plugins. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-172) Allow RAT maven plugin to filter out source code management files and directories automatically
[ https://issues.apache.org/jira/browse/RAT-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-172: Affects Version/s: (was: 0.12) 0.11 > Allow RAT maven plugin to filter out source code management files and > directories automatically > --- > > Key: RAT-172 > URL: https://issues.apache.org/jira/browse/RAT-172 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.11 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > > Following the discussions in RAT-171 we'd like to manage SCM defaults that > exclude the SCM's technical directory and its ignore file. > Currently that means: > * Subversion: .svn > * Git: .git and .gitignore > * Mercurial: .hg and .hgignore > * Bazar: .bzr and .bzrignore > * CVS: .cvs and .cvsignore > These defaults are activated as built-in defaults. The processing of ignore > files can be activated separately (see RAT-171). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-166) Introduce GSOC changes into current RAT version
[ https://issues.apache.org/jira/browse/RAT-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-166: Affects Version/s: (was: 0.12) 0.11 Fix Version/s: 0.12 > Introduce GSOC changes into current RAT version > --- > > Key: RAT-166 > URL: https://issues.apache.org/jira/browse/RAT-166 > Project: Apache Rat > Issue Type: New Feature >Affects Versions: 0.11 >Reporter: Philipp Ottlinger > Fix For: 0.12 > > > After releasing 0.11 we should merge the > [GSOC-branch|http://svn.apache.org/repos/asf/creadur/rat/branches/gsoc] into > trunk to get the improvements introduced during GoogleSummerOfCode 2013 by > Manuel Suárez Sánchez. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (RAT-137) Website shows incorrect Maven goals in some pages
[ https://issues.apache.org/jira/browse/RAT-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-137. --- Resolution: Fixed Fix Version/s: 0.10 Assignee: Sebb This has been fixed and the site has been deployed. > Website shows incorrect Maven goals in some pages > - > > Key: RAT-137 > URL: https://issues.apache.org/jira/browse/RAT-137 > Project: Apache Rat > Issue Type: Bug > Components: docs >Affects Versions: 0.9 >Reporter: Sebb >Assignee: Sebb > Fix For: 0.10 > > > Website shows incorrect Maven goals. > rat:check should be apache-rat:check > rat:rat => apache-rat:rat > in the following pages: > http://creadur.apache.org/rat/apache-rat-plugin/index.html > http://creadur.apache.org/rat/apache-rat-plugin/usage.html > There may be others that are wrong -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WHISKER-12) Cleanup Build Infrastructure
[ https://issues.apache.org/jira/browse/WHISKER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124707#comment-14124707 ] Dennis Lundberg commented on WHISKER-12: I've made these modifications: - Require Maven 3.0.5 (same as for Rat) - Enforce Java 1.6 with the help och Maven Enforcer and Animal Sniffer - Changed Jenkins jobs to use Maven 3.0.5 and JDK 1.6 (latest) to match our minimum requirements If we want to have builds that use Java 8, we should add additional jobs for that like we have done for Rat. > Cleanup Build Infrastructure > > > Key: WHISKER-12 > URL: https://issues.apache.org/jira/browse/WHISKER-12 > Project: Apache Whisker > Issue Type: Bug >Affects Versions: 0.2 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > > Introduce Jenkins jobs that build the artifacts - triggered by checkins and > run a site:site to ensure that the webpage can be build properly. > See ci-section of pom.xml for job names. > Each build should enforce the correct targetJdk version. > Which maven version do we rely on - keep in sync with rat via RAT-167. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (WHISKER-13) Error during site generation with HelpMojo and Java8
[
https://issues.apache.org/jira/browse/WHISKER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg reopened WHISKER-13:
Assignee: Dennis Lundberg (was: Philipp Ottlinger)
The work-around made the site build fail for Java 6 and 7.
> Error during site generation with HelpMojo and Java8
>
>
> Key: WHISKER-13
> URL: https://issues.apache.org/jira/browse/WHISKER-13
> Project: Apache Whisker
> Issue Type: Bug
>Affects Versions: 0.2
>Reporter: Philipp Ottlinger
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The compiler complains that the generated HelpMojo produces invalid Javadoc.
> This fails the site-builds.
> It's not really clear why we get these build errors since
> https://jira.codehaus.org/browse/MPLUGIN-244
> is solved in the version we are using (3.3)
> Explore what needs to be updated since we do not see this problem in RAT.
> The errors are:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-cli) on project
> apache-whisker: Error generating maven-javadoc-plugin:2.9.1:aggregate:
> [ERROR] Exit code: 1 -
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:24:
> error: self-closing element not allowed
> [ERROR] * Display help information on apache-whisker-plugin4maven.
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:26:
> warning: no description for @author
> [ERROR] * @author
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:27:
> warning: no description for @version
> [ERROR] * @version
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/apache-whisker-trunk/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> {noformat}
> when
> {noformat}
> mvn -Prat site:site
> {noformat}
> is run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WHISKER-13) Error during site generation with HelpMojo and Java8
[
https://issues.apache.org/jira/browse/WHISKER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg resolved WHISKER-13.
Resolution: Fixed
The problem was that the version for maven-plugin-plugin was not specified in
the build part of the POM, so the older buggy version 3.2 was used. Specified
the correct version in
[r1622985|http://svn.apache.org/viewvc?view=revision&revision=1622985].
> Error during site generation with HelpMojo and Java8
>
>
> Key: WHISKER-13
> URL: https://issues.apache.org/jira/browse/WHISKER-13
> Project: Apache Whisker
> Issue Type: Bug
>Affects Versions: 0.2
>Reporter: Philipp Ottlinger
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The compiler complains that the generated HelpMojo produces invalid Javadoc.
> This fails the site-builds.
> It's not really clear why we get these build errors since
> https://jira.codehaus.org/browse/MPLUGIN-244
> is solved in the version we are using (3.3)
> Explore what needs to be updated since we do not see this problem in RAT.
> The errors are:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-cli) on project
> apache-whisker: Error generating maven-javadoc-plugin:2.9.1:aggregate:
> [ERROR] Exit code: 1 -
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:24:
> error: self-closing element not allowed
> [ERROR] * Display help information on apache-whisker-plugin4maven.
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:26:
> warning: no description for @author
> [ERROR] * @author
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:27:
> warning: no description for @version
> [ERROR] * @version
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/apache-whisker-trunk/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> {noformat}
> when
> {noformat}
> mvn -Prat site:site
> {noformat}
> is run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (WHISKER-14) Change artifactId for the Maven plugin
Dennis Lundberg created WHISKER-14:
--
Summary: Change artifactId for the Maven plugin
Key: WHISKER-14
URL: https://issues.apache.org/jira/browse/WHISKER-14
Project: Apache Whisker
Issue Type: Improvement
Reporter: Dennis Lundberg
Assignee: Robert Burrell Donkin
Fix For: 0.2
The Maven plugin for Whisker currently has an artifactId of
apache-whisker-plugin4maven, which does not follow the standard naming
conventions for Maven plugins. The standard recommends -maven-plugin,
where is the tool that is run through the plugin. In our case the
correct artifactId would be apache-whisker-maven-plugin.
A hint that something is wrong can be seen by this warning in the build log:
{noformat}
[INFO] --- maven-plugin-plugin:3.3:descriptor (mojo-descriptor) @
apache-whisker-plugin4maven ---
[WARNING]
Goal prefix is specified as: 'plugin'. Maven currently expects it to be
'apache-whisker4'.
{noformat}
Somone has configured maven-plugin-plugin like this
plugin which translated to this syntax when calling
the Whisker Maven plugin from the command line:
{noformat}
mvn plugin:generate
{noformat}
which doesn't make any sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WHISKER-14) Change artifactId for the Maven plugin
[
https://issues.apache.org/jira/browse/WHISKER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg resolved WHISKER-14.
Resolution: Fixed
Assignee: Dennis Lundberg (was: Robert Burrell Donkin)
Fixed in [r1622990|http://svn.apache.org/viewvc?view=revision&revision=1622990].
> Change artifactId for the Maven plugin
> --
>
> Key: WHISKER-14
> URL: https://issues.apache.org/jira/browse/WHISKER-14
> Project: Apache Whisker
> Issue Type: Improvement
>Reporter: Dennis Lundberg
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The Maven plugin for Whisker currently has an artifactId of
> apache-whisker-plugin4maven, which does not follow the standard naming
> conventions for Maven plugins. The standard recommends -maven-plugin,
> where is the tool that is run through the plugin. In our case the
> correct artifactId would be apache-whisker-maven-plugin.
> A hint that something is wrong can be seen by this warning in the build log:
> {noformat}
> [INFO] --- maven-plugin-plugin:3.3:descriptor (mojo-descriptor) @
> apache-whisker-plugin4maven ---
> [WARNING]
> Goal prefix is specified as: 'plugin'. Maven currently expects it to be
> 'apache-whisker4'.
> {noformat}
> Somone has configured maven-plugin-plugin like this
> plugin which translated to this syntax when calling
> the Whisker Maven plugin from the command line:
> {noformat}
> mvn plugin:generate
> {noformat}
> which doesn't make any sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (WHISKER-13) Error during site generation with HelpMojo and Java8
[
https://issues.apache.org/jira/browse/WHISKER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg reopened WHISKER-13:
> Error during site generation with HelpMojo and Java8
>
>
> Key: WHISKER-13
> URL: https://issues.apache.org/jira/browse/WHISKER-13
> Project: Apache Whisker
> Issue Type: Bug
>Affects Versions: 0.2
>Reporter: Philipp Ottlinger
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The compiler complains that the generated HelpMojo produces invalid Javadoc.
> This fails the site-builds.
> It's not really clear why we get these build errors since
> https://jira.codehaus.org/browse/MPLUGIN-244
> is solved in the version we are using (3.3)
> Explore what needs to be updated since we do not see this problem in RAT.
> The errors are:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-cli) on project
> apache-whisker: Error generating maven-javadoc-plugin:2.9.1:aggregate:
> [ERROR] Exit code: 1 -
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:24:
> error: self-closing element not allowed
> [ERROR] * Display help information on apache-whisker-plugin4maven.
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:26:
> warning: no description for @author
> [ERROR] * @author
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:27:
> warning: no description for @version
> [ERROR] * @version
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/apache-whisker-trunk/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> {noformat}
> when
> {noformat}
> mvn -Prat site:site
> {noformat}
> is run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WHISKER-13) Error during site generation with Java8
[
https://issues.apache.org/jira/browse/WHISKER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated WHISKER-13:
---
Summary: Error during site generation with Java8 (was: Error during site
generation with HelpMojo and Java8)
> Error during site generation with Java8
> ---
>
> Key: WHISKER-13
> URL: https://issues.apache.org/jira/browse/WHISKER-13
> Project: Apache Whisker
> Issue Type: Bug
>Affects Versions: 0.2
>Reporter: Philipp Ottlinger
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The compiler complains that the generated HelpMojo produces invalid Javadoc.
> This fails the site-builds.
> It's not really clear why we get these build errors since
> https://jira.codehaus.org/browse/MPLUGIN-244
> is solved in the version we are using (3.3)
> Explore what needs to be updated since we do not see this problem in RAT.
> The errors are:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-cli) on project
> apache-whisker: Error generating maven-javadoc-plugin:2.9.1:aggregate:
> [ERROR] Exit code: 1 -
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:24:
> error: self-closing element not allowed
> [ERROR] * Display help information on apache-whisker-plugin4maven.
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:26:
> warning: no description for @author
> [ERROR] * @author
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:27:
> warning: no description for @version
> [ERROR] * @version
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/apache-whisker-trunk/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> {noformat}
> when
> {noformat}
> mvn -Prat site:site
> {noformat}
> is run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WHISKER-13) Error during site generation with Java8
[
https://issues.apache.org/jira/browse/WHISKER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124970#comment-14124970
]
Dennis Lundberg commented on WHISKER-13:
Now that we have a Jenkins job that builds the site using the latest Java 8,
another problem with the site build has been found. In the log it looks like
this:
{noformat}
[INFO] Generating "FindBugs" report ---
findbugs-maven-plugin:2.5.5:findbugs
[INFO] Locale is en
[INFO] Fork Value is true
[java] The following errors occurred during analysis:
[java] Unable to get XClass for java/lang/StringBuilder
[java] java.lang.ArrayIndexOutOfBoundsException: 5747
[java] At org.objectweb.asm.ClassReader.readClass(Unknown Source)
[java] At org.objectweb.asm.ClassReader.accept(Unknown Source)
[java] At
edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
[java] At org.objectweb.asm.ClassReader.accept(Unknown Source)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:110)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:587)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:76)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
[java] At
edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:268)
[java] At
edu.umd.cs.findbugs.ba.XFactory.getXClass(XFactory.java:652)
[java] At
edu.umd.cs.findbugs.ba.ch.Subtypes2.addInheritanceEdge(Subtypes2.java:1260)
[java] At
edu.umd.cs.findbugs.ba.ch.Subtypes2.addSupertypeEdges(Subtypes2.java:1233)
[java] At
edu.umd.cs.findbugs.ba.ch.Subtypes2.addClassAndGetClassVertex(Subtypes2.java:275)
[java] At
edu.umd.cs.findbugs.ba.ch.Subtypes2.addClass(Subtypes2.java:244)
[java] At
edu.umd.cs.findbugs.ba.AnalysisContext.setAppClassList(AnalysisContext.java:941)
[java] At
edu.umd.cs.findbugs.FindBugs2.setAppClassList(FindBugs2.java:997)
[java] At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:225)
[java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:393)
[java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1317)
{noformat}
This is most likely due to ASM, which is a common problem with Java 8.
> Error during site generation with Java8
> ---
>
> Key: WHISKER-13
> URL: https://issues.apache.org/jira/browse/WHISKER-13
> Project: Apache Whisker
> Issue Type: Bug
>Affects Versions: 0.2
>Reporter: Philipp Ottlinger
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The compiler complains that the generated HelpMojo produces invalid Javadoc.
> This fails the site-builds.
> It's not really clear why we get these build errors since
> https://jira.codehaus.org/browse/MPLUGIN-244
> is solved in the version we are using (3.3)
> Explore what needs to be updated since we do not see this problem in RAT.
> The errors are:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-cli) on project
> apache-whisker: Error generating maven-javadoc-plugin:2.9.1:aggregate:
> [ERROR] Exit code: 1 -
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:24:
> error: self-closing element not allowed
> [ERROR] * Display help information on apache-whisker-plugin4maven.
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:26:
> warning: no description for @author
> [ERROR] * @author
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:27:
> warning: no description for @version
> [ERROR] * @version
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/apache-whisker-trunk/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> {noformat}
> when
> {noformat}
> mvn -Prat site:site
> {noformat}
> is run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WHISKER-13) Error during site generation with Java8
[
https://issues.apache.org/jira/browse/WHISKER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg resolved WHISKER-13.
Resolution: Fixed
Added conditional versioning for Findbugs Maven Plugin in
[r1622908|http://svn.apache.org/viewvc?view=revision&revision=1622908]. When
using Java 6 and 7 we use version 2.5.5 of the plugin, and when running on Java
8+ we use version 3.0.0 instead. This works for me locally. Let us hope it
makes Jenkins happy as well.
> Error during site generation with Java8
> ---
>
> Key: WHISKER-13
> URL: https://issues.apache.org/jira/browse/WHISKER-13
> Project: Apache Whisker
> Issue Type: Bug
>Affects Versions: 0.2
>Reporter: Philipp Ottlinger
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The compiler complains that the generated HelpMojo produces invalid Javadoc.
> This fails the site-builds.
> It's not really clear why we get these build errors since
> https://jira.codehaus.org/browse/MPLUGIN-244
> is solved in the version we are using (3.3)
> Explore what needs to be updated since we do not see this problem in RAT.
> The errors are:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-cli) on project
> apache-whisker: Error generating maven-javadoc-plugin:2.9.1:aggregate:
> [ERROR] Exit code: 1 -
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:24:
> error: self-closing element not allowed
> [ERROR] * Display help information on apache-whisker-plugin4maven.
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:26:
> warning: no description for @author
> [ERROR] * @author
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:27:
> warning: no description for @version
> [ERROR] * @version
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/apache-whisker-trunk/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> {noformat}
> when
> {noformat}
> mvn -Prat site:site
> {noformat}
> is run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (WHISKER-13) Error during site generation with Java8
[
https://issues.apache.org/jira/browse/WHISKER-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124971#comment-14124971
]
Dennis Lundberg edited comment on WHISKER-13 at 9/7/14 5:13 PM:
Added conditional versioning for Findbugs Maven Plugin in
[r1623073|http://svn.apache.org/viewvc?view=revision&revision=1623073]. When
using Java 6 and 7 we use version 2.5.5 of the plugin, and when running on Java
8+ we use version 3.0.0 instead. This works for me locally. Let us hope it
makes Jenkins happy as well.
was (Author: denn...@apache.org):
Added conditional versioning for Findbugs Maven Plugin in
[r1622908|http://svn.apache.org/viewvc?view=revision&revision=1622908]. When
using Java 6 and 7 we use version 2.5.5 of the plugin, and when running on Java
8+ we use version 3.0.0 instead. This works for me locally. Let us hope it
makes Jenkins happy as well.
> Error during site generation with Java8
> ---
>
> Key: WHISKER-13
> URL: https://issues.apache.org/jira/browse/WHISKER-13
> Project: Apache Whisker
> Issue Type: Bug
>Affects Versions: 0.2
>Reporter: Philipp Ottlinger
>Assignee: Dennis Lundberg
> Fix For: 0.2
>
>
> The compiler complains that the generated HelpMojo produces invalid Javadoc.
> This fails the site-builds.
> It's not really clear why we get these build errors since
> https://jira.codehaus.org/browse/MPLUGIN-244
> is solved in the version we are using (3.3)
> Explore what needs to be updated since we do not see this problem in RAT.
> The errors are:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-cli) on project
> apache-whisker: Error generating maven-javadoc-plugin:2.9.1:aggregate:
> [ERROR] Exit code: 1 -
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:24:
> error: self-closing element not allowed
> [ERROR] * Display help information on apache-whisker-plugin4maven.
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:26:
> warning: no description for @author
> [ERROR] * @author
> [ERROR] ^
> [ERROR]
> /apache-whisker-trunk/apache-whisker-plugin4maven/target/generated-sources/plugin/org/apache/creadur/whisker/plugin/maven/HelpMojo.java:27:
> warning: no description for @version
> [ERROR] * @version
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/apache-whisker-trunk/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> {noformat}
> when
> {noformat}
> mvn -Prat site:site
> {noformat}
> is run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WHISKER-12) Cleanup Build Infrastructure
[ https://issues.apache.org/jira/browse/WHISKER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved WHISKER-12. Resolution: Fixed > Cleanup Build Infrastructure > > > Key: WHISKER-12 > URL: https://issues.apache.org/jira/browse/WHISKER-12 > Project: Apache Whisker > Issue Type: Bug >Affects Versions: 0.2 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > > Introduce Jenkins jobs that build the artifacts - triggered by checkins and > run a site:site to ensure that the webpage can be build properly. > See ci-section of pom.xml for job names. > Each build should enforce the correct targetJdk version. > Which maven version do we rely on - keep in sync with rat via RAT-167. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WHISKER-12) Cleanup Build Infrastructure
[ https://issues.apache.org/jira/browse/WHISKER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124978#comment-14124978 ] Dennis Lundberg commented on WHISKER-12: Now we also have: - Jenkins jobs that build Whisker and generates the Maven site using the latest Java 8, both of which are now successful - Changed the minimum version to *use* the Whisker Maven Plugin from 3.2.3 to 2.2.1, which is the same as for Rat I think that we are finished with this issue now. > Cleanup Build Infrastructure > > > Key: WHISKER-12 > URL: https://issues.apache.org/jira/browse/WHISKER-12 > Project: Apache Whisker > Issue Type: Bug >Affects Versions: 0.2 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > > Introduce Jenkins jobs that build the artifacts - triggered by checkins and > run a site:site to ensure that the webpage can be build properly. > See ci-section of pom.xml for job names. > Each build should enforce the correct targetJdk version. > Which maven version do we rely on - keep in sync with rat via RAT-167. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (RAT-186) BinaryGuesser should recognize PSD files as images
Dennis Lundberg created RAT-186: --- Summary: BinaryGuesser should recognize PSD files as images Key: RAT-186 URL: https://issues.apache.org/jira/browse/RAT-186 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.11 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.12 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-170) RAT should use itself during build and site generation
[ https://issues.apache.org/jira/browse/RAT-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-170: Issue Type: Improvement (was: Bug) > RAT should use itself during build and site generation > -- > > Key: RAT-170 > URL: https://issues.apache.org/jira/browse/RAT-170 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.11, 0.12 >Reporter: Philipp Ottlinger >Assignee: Dennis Lundberg > Fix For: 0.12 > > > During the work on 0.11 we had several issues with RAT itself that could have > been discovered if we had eaten our own dog food. > Thus: > * enable RAT site-report generation when running site:site > * always run RAT on RAT itself to prevent errors > to cover all goals provided by RAT itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-167) Cleanup Build Infrastructure
[ https://issues.apache.org/jira/browse/RAT-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-167: Issue Type: Task (was: Bug) > Cleanup Build Infrastructure > > > Key: RAT-167 > URL: https://issues.apache.org/jira/browse/RAT-167 > Project: Apache Rat > Issue Type: Task >Affects Versions: 0.11 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > Fix For: 0.12 > > > Currently there are the following build jobs that need to be cleaned up and > properly documented: > # buildbot > # Creadur-Rat > # Creadur-Rat-Site > Each build should enforce the correct targetJdk version. > Furthermore we need to discuss which maven version we rely on - see > WHISKER-12 for the same stuff in a different component. > Since many maven plugins remain on JDK5-compliant compiler level we should > use the same for all creadur maven plugins. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-181) BinaryGuesser should treat *.truststore as binary
[ https://issues.apache.org/jira/browse/RAT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-181: Issue Type: Improvement (was: Bug) > BinaryGuesser should treat *.truststore as binary > - > > Key: RAT-181 > URL: https://issues.apache.org/jira/browse/RAT-181 > Project: Apache Rat > Issue Type: Improvement >Reporter: Sebb > Fix For: 0.12 > > > BinaryGuesser treats KEYSTORE files as binary so it should also treat > TRUSTSTORE files as binary -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (RAT-186) BinaryGuesser should recognize PSD files as images
[ https://issues.apache.org/jira/browse/RAT-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-186. --- Resolution: Fixed Fixed in [r1636676|http://svn.apache.org/viewvc?view=revision&revision=1636676] and [r1636685|http://svn.apache.org/viewvc?view=revision&revision=1636685]. > BinaryGuesser should recognize PSD files as images > -- > > Key: RAT-186 > URL: https://issues.apache.org/jira/browse/RAT-186 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.11 >Reporter: Dennis Lundberg >Assignee: Dennis Lundberg > Fix For: 0.12 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-172) Allow RAT maven plugin to filter out source code management files and directories automatically
[ https://issues.apache.org/jira/browse/RAT-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196611#comment-14196611 ] Dennis Lundberg commented on RAT-172: - I've reviewed your changes and they look OK. Should we close this issue as fixed? > Allow RAT maven plugin to filter out source code management files and > directories automatically > --- > > Key: RAT-172 > URL: https://issues.apache.org/jira/browse/RAT-172 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.11 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger > > Following the discussions in RAT-171 we'd like to manage SCM defaults that > exclude the SCM's technical directory and its ignore file. > Currently that means: > * Subversion: .svn > * Git: .git and .gitignore > * Mercurial: .hg and .hgignore > * Bazar: .bzr and .bzrignore > * CVS: .cvs and .cvsignore > These defaults are activated as built-in defaults. The processing of ignore > files can be activated separately (see RAT-171). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (RAT-157) Use the *ignore file for the SCM to determine excludes
[ https://issues.apache.org/jira/browse/RAT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-157. --- Resolution: Duplicate > Use the *ignore file for the SCM to determine excludes > -- > > Key: RAT-157 > URL: https://issues.apache.org/jira/browse/RAT-157 > Project: Apache Rat > Issue Type: New Feature >Reporter: lucas theisen >Priority: Minor > > As I understand it, RAT is used to ensure the LICENSE text is in all source > files. Anything ignored by SCM is not technically a source file. These > other files are usually specific to the developer environment. And the > developer will already be adding such files to their own `SCMignore`. > Perhaps a pluggable ingore mechanism that could have an implementation per > SCM and would know how to parse that ignore and translate filter out all the > files it specifies. Perhaps this could be an option to the the rat config > `useGitIgnore` or something. What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-103) Proposal: automatic code formatting based on an example eclipse formater with maven-java-formatter-plugin performed by mvn before each compilation
[
https://issues.apache.org/jira/browse/RAT-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196625#comment-14196625
]
Dennis Lundberg commented on RAT-103:
-
In my experience code formatters does a decent job, but not a good enough job
to have the automatically reformat all code. So I agree with Stefan and Sebb. I
suggest we close this issue as "Won't Fix".
> Proposal: automatic code formatting based on an example eclipse formater with
> maven-java-formatter-plugin performed by mvn before each compilation
> --
>
> Key: RAT-103
> URL: https://issues.apache.org/jira/browse/RAT-103
> Project: Apache Rat
> Issue Type: Improvement
> Components: maven
>Affects Versions: 0.9
> Environment: Trunk Revision: 1203844
>Reporter: Philipp Ottlinger
> Labels: maven
> Attachments: BinaryGuesser.java.diff,
> RAT103pomAdditionOfFormatterPlugin.txt, ratFormatter.xml
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Currently the whole source code is not formatted uniquely (some classes use
> C-style, some Java-style).
> The Apache2-licensed maven plugin
> http://code.google.com/p/maven-java-formatter-plugin/ provides an automated
> means to format the code uniquely with each compile.
> Since it changes the whole trunk I didn't include a full patch, but only an
> example formater file that needs to be referenced and additions to pom.xml.
> h3. Pom Addition
> {code}
>
>
> com.googlecode.maven-java-formatter-plugin
> maven-java-formatter-plugin
> 0.3.1
>
>
>
> format
>
>
>
>
> ./ratFormatter.xml
> 1.4
> 1.4
> 1.4
> UTF-8
> LF
>
>
> {code}
> The formatter file needs toi be put on a publicly readable place and is
> referenced inside of the pom.
> h3. example formatter
> {code}
>
>
>
> id="org.eclipse.jdt.core.formatter.comment.insert_new_line_before_root_tags"
> value="insert"/>
> value="@formatter:off"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_annotation"
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_type_parameters"
> value="do not insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_type_declaration"
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_type_arguments"
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.brace_position_for_anonymous_type_declaration"
> value="end_of_line"/>
> id="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_case"
> value="do not insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_opening_brace_in_array_initializer"
> value="do not insert"/>
> id="org.eclipse.jdt.core.formatter.comment.new_lines_at_block_boundaries"
> value="true"/>
> id="org.eclipse.jdt.core.formatter.insert_new_line_in_empty_annotation_declaration"
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.insert_new_line_before_closing_brace_in_array_initializer"
> value="do not insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_annotation"
> value="do not insert"/>
> value="0"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_while"
> value="do not insert"/>
>
> id="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_annotation_type_member_declaration"
> value="do not insert"/>
> id="org.eclipse.jdt.core.formatter.insert_new_line_before_else_in_if_statement"
> value="do not insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_prefix_operator"
> value="do not insert"/>
> value="false"/>
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.comment.insert_new_line_for_parameter"
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_annotation_type_declaration"
> value="insert"/>
> value="true"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_at_in_annotation"
> value="do not insert"/>
> value="16"/>
> id="org.eclipse.jdt.core.formatter.alignment_for_expressions_in_array_initializer"
> value="16"/>
> id="org.eclipse.jdt.core.formatter.alignment_for_conditional_expression"
> value="80"/>
> id="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_for"
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_after_binary_operator"
> value="insert"/>
> id="org.eclipse.jdt.core.formatter.insert_space_before_question_in_wildcard"
> value="do not insert"/>
> id="org.eclipse.jdt.core.formatter.brace_position_for_arra
[jira] [Assigned] (RAT-187) Add 'SAR', 'HAR', 'WSR' as archives which should be ignored.
[ https://issues.apache.org/jira/browse/RAT-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reassigned RAT-187: --- Assignee: Dennis Lundberg > Add 'SAR', 'HAR', 'WSR' as archives which should be ignored. > > > Key: RAT-187 > URL: https://issues.apache.org/jira/browse/RAT-187 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.12 >Reporter: Karl Heinz Marbaise >Assignee: Dennis Lundberg >Priority: Minor > Attachments: RAT-187.patch > > > It would good to ignore HAR (Hibernate Archive), SAR (Service Archive), WSR > (Web Service Archive). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (RAT-187) Add 'SAR', 'HAR', 'WSR' as archives which should be ignored.
[ https://issues.apache.org/jira/browse/RAT-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-187. --- Resolution: Fixed Fix Version/s: 0.12 Fixed in [r1636696|http://svn.apache.org/viewvc?view=revision&revision=1636696]. Thanks for the patch! > Add 'SAR', 'HAR', 'WSR' as archives which should be ignored. > > > Key: RAT-187 > URL: https://issues.apache.org/jira/browse/RAT-187 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.12 >Reporter: Karl Heinz Marbaise >Assignee: Dennis Lundberg >Priority: Minor > Fix For: 0.12 > > Attachments: RAT-187.patch > > > It would good to ignore HAR (Hibernate Archive), SAR (Service Archive), WSR > (Web Service Archive). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (RAT-185) .repository folder should be ignored
[
https://issues.apache.org/jira/browse/RAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg closed RAT-185.
---
Resolution: Fixed
Fix Version/s: 0.12
Fixed in [r1636706|http://svn.apache.org/viewvc?view=revision&revision=1636706].
I added the {{.repository}} directory to the default Maven excludes.
> .repository folder should be ignored
> -
>
> Key: RAT-185
> URL: https://issues.apache.org/jira/browse/RAT-185
> Project: Apache Rat
> Issue Type: Improvement
> Components: maven
>Affects Versions: 0.12
>Reporter: Karl Heinz Marbaise
>Assignee: Dennis Lundberg
>Priority: Minor
> Fix For: 0.12
>
>
> Currently i have observed on many jenkins servers which are configured to use
> a repository local to the workspace that RAT will fail cause it will check
> all files in {{.repository}} which contains the downloaded artifacts and
> usually don't correct license header not can contain it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (RAT-185) .repository folder should be ignored
[
https://issues.apache.org/jira/browse/RAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg reassigned RAT-185:
---
Assignee: Dennis Lundberg
> .repository folder should be ignored
> -
>
> Key: RAT-185
> URL: https://issues.apache.org/jira/browse/RAT-185
> Project: Apache Rat
> Issue Type: Improvement
> Components: maven
>Affects Versions: 0.12
>Reporter: Karl Heinz Marbaise
>Assignee: Dennis Lundberg
>Priority: Minor
>
> Currently i have observed on many jenkins servers which are configured to use
> a repository local to the workspace that RAT will fail cause it will check
> all files in {{.repository}} which contains the downloaded artifacts and
> usually don't correct license header not can contain it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196851#comment-14196851
]
Dennis Lundberg commented on RAT-171:
-
It is possible (at least in trunk) to turn on/off using SCM ignores files such
as {{.gitignore}} via the {{useDefaultExcludes}} parameter.
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: Improvement
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Attachments: RAT-171.patch
>
>
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (RAT-61) List files with unapproved licenses in Maven output
[
https://issues.apache.org/jira/browse/RAT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg closed RAT-61.
--
Resolution: Fixed
Fix Version/s: 0.12
Assignee: Dennis Lundberg
Fixed in
[r1636753|http://svn.apache.org/viewvc?view=revision&revision=1636753]. I added
a parameter {{consoleOutput}} that you need to set to {{true}} to enable output
to the console. It can also be used from the command line using
{{-Drat.consoleOutput=true}}.
> List files with unapproved licenses in Maven output
> ---
>
> Key: RAT-61
> URL: https://issues.apache.org/jira/browse/RAT-61
> Project: Apache Rat
> Issue Type: Improvement
> Components: maven
>Reporter: Jukka Zitting
>Assignee: Dennis Lundberg
>Priority: Minor
> Fix For: 0.12
>
>
> Like RAT-37, but for console output by the Maven plugin. Currently the RAT
> plugin simply outputs the number of unapproved licenses as a part of the
> build error message. While you can find the offending files by looking at
> target/rat.txt, it would be nicer if the files (at least if there are just a
> few of them) were directly listed in the console output.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (RAT-157) Use the *ignore file for the SCM to determine excludes
[ https://issues.apache.org/jira/browse/RAT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reopened RAT-157: - > Use the *ignore file for the SCM to determine excludes > -- > > Key: RAT-157 > URL: https://issues.apache.org/jira/browse/RAT-157 > Project: Apache Rat > Issue Type: New Feature >Reporter: lucas theisen >Priority: Minor > > As I understand it, RAT is used to ensure the LICENSE text is in all source > files. Anything ignored by SCM is not technically a source file. These > other files are usually specific to the developer environment. And the > developer will already be adding such files to their own `SCMignore`. > Perhaps a pluggable ingore mechanism that could have an implementation per > SCM and would know how to parse that ignore and translate filter out all the > files it specifies. Perhaps this could be an option to the the rat config > `useGitIgnore` or something. What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-171) Allow exclude patterns to be read from a file or files
[
https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196939#comment-14196939
]
Dennis Lundberg commented on RAT-171:
-
Yes, my bad. I thought that the implementation for RAT-172 actually excluded
the files that are specified inside the {{.gitignore}} file. I've reopened
RAT-157.
> Allow exclude patterns to be read from a file or files
> --
>
> Key: RAT-171
> URL: https://issues.apache.org/jira/browse/RAT-171
> Project: Apache Rat
> Issue Type: Improvement
>Affects Versions: 0.11
>Reporter: Ignasi Barrera
>Assignee: Philipp Ottlinger
> Attachments: RAT-171.patch
>
>
> The apache-rat-plugin ignores by default the .gitignore files. However, for
> every file/pattern added to those files, an explicit exclusion must be set in
> the plugin's configuration.
> Given that git-ignored files won't be uploaded to the SCM and shouldn't be
> part of a release, it would be nice that the apache-rat-plugin automatically
> considered those git-ignored files as implicit exclusions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-61) List files with unapproved licenses in Maven output
[ https://issues.apache.org/jira/browse/RAT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197673#comment-14197673 ] Dennis Lundberg commented on RAT-61: It outputs the full path for each file that has an unapproved license. I have pushed a 0.12-SNAPSHOT to the repo, so you can give it a try. Feedback is welcome. > List files with unapproved licenses in Maven output > --- > > Key: RAT-61 > URL: https://issues.apache.org/jira/browse/RAT-61 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Reporter: Jukka Zitting >Assignee: Dennis Lundberg >Priority: Minor > Fix For: 0.12 > > > Like RAT-37, but for console output by the Maven plugin. Currently the RAT > plugin simply outputs the number of unapproved licenses as a part of the > build error message. While you can find the offending files by looking at > target/rat.txt, it would be nicer if the files (at least if there are just a > few of them) were directly listed in the console output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-171) Allow exclude patterns to be read from a file or files
[ https://issues.apache.org/jira/browse/RAT-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197676#comment-14197676 ] Dennis Lundberg commented on RAT-171: - In my opinion RAT-172 is about excluding files like .gitignore from being checked by Rat, and RAT-171 is about parsing files like .gitignore and excluding the files mentioned inside it from being checked by Rat. If we can agree on that, then RAT-172 can be closed as fixed. > Allow exclude patterns to be read from a file or files > -- > > Key: RAT-171 > URL: https://issues.apache.org/jira/browse/RAT-171 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.11 >Reporter: Ignasi Barrera >Assignee: Philipp Ottlinger > Attachments: RAT-171.patch > > > The apache-rat-plugin ignores by default the .gitignore files. However, for > every file/pattern added to those files, an explicit exclusion must be set in > the plugin's configuration. > Given that git-ignored files won't be uploaded to the SCM and shouldn't be > part of a release, it would be nice that the apache-rat-plugin automatically > considered those git-ignored files as implicit exclusions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
